Re: [PATCH] media: qcom: camss: configure C-PHY in the new csiphy_stream_on()

[Anusha Arun Nandi <anusha.nandi@oss.qualcomm.com>]

Hi Krzysztof,

Thank you for the heads-up. Apologies for the noisy CC list — some
internal addresses slipped through from a prior workflow. I'll fix this
going forward.

I'll re-run scripts/get_maintainers.pl --no-git-fallback on a current
mainline tree and switch to using b4 prep --auto-to-cc to manage the CC
list properly before sending the next revision.

Thanks again for the guidance.

Best regards,
Anusha

On 10/17/2026 1:07 AM, Krzysztof Kozlowski wrote:
> On 17/10/2026 06:05, Anusha Arun Nandi wrote:
>> The new (non-legacy) csiphy_stream_on() introduced by the PHY API
>> devices support only built a MIPI D-PHY configuration and
>> unconditionally called phy_set_mode(PHY_MODE_MIPI_DPHY). For a C-PHY
>> sensor this makes phy_configure() dispatch to the C-PHY handler with a
>> D-PHY opts union, which fails validation.
>>
>> Branch on the recorded PHY type: for C-PHY build the opts via
>> phy_mipi_cphy_get_default_config_for_hsclk(), populate the per-trio
>> lane positions and polarities and select PHY_MODE_MIPI_CPHY; 
>> keep the existing D-PHY path otherwise. The shared
>> phy_configure()/phy_power_on() tail handles both.
> 
> I received multiple patchsets from you. CC list looks really random,
> half of the addresses are some internal ones?
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> Best regards,
> Krzysztof