From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: powerpc: "make install" broken
Date: Sat, 12 Aug 2006 16:59:24 +0200 [thread overview]
Message-ID: <81b0412b0608120759h313bbdc9hfd6e3b3acd8a3d3d@mail.gmail.com> (raw)
In-Reply-To: <20060812143451.GA18642@mars.ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On 8/12/06, Sam Ravnborg <sam@ravnborg.org> wrote:
> > I don't know if ever worked before, just tried today on v2.6.17.
> > Maybe it works, but then it is very different to i386
> > where it is plain "make install".
> >
> > I copied the implementation attached from i386 (modified a bit), which
> > fixed it for me. Maybe the patch will motivate someone to fix it properly...
> NACK - the install target shall not try to build the kernel - the
> vmlinux dependency is long gone from i386.
Agreed, updated, rediffed, attached
(sorry for attach, that's gmail).
[-- Attachment #2: ppc-fix-make-install.patch --]
[-- Type: text/x-patch, Size: 1156 bytes --]
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index ed5b26a..85b0c4b 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -156,6 +156,9 @@ boot := arch/$(ARCH)/boot
$(BOOT_TARGETS): vmlinux
$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
+install:
+ $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) install
+
define archhelp
@echo '* zImage - Compressed kernel image (arch/$(ARCH)/boot/zImage.*)'
@echo ' install - Install kernel using'
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 840ae59..6bfc3ec 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -209,7 +209,7 @@ extra-y += vmlinux.bin vmlinux.gz
@echo -n ' Image: $@ '
@if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi
-install: $(CONFIGURE) $(BOOTIMAGE)
- sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" "$(BOOTIMAGE)"
+install:
+ sh $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)"
clean-files += $(addprefix $(objtree)/, $(obj-boot) vmlinux.strip)
next prev parent reply other threads:[~2006-08-12 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 14:29 Alex Riesen
2006-08-12 14:32 ` Alex Riesen
2006-08-12 14:34 ` Sam Ravnborg
2006-08-12 14:59 ` Alex Riesen [this message]
2006-08-12 16:30 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0608120759h313bbdc9hfd6e3b3acd8a3d3d@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®