mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Frans Pop" <elendil@planet.nl>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
	linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx,
	linux-pm@lists.linux-foundation.org
Subject: Re: sdhci: Loads of scary messages during suspend/resume with SD card inserted
Date: Tue, 7 Oct 2008 20:01:33 +0200	[thread overview]
Message-ID: <81b0412b0810071101l40b74e82o808cb6998148428c@mail.gmail.com> (raw)
In-Reply-To: <200809292000.19489.elendil@planet.nl>

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

2008/9/29 Frans Pop <elendil@planet.nl>:
> On Monday 29 September 2008, Matthew Garrett wrote:
>> More to the point, how about this one? It should also handle the resume
>> case, but I haven't tested it yet.
>
> Thanks Matthew.
>
> For the second part of the quirk the device name is incorrect. It should
> be r5c832 instead of rl5c832 and the DECLAREs also have the wrong device.

I'm attaching my patch with these corrections.

> After fixing that it compiles correctly and does improve things a lot, but
> there are still remaining issues. I suspect these are probably unrelated
> to the proprietary controller though.

Confirm that for Dell XPS M1330.

> All that was still without having a partition mounted. After resume a vfat
> partition on the card can be mounted successfully.

This works here (Ubuntu 8.04.1, v2.6.27-rc9). It is likely the hald
configuration
on Ubuntu as to why it works:

Oct  7 19:52:34 blimp hald: unmounted /dev/mmcblk0p1 from
'/media/disk' on behalf of uid 0

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fixed-ricoh-mmc-pci-quirk.patch --]
[-- Type: text/x-diff; name=fixed-ricoh-mmc-pci-quirk.patch, Size: 1307 bytes --]

From 635d8102535fb18e07197677a426af9309948b49 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa@blimp.localhost>
Date: Tue, 7 Oct 2008 19:46:01 +0200
Subject: [PATCH] Fix the pci quirk for Ricoh R5C832 which disables the mmc controller


diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 4557fa3..0737fe9 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1835,7 +1835,7 @@ DECLARE_PCI_FIXUP_RESUME_EARLY(PCI_VENDOR_ID_RICOH,
 			       PCI_DEVICE_ID_RICOH_RL5C476,
 			       quirk_ricoh_rl5c476_mmc_disable);
 
-static void quirk_ricoh_rl5c832_mmc_disable(struct pci_dev *dev)
+static void quirk_ricoh_r5c832_mmc_disable(struct pci_dev *dev)
 {
 	u8 disable;
 	u8 write_enable;
@@ -1852,11 +1852,11 @@ static void quirk_ricoh_rl5c832_mmc_disable(struct pci_dev *dev)
 }
 
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_RICOH,
-			 PCI_DEVICE_ID_RICOH_RL5C476,
-			 quirk_ricoh_rl5c832_mmc_disable);
+			 PCI_DEVICE_ID_RICOH_R5C832,
+			 quirk_ricoh_r5c832_mmc_disable);
 DECLARE_PCI_FIXUP_RESUME_EARLY(PCI_VENDOR_ID_RICOH,
-			       PCI_DEVICE_ID_RICOH_RL5C476,
-			       quirk_ricoh_rl5c832_mmc_disable);
+			       PCI_DEVICE_ID_RICOH_R5C832,
+			       quirk_ricoh_r5c832_mmc_disable);
 
 #ifdef CONFIG_PCI_MSI
 /* Some chipsets do not support MSI. We cannot easily rely on setting

  reply	other threads:[~2008-10-07 18:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-28 19:46 Frans Pop
2008-09-28 20:04 ` Frans Pop
2008-09-28 22:42   ` Rafael J. Wysocki
2008-09-29 11:38 ` Matthew Garrett
2008-09-29 12:11   ` Matthew Garrett
2008-09-29 18:00     ` Frans Pop
2008-10-07 18:01       ` Alex Riesen [this message]
2008-11-14  1:41     ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0810071101l40b74e82o808cb6998148428c@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=elendil@planet.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®