From: Alex Riesen <raa.lkml@gmail.com>
To: Eric Paris <eparis@redhat.com>
Cc: Keith Packard <keithp@keithp.com>,
linux-kernel@vger.kernel.org, john@johnmccutchan.com,
rlove@rlove.org, eparis@parisplace.org
Subject: Re: [PATCH] fs/notify/inotify: decrement user inotify count on close
Date: Sun, 26 Jul 2009 17:46:49 +0200 [thread overview]
Message-ID: <81b0412b0907260846i1cce0e81m6c7bf99263fb4c1@mail.gmail.com> (raw)
In-Reply-To: <1246536889.22562.74.camel@dhcp235-23.rdu.redhat.com>
On Thu, Jul 2, 2009 at 14:14, Eric Paris<eparis@redhat.com> wrote:
> On Wed, 2009-07-01 at 21:56 -0700, Keith Packard wrote:
>> The per-user inotify_devs value is incremented each time a new file is
>> allocated, but never decremented. This led to inotify_init failing after a
>> limited number of calls.
>>
>> Signed-off-by: Keith Packard <keithp@keithp.com>
>
> Thanks, I will push to Linus later today, sorry about the regression!
>
Hmm... Either the patch wasn't enough, or it was broken again.
On v2.6.31-rc4, I get this:
# echo 10 >/proc/sys/fs/inotify/max_user_watches
# inotifywatch -r /usr/lib # generate watches up to the limit
Establishing watches...
Failed to watch /bin; upper limit on inotify watches reached!
Please increase the amount of inotify watches allowed per user via
`/proc/sys/fs/inotify/max_user_watches'.
# inotifywatch /bin/true # just one watch for just one file
AFAIU, the second inotifywatch should work, and the watches of the first,
failed, run must be cleared.
next prev parent reply other threads:[~2009-07-26 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 4:56 Keith Packard
2009-07-02 12:14 ` Eric Paris
2009-07-26 15:46 ` Alex Riesen [this message]
2009-07-26 15:57 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0907260846i1cce0e81m6c7bf99263fb4c1@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=john@johnmccutchan.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®