From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05701C4167E for ; Mon, 9 May 2022 08:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237305AbiEII6M (ORCPT ); Mon, 9 May 2022 04:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233443AbiEIIjr (ORCPT ); Mon, 9 May 2022 04:39:47 -0400 X-Greylist: delayed 1011 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 09 May 2022 01:35:52 PDT Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C528AC067 for ; Mon, 9 May 2022 01:35:51 -0700 (PDT) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1nnyaf-000NM9-2A; Mon, 09 May 2022 10:18:01 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnyae-0002yS-G0; Mon, 09 May 2022 10:18:00 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id CA7A3240049; Mon, 9 May 2022 10:17:59 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 7B958240040; Mon, 9 May 2022 10:17:59 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id E20EE27512; Mon, 9 May 2022 10:17:58 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 09 May 2022 10:17:58 +0200 From: Florian Eckert To: Randy Dunlap Cc: kernel test robot , Arnd Bergmann , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Alex Shi , Nick Desaulniers , Miguel Ojeda , Nathan Chancellor , Guenter Roeck Subject: Re: drivers/hwmon/ltq-cputemp.c:23:2: error: call to undeclared function 'ltq_cgu_w32'; ISO C99 and later do not support implicit function declarations In-Reply-To: <65c92404-1d6f-6969-89bf-20b8eefaeff6@infradead.org> References: <202205080416.vzIXy16B-lkp@intel.com> <65c92404-1d6f-6969-89bf-20b8eefaeff6@infradead.org> Message-ID: <81b9b2cd3f981b6206e9d8c52b3306b3@dev.tdt.de> X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate: clean X-purgate-ID: 151534::1652084280-0000C1DF-9F1DFEF7/0/0 X-purgate-type: clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> vim +/ltq_cgu_w32 +23 drivers/hwmon/ltq-cputemp.c >> >> 7074d0a9275860 Florian Eckert 2017-09-01 20 >> 7074d0a9275860 Florian Eckert 2017-09-01 21 static void >> ltq_cputemp_enable(void) >> 7074d0a9275860 Florian Eckert 2017-09-01 22 { >> 7074d0a9275860 Florian Eckert 2017-09-01 @23 >> ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) | CGU_TEMP_PD, CGU_GPHY1_CR); >> 7074d0a9275860 Florian Eckert 2017-09-01 24 } >> 7074d0a9275860 Florian Eckert 2017-09-01 25 >> >> :::::: The code at line 23 was first introduced by commit >> :::::: 7074d0a92758603369655ef5d4f49e6caaae0b4e hwmon: (ltq-cputemp) >> add cpu temp sensor driver >> >> :::::: TO: Florian Eckert >> :::::: CC: Guenter Roeck > > This driver builds fine if I change it from SOC_FALCON to SOC_XWAY. > Maybe its Kconfig entry should be stronger? > > config SENSORS_LTQ_CPUTEMP > bool "Lantiq cpu temperature sensor driver" > - depends on LANTIQ > + depends on SOC_XWAY Fine with me. I think it's better to narrow it down. Because this macro is only available for the SOC_TYPE_XWAY [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h?h=v5.17.6#n10 Best regards -- Florian