From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7CBC433FE for ; Sat, 12 Nov 2022 16:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234963AbiKLQaS (ORCPT ); Sat, 12 Nov 2022 11:30:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232663AbiKLQaP (ORCPT ); Sat, 12 Nov 2022 11:30:15 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47D6711C12 for ; Sat, 12 Nov 2022 08:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3wIT72RKQRo9T1EZzWzDg8w//z6Ef/o85SJsudPE3Bw=; b=SWQJFhTzXSZGQky2ctHg2HStR5 +IFSW2Q8WSaCTkp3S8Mf0wyOGM5N8pnZ17AA0fQG6QMFx3jc+6xOT7X8b3roJrNI8jqqT8aNyh3oX h0gOCFVD9QfcH38fJxttUMJKuaGpzTots2I8ChaVkbPDf0sy5tvEYVU8cRQ0c3xjrmDCMP+aVStzP 91b2wkT/lHZQ4E/0k20VkHi/ZvFmt1PUCkJJ/ByEjwznHS3Wz+QGhymNvdJPwAPPbPd63SiduHQky JCYnZG6uwJUNkM9YK0c9YlS+BY2SVw0zrSsJRLy8yW+k0TPTSitB/0s/KIAjtSY53IV0EIVFeV1UI KZYF5/dA==; Received: from [2a01:799:95a:cb00:9d29:d4c4:45a0:777e] (port=49715) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ottOV-00077k-DC; Sat, 12 Nov 2022 17:30:11 +0100 Message-ID: <81ba376a-c177-d7c7-58a5-968d89760ad2@tronnes.org> Date: Sat, 12 Nov 2022 17:30:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 15/24] drm/client: Remove match on mode name To: Maxime Ripard , Maarten Lankhorst , Chen-Yu Tsai , Maxime Ripard , Jernej Skrabec , Karol Herbst , Jani Nikula , Daniel Vetter , Lyude Paul , Samuel Holland , Joonas Lahtinen , Thomas Zimmermann , Emma Anholt , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Ben Skeggs Cc: nouveau@lists.freedesktop.org, Dom Cobley , intel-gfx@lists.freedesktop.org, Phil Elwell , linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Hans de Goede , linux-kernel@vger.kernel.org, Dave Stevenson , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <20220728-rpi-analog-tv-properties-v8-0-09ce1466967c@cerno.tech> <20220728-rpi-analog-tv-properties-v8-15-09ce1466967c@cerno.tech> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20220728-rpi-analog-tv-properties-v8-15-09ce1466967c@cerno.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 10.11.2022 12.07, skrev Maxime Ripard: > Commit 3aeeb13d8996 ("drm/modes: Support modes names on the command > line") initially introduced the named modes support by essentially > matching the name passed on the command-line to the mode names defined > by the drivers. > > This proved to be difficult to work with, since all drivers had to > provide properly named modes. This was also needed because we weren't > passing a full blown-mode to the drivers, but were only filling its > name. > > Thanks to the previous patches, we now generate a proper mode, and we > thus can use the usual matching algo on timings, and can simply drop the > name match. > > Suggested-by: Noralf Trønnes > Signed-off-by: Maxime Ripard > > --- Reviewed-by: Noralf Trønnes