From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC302C352BE for ; Sat, 18 Apr 2020 01:01:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B67DA20771 for ; Sat, 18 Apr 2020 01:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbgDRBBT (ORCPT ); Fri, 17 Apr 2020 21:01:19 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2401 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725768AbgDRBBT (ORCPT ); Fri, 17 Apr 2020 21:01:19 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A47E78BB899F881ED6C9; Sat, 18 Apr 2020 09:01:14 +0800 (CST) Received: from [127.0.0.1] (10.166.215.235) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Sat, 18 Apr 2020 09:01:06 +0800 Subject: Re: [PATCH] buffer: remove useless comment and WB_REASON_FREE_MORE_MEM, reason. To: Jan Kara CC: , , , "Jens Axboe" , "linux-kernel@vger.kernel.org" , , , , linfeilong , Yanxiaodan , Mingfangsen , renxudong References: <5844aa66-de1e-278b-5491-b7e6839640e9@huawei.com> <20200414150929.GD28226@quack2.suse.cz> From: Zhiqiang Liu Message-ID: <81bf1cd4-0319-bc62-dbdf-701d39edd23a@huawei.com> Date: Sat, 18 Apr 2020 09:01:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200414150929.GD28226@quack2.suse.cz> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.166.215.235] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org friendly ping... On 2020/4/14 23:09, Jan Kara wrote: > On Mon 13-04-20 13:12:10, Zhiqiang Liu wrote: >> From: Zhiqiang Liu >> >> free_more_memory func has been completely removed in commit bc48f001de12 >> ("buffer: eliminate the need to call free_more_memory() in __getblk_slow()") >> >> So comment and `WB_REASON_FREE_MORE_MEM` reason about free_more_memory >> are no longer needed. >> >> Signed-off-by: Zhiqiang Liu > > Thanks. The patch looks good to me. You can add: > > Reviewed-by: Jan Kara > > Honza > >> --- >> fs/buffer.c | 2 +- >> include/linux/backing-dev-defs.h | 1 - >> include/trace/events/writeback.h | 1 - >> 3 files changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/fs/buffer.c b/fs/buffer.c >> index b8d28370cfd7..07ab0405f3f5 100644 >> --- a/fs/buffer.c >> +++ b/fs/buffer.c >> @@ -973,7 +973,7 @@ grow_dev_page(struct block_device *bdev, sector_t block, >> struct page *page; >> struct buffer_head *bh; >> sector_t end_block; >> - int ret = 0; /* Will call free_more_memory() */ >> + int ret = 0; >> gfp_t gfp_mask; >> >> gfp_mask = mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS) | gfp; >> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h >> index 4fc87dee005a..ee577a83cfe6 100644 >> --- a/include/linux/backing-dev-defs.h >> +++ b/include/linux/backing-dev-defs.h >> @@ -54,7 +54,6 @@ enum wb_reason { >> WB_REASON_SYNC, >> WB_REASON_PERIODIC, >> WB_REASON_LAPTOP_TIMER, >> - WB_REASON_FREE_MORE_MEM, >> WB_REASON_FS_FREE_SPACE, >> /* >> * There is no bdi forker thread any more and works are done >> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h >> index d94def25e4dc..85a33bea76f1 100644 >> --- a/include/trace/events/writeback.h >> +++ b/include/trace/events/writeback.h >> @@ -36,7 +36,6 @@ >> EM( WB_REASON_SYNC, "sync") \ >> EM( WB_REASON_PERIODIC, "periodic") \ >> EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \ >> - EM( WB_REASON_FREE_MORE_MEM, "free_more_memory") \ >> EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \ >> EMe(WB_REASON_FORKER_THREAD, "forker_thread") >> >> -- >> 2.19.1 >> >>