From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22E6F408033 for ; Thu, 4 Jun 2026 10:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780570470; cv=none; b=BaSf18cf+GGaCoO0PZ76dYf/ROPWCRISg2kj8E4uA7+l1Ty/vVLKTJGvvtDQsEQZLexVUo/E6IXqj2RcCOQqJ/AuD5cHkzbTgev6Ndr9QfUAJcX1XEMxGbL72qzaG7k8dVCRUQBqsC3kO6gMp3kTJr2vNZqxpcH0GDSEh+VG+9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780570470; c=relaxed/simple; bh=scvY+dflouvP3WjbFewFlJ+s3wcSoSglkisnCRmgzio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LzA7g2fwBfR3Ro4T0hq30gTTyXbkwdUSA471FT7SKbuOPKZFwic9E4nrwAC3yY+0+xEARHGbT9OYRvvCeSajwA1i7Xp5yJaysauzSqr02YyFY3CueMo0stm0ggjeixTdvVEc66QvmUuOiECjCGK0fpRIHpHM+2cBg1stgw9coes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=buE1OBR6; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="buE1OBR6" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-39666c7c910so533011fa.2 for ; Thu, 04 Jun 2026 03:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780570464; x=1781175264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=bCnxhfojGBE4En3AxLCMLMPhWtZG8rg5zO2UJYy4dS8=; b=buE1OBR6bEQ7yvMBHuZ3NIA2NIqOPblVwrPI7CHVaL63pKifJCxeh0ENQFeOItfGU8 0hAIqe8DX9u4m8MusUApQPOVaizkwM3cATevvLIKWMCCZwtEOXrqSQPqRaWLLwml9wig zQzfv2/2+kaRZD8dVRolL0l/P7LUAPxCbE+vXRlVs+6PkaeFaskjcEQypUsY4LrUJ5f1 gyhHLA3TA70iYUIMov+PSNRmqAOouiDRCQOVh66jXOCs9o96hUxdlEWxLMxJ4HoMpIGS 3w2XDL3nud4TvVOT+0b0bdyRHV8sG8ePLoM5oALln00hTij2fHLRS9ZmcHb1psE+W2ue bwdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780570464; x=1781175264; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bCnxhfojGBE4En3AxLCMLMPhWtZG8rg5zO2UJYy4dS8=; b=c3IMo7m/xXVD3RPjeH1kM6L6p6tBK1F31F9BwTP6TpL6ON5tIlkAuUoSTCYp3Dw1nn d0LmXQIQ2COlfpSx2EHy9qvHaAAyHLUF29PnV++ivvJB026Xa8osMswtngxThQ2+TF3M G/JPoY7jNpIA7CPvAwNR4mThIvsU1m2yyJT63n/21Doui0ZqEgJCnbEqiqirUhjY/X7a jlThs5MEa9drIz3tE5xmkBbW6ivktJZ7hTdzx4lSnWxhO90wSX2c1ClRoTL2mKwQTYbC GBNOxBdyI7J4q/KgN++t0av5RmZEwC9UDPTzIRFfMEXbHArUaeT84Zbhc86JrsJATarp VOKA== X-Forwarded-Encrypted: i=1; AFNElJ/7jYU+l5TwfmcgsK5Zg92Bym38+OZHbCYZDnytnmhEhj8R742/7rW42P/ejERI5jVJriFw23QEYsD92Iw=@vger.kernel.org X-Gm-Message-State: AOJu0YxTCuE49ZO65dsGkpE4zNIZHQJnR9ncuQpFftM3OJez961WbmLi V4HJiZRT/HzLwPznAHacxg06MgDRzkeMvp2xw4hEqjmgDPTznrrwn7P2RwZQ0R/W0IE= X-Gm-Gg: Acq92OFimD2W9r41DR+zNdqC1OCGSselAu/v7TZHVf6O08HjiBfcqx9Dm8NmWIT1hxi DLAs7F/f2oeMGundzTZBuOSxTzeDlnjWNT1g9PQXOaR0eHBqcG/hrnQYZoJ34xKmP5B1yQdhMGX 6xQFoQojB379kjSk18scKRP8LtCJ9oFrxwXBu72k6s1vULjNGIWK85zQbNlX3YO9C5zY0L1khBJ ZKj/aEYJ8OYhH49s4tBpVi4c77SK9hmUy0fjFgbyH4FuytvRddL3j1kGd1kA1Mix7Ih25Ntsvck G2EnfVSfP5TvfQE33wG7GL0f2pdtNYXZxYE1Qm1GrLnmNdKEtvDNClXn7tjzT9WYnLWJeyAASul j4OAYeXshPKyB2X7ifb9jkzFf49//8dZ+daNUY4cmLqkvIiVOQwhmnYIFwV/K3oQd3A8zfpdy3S 7jBe4zG4R0j+lP1IklLzBIFq45XgzCPQG1WRaHJwUMryEDIHKnqi2AoVDBUmtu6LGLydPKDg+7m q/zDRswzZJdYwhb X-Received: by 2002:a2e:be20:0:b0:396:92eb:36a0 with SMTP id 38308e7fff4ca-396bed4f78amr3316271fa.0.1780570463834; Thu, 04 Jun 2026 03:54:23 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-396ac2d5ec0sm15504751fa.33.2026.06.04.03.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 03:54:23 -0700 (PDT) Message-ID: <81c069f2-bb15-44cc-aefc-a44c1c6396c6@linaro.org> Date: Thu, 4 Jun 2026 13:54:22 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260523-x1e-csi2-phy-v8-0-a85668459521@linaro.org> <20260523-x1e-csi2-phy-v8-1-a85668459521@linaro.org> <478df3ed-d4ef-43aa-bb84-e2075798542b@kernel.org> From: Vladimir Zapolskiy In-Reply-To: <478df3ed-d4ef-43aa-bb84-e2075798542b@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/3/26 01:51, Bryan O'Donoghue wrote: > On 02/06/2026 22:59, Vladimir Zapolskiy wrote: >> On 5/23/26 05:48, Bryan O'Donoghue wrote: >>> Add a base schema initially compatible with x1e80100 to describe MIPI CSI2 >>> PHY devices. >>> >>> The hardware can support both CPHY, DPHY and a special split-mode DPHY. >>> >>> The schema here defines three ports: >>> >>> port@0: >>> The first input port where a sensor is always required. >>> >>> port@1: >>> A second optional input port which if present implies DPHY split-mode. >>> >>> port@2: >>> A third always required output port which connects to the controller. >>> >> >> This port numeration is imperfect, because port@0 and port@2 are required, >> while middle port@1 is optional. >> >> Like it was stated before a number of times, it seems natural to operate >> with two ports, where input port may have two endpoints rather than 3 ports, >> also that approach solves the problem of a hole in the port numeration. > > Can you confirm this is what you are after ? > > port@0 { > #address-cells = <1>; > #size-cells = <0>; > > endpoint@0 { /* primary sensor */ > reg = <0>; > data-lanes = <0 1 2 3>; > remote-endpoint = <&sensor0_out>; > }; > > endpoint@1 { /* split-mode second sensor, optional */ > reg = <1>; > data-lanes = <0>; > remote-endpoint = <&sensor1_out>; > }; > }; > > port@1 { /* output to CAMSS, was port@2 */ > endpoint { remote-endpoint = <&controller_in>; }; > }; > > This works for me BTW. > Something like this will be a much better description, below are additional notes: 1. for endpoints to sensors data-lanes and clock-lanes should be specified, 2. as it was stated before the numeration should start from 1, 3. output port may be just removed, otherwise there are supposed to be 3 (!) links between the umbrella CAMSS and children CSIPHY devices, namely the links are a) parent-child layout, b) phy connection and c) media endpoints, it sounds as an excessive overload, where a simplification is possible. -- Best wishes, Vladimir