From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Sunil-kumar.Dommati@amd.com, ssabakar@amd.com,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
Vijendar.Mukunda@amd.com,
V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: Refactor bit width calculation
Date: Mon, 30 Jan 2023 15:28:22 +0200 [thread overview]
Message-ID: <81c25623-8689-759a-026e-b49190bc19cf@linux.intel.com> (raw)
In-Reply-To: <20230130100104.4076640-1-venkataprasad.potturu@amd.com>
On 30/01/2023 12:01, Venkata Prasad Potturu wrote:
> Refactor bit width calculation using params_physical_width()
> instead hard-code values.
I would have added a Reported-by tag for Pierre...
A Fixes tag might also help this patch to follow
ca9d237994db ("ASoC: amd: acp: Refactor i2s clocks programming sequence")
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
> ---
> sound/soc/amd/acp/acp-mach-common.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
> index b83ae946b3e4..b4dcce4fbae9 100644
> --- a/sound/soc/amd/acp/acp-mach-common.c
> +++ b/sound/soc/amd/acp/acp-mach-common.c
> @@ -186,7 +186,7 @@ static int acp_card_rt5682_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->tdm_mode)
> fmt = SND_SOC_DAIFMT_DSP_A;
> @@ -330,7 +330,7 @@ static int acp_card_rt5682s_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->tdm_mode)
> fmt = SND_SOC_DAIFMT_DSP_A;
> @@ -475,7 +475,7 @@ static int acp_card_rt1019_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->amp_codec_id != RT1019)
> return -EINVAL;
> @@ -616,7 +616,7 @@ static int acp_card_maxim_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->tdm_mode)
> fmt = SND_SOC_DAIFMT_DSP_A;
--
Péter
next prev parent reply other threads:[~2023-01-30 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 10:01 Venkata Prasad Potturu
2023-01-30 13:28 ` Péter Ujfalusi [this message]
2023-01-30 21:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c25623-8689-759a-026e-b49190bc19cf@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=AjitKumar.Pandey@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vsujithkumar.Reddy@amd.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ssabakar@amd.com \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®