From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbdGJMZn (ORCPT ); Mon, 10 Jul 2017 08:25:43 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:30031 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbdGJMZk (ORCPT ); Mon, 10 Jul 2017 08:25:40 -0400 X-AuditID: cbfec7f4-f79806d000001279-8c-59637232ee81 Subject: Re: [PATCH] s5k5baf: remove unnecessary static in s5k5baf_get_selection() To: "Gustavo A. R. Silva" , Kyungmin Park , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki From: Andrzej Hajda Message-id: <81c29fdb-77ad-37bb-6353-0fee2d782189@samsung.com> Date: Mon, 10 Jul 2017 14:25:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: <20170705180729.GA10314@embeddedgus> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsWy7djPc7pGRcmRBh9Wi1qsXLKfzeJs0xt2 i8u75rBZ9GzYymqxbNMfJovDb9pZHdg81h1U9di0qpPNo2/LKkaPz5vkAliiuGxSUnMyy1KL 9O0SuDLOf7jPUvCVr6L/MUcD42ruLkZODgkBE4mTV+6zQNhiEhfurWfrYuTiEBJYyijx4MU3 ZgjnM6PElRnzWGE6nr6cwQRiCwksY5SYNb8IougZo8TrlnnMIAlhgRCJ301TGEESIgI9jBKT b01mB0kwC+RIdGzezAZiswloSvzdfBPM5hWwk5h06RfQBg4OFgFViV3PJUDCogIREtu+z4Aq EZT4Mfke2KmcAoYSjf/uQ43UlHjxZRILhC0vsXnNW2YIW1yiufUmC8gNEgKr2CVmvVzGDjJf QkBWYtMBZgjTRWLFBE+Iv4QlXh3fwg5hy0h0dhxkgmjtZpT41H+CHcKZwijx78MMZogqa4nD xy+yQizjk5i0bTrUUF6JjjYhiBIPidkrG5ggwo4Sd/YVQ8KqhVHiy8t2pgmMCrOQvDYLyTuz kLwzC8k7CxhZVjGKpJYW56anFpvoFSfmFpfmpesl5+duYgSmmdP/jn/Zwbj4mNUhRgEORiUe Xo9JSZFCrIllxZW5hxglOJiVRHhvpCRHCvGmJFZWpRblxxeV5qQWH2KU5mBREuflOnUtQkgg PbEkNTs1tSC1CCbLxMEp1cAY6LxzV+mJmHp3zf8HerVufZc5Fy7I/FBf/YbKI9GDVat5G0Xf aNzvFz32oY4tKOCqz+22fc058Ymzj3D1dGRlJ4nsLX5w0W6vxoLM3bvuL1piHSmstEkx6o74 vVapf8HvNpe08lyNe+T305OJkeNAw/P5v63kGrc+mdy5xqy4sz/xL3OG2UIlluKMREMt5qLi RABzRxnzLwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t/xa7qGRcmRBgufGVmsXLKfzeJs0xt2 i8u75rBZ9GzYymqxbNMfJovDb9pZHdg81h1U9di0qpPNo2/LKkaPz5vkAlii3GwyUhNTUosU UvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X4JZx/sN9 loKvfBX9jzkaGFdzdzFyckgImEg8fTmDCcIWk7hwbz1bFyMXh5DAEkaJD+eesEM4zxglrt+4 xg5SJSwQIvG7aQojSEJEoI9Rou3gL2aQBLNAjkRnw10miI42RomDB5eAdbAJaEr83XyTDcTm FbCTmHTpF2sXIwcHi4CqxK7nEiBhUYEIib63l9khSgQlfky+xwJicwoYSjT+u88OUs4soC4x ZUouxCp5ic1r3kKtFZdobr3JMoFRcBaS7lkIHbOQdMxC0rGAkWUVo0hqaXFuem6xoV5xYm5x aV66XnJ+7iZGYMxtO/Zz8w7GSxuDDzEKcDAq8fB6TEqKFGJNLCuuzD3EKMHBrCTCeyMlOVKI NyWxsiq1KD++qDQntfgQoynQZxOZpUST84HpIK8k3tDE0NzS0MjYwsLcyEhJnLfkw5VwIYH0 xJLU7NTUgtQimD4mDk6pBsa2tZXF/x2fTHn+rNrj9xN5gQqbZzsFF8zRr+k5ubK8ZG29wPbM 8DUXLr2P/3ZH1ebrr11HygW6iyTs8xm5PxrfXstxdavCk+UlcYk/D7qKLE1Y5f1e+ovUtu5D +2c5x57WWKp580pgHLf3czmzlwcqlnr6CZdvP9xhX2xf6vTdSUjipOs1Lk0lluKMREMt5qLi RAAf/8bXzwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170710122521eucas1p1ed6ca47d5bc4c0ff4cd751ad8627ba3c X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170705180734epcas5p3b658b32b6b0f5f0c77b7f068fb020d77 X-RootMTR: 20170705180734epcas5p3b658b32b6b0f5f0c77b7f068fb020d77 References: <20170705180729.GA10314@embeddedgus> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.07.2017 20:07, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable rtype. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > > This issue was detected using Coccinelle and the following semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > In the following log you can see the difference in the code size. Also, > there is a significant difference in the bss segment. This log is the > output of the size command, before and after the code change: > > before: > text data bss dec hex filename > 27765 5656 320 33741 83cd drivers/media/i2c/s5k5baf.o > > after: > text data bss dec hex filename > 27733 5600 256 33589 8335 drivers/media/i2c/s5k5baf.o > > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/media/i2c/s5k5baf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c > index 962051b..f01722d 100644 > --- a/drivers/media/i2c/s5k5baf.c > +++ b/drivers/media/i2c/s5k5baf.c > @@ -1374,7 +1374,7 @@ static int s5k5baf_get_selection(struct v4l2_subdev *sd, > struct v4l2_subdev_pad_config *cfg, > struct v4l2_subdev_selection *sel) > { > - static enum selection_rect rtype; > + enum selection_rect rtype; > struct s5k5baf *state = to_s5k5baf(sd); > > rtype = s5k5baf_get_sel_rect(sel->pad, sel->target);