From: Pradyumn Rahar <pradyumn.rahar@oracle.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@oracle.com>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"leon@kernel.org" <leon@kernel.org>,
"tariqt@nvidia.com" <tariqt@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"shayd@nvidia.com" <shayd@nvidia.com>,
"elic@nvidia.com" <elic@nvidia.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anand Khoje <anand.a.khoje@oracle.com>,
Manjunath Patil <manjunath.b.patil@oracle.com>,
Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
Rajesh Sivaramasubramaniom
<rajesh.sivaramasubramaniom@oracle.com>,
Rohit Sajan Kumar <rohit.sajan.kumar@oracle.com>,
Moshe Shemesh <moshe@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Qing Huang <qing.huang@oracle.com>
Subject: Re: [PATCH net 1/1] net/mlx5: Clean up only new IRQ glue on request_irq() failure
Date: Fri, 12 Sep 2025 09:26:28 +0530 [thread overview]
Message-ID: <81c62cf9-8583-46ec-b6d7-48a8c9c92fcb@oracle.com> (raw)
In-Reply-To: <9022a20f-47a7-47f2-9d87-b242cf75b55a@intel.com>
On 02-07-2025 23:28, Jacob Keller wrote:
> On 6/26/2025 11:50 PM, Mohith Kumar Thummaluru wrote:
>> The mlx5_irq_alloc() function can inadvertently free the entire rmap
>> and end up in a crash[1] when the other threads tries to access this,
>> when request_irq() fails due to exhausted IRQ vectors. This commit
>> modifies the cleanup to remove only the specific IRQ mapping that was
>> just added.
>>
>> This prevents removal of other valid mappings and ensures precise
>> cleanup of the failed IRQ allocation's associated glue object.
>>
>> Note: This error is observed when both fwctl and rds configs are enabled.
>>
> FWIW, figured i should add it here:
>
> Reviewed-by: Jacob Keller<jacob.e.keller@intel.com>
Hi, this patch has been reviewed but hasn't been applied, could you
please look into it?
next prev parent reply other threads:[~2025-09-12 3:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 6:50 Mohith Kumar Thummaluru
2025-07-02 17:58 ` Jacob Keller
2025-09-12 3:56 ` Pradyumn Rahar [this message]
2025-09-16 5:24 ` Shay Drori
2025-09-16 19:53 ` Tariq Toukan
2025-09-23 6:28 ` [PATCH net v2 " Pradyumn Rahar
2025-09-24 18:14 ` Keller, Jacob E
2025-09-28 5:55 ` Tariq Toukan
2025-10-27 14:29 ` Pradyumn Rahar
2025-11-03 11:37 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c62cf9-8583-46ec-b6d7-48a8c9c92fcb@oracle.com \
--to=pradyumn.rahar@oracle.com \
--cc=anand.a.khoje@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elic@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=manjunath.b.patil@oracle.com \
--cc=mbloch@nvidia.com \
--cc=mohith.k.kumar.thummaluru@oracle.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qing.huang@oracle.com \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=rama.nichanamatlu@oracle.com \
--cc=rohit.sajan.kumar@oracle.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®