From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Noam Camus <noamca@mellanox.com>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Noam Camus <noamc@ezchip.com>
Subject: Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids
Date: Wed, 19 Oct 2016 10:02:35 -0700 [thread overview]
Message-ID: <81c8e00d-2a78-d5ca-e75a-aeafbe3020cf@synopsys.com> (raw)
In-Reply-To: <1476876303-18768-1-git-send-email-noamca@mellanox.com>
On 10/19/2016 04:25 AM, Noam Camus wrote:
> From: Noam Camus <noamc@ezchip.com>
>
> num_possible_cpus() returns how many CPUs may be present on system.
> However we want the highest possible CPU number.
> This may be differ in a sparsed possible CPUs map.
> Such map achived by OF for plat-eznps.
>
> For example if we have:
> possible cpus mask 0,3
>
> Then:
> num_possible_cpus() is equal 2
> while
> nr_cpu_ids is equal 4.
>
> Only for value 4 c_start() will provide correct cpuinfo at procfs.
This is much much better. Applied to for-curr !
Thx,
-Vineet
>
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> ---
> arch/arc/kernel/setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index 64907de..bd2e3a4 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -512,7 +512,7 @@ static void *c_start(struct seq_file *m, loff_t *pos)
> * way to pass it w/o having to kmalloc/free a 2 byte string.
> * Encode cpu-id as 0xFFcccc, which is decoded by show routine.
> */
> - return *pos < num_possible_cpus() ? cpu_to_ptr(*pos) : NULL;
> + return *pos < nr_cpu_ids ? cpu_to_ptr(*pos) : NULL;
> }
>
> static void *c_next(struct seq_file *m, void *v, loff_t *pos)
prev parent reply other threads:[~2016-10-19 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 11:25 Noam Camus
2016-10-19 17:02 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c8e00d-2a78-d5ca-e75a-aeafbe3020cf@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamc@ezchip.com \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome