From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66217220F37 for ; Tue, 6 Jan 2026 02:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767668006; cv=none; b=PgXQ5uGxrpUGQwoGthgK4yVYOgkLLBd7+nZbT+zbRrmU9bURGYzecnY4FZQ4D38ro5nvLrNaPWM8BVNpfB0poAe6griaIycaaD8pzi1ETlTLAXRNEiIHkejXzA9kBbvAxLuKRLdaGAI3uJzcGKTznYp9WBLwPC7mzMqwmHjlTts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767668006; c=relaxed/simple; bh=ExgOVxrL4uRSF5zFvnR2+cfheCUZyO1RgJeJzYXvDe8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G3aBNJnUWZbFkftPh4qH4S65VnsNjmrtsgqcGYIVfI3SfLKEslKELXf7IArenk2ZVghDUNttbq8Qj/wchsGjbteFlXrtBMm/U45dpdiG7NXGDQlpyoqAgu22UuwmFlUevDNHTov+pfYq92aHgbPsJVjnFh6S6NR69QbF+VLFlLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o4r/SNOa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H6Q4cHM2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o4r/SNOa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H6Q4cHM2" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6062BVQt2765551 for ; Tue, 6 Jan 2026 02:53:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5sb6ALk+FayNpDrW/SZCWcNggZoJNOZD7/vK9n0ecD8=; b=o4r/SNOaOZ3Sy2LP B9F7NHHdc2iT4yJ05jT/soB+4zSUuBg20a8zaDHRXvmM7b5sw3OZZJQaSadHXMZc KdQb/NA1ZFNMQdDEHpSLbTgQHTANI0vpGaeMel041GUuOWIlCLDzFvqw01/g+oCh GBwzG/3sLesKUyVIvaYVccirRhE6F2XkZIXX2V4nd+7rzgC9+4UZC3TheKdl3ZNu XWLfWnIQ58wuDeTD4ultblleg2GTzXQJuZkJqNHAd+duT9j7bVvGg/GiX95qSg6A GOnm3+unTKYjhR5mRLvPat6GviPz5s+MZi/HGzpHPjg1VDGgy/Xo/EM+QVALZNeh w8tzbw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgscy8398-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 02:53:23 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0891f819aso2100425ad.3 for ; Mon, 05 Jan 2026 18:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767668003; x=1768272803; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5sb6ALk+FayNpDrW/SZCWcNggZoJNOZD7/vK9n0ecD8=; b=H6Q4cHM2qMt9gBh6Pw5q5xvNk3hXPXR64yGtOoDFr4ZkvKhjbc4XgM3Rm5oKSmfO/Z 3z/xI1VJp6AOsbCFVIPAGFPAG4hfEP/JvIqyOG4jAANzp9QKcsbhHE8c9zHEVQCld9Zc mHz2/Fa9TS9Aujhmuusk/YQEON1uCaAtqlERzU7wP/XGHzCTfKj7v1p6x0zEBHA5aIZD r5ydeLStnT0ID7fl6JFxcMfSyfbFYN96BHi6PmGFer3JcTE9Ri516Hy2o4+T9BoohneZ wlheIeP7nceA2ZgI+E/NDmXObJ13JaVTF+ECUVRjPbhHJLOIqiE4NAV/8PrjIfwkcgqE +C4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767668003; x=1768272803; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5sb6ALk+FayNpDrW/SZCWcNggZoJNOZD7/vK9n0ecD8=; b=I/UEhVa1wufjzdJJrCYC0gjRUDIwsQep73zK4DcxNhYdWgZLII3wX3JgKJMHmeofyR a72Z5ppR37oA/zRRHbJ40weWcYLzzIxYnQjqyNeEDofv6MeOjZMK3f4QoWxzlBSb4Ajx QCaoV36QfFOSUnhMdZY6O3egbjnsv2RxYq79pxjdM+Yih+tUjSqZWprg3XxvmmWtKxC8 ySy3pctiuOdpYrDBjk3i2Gvk8KpzYTvQ3A8bIehItMWmg5V0F2yf9JrzcbnxPJWqZ/Xj fyM8g+6qieGl2V53oXvgc8n8dT7qKwMYF+o+Fv4ccRexmUFKCP9mWWvU/TG8gSDJXzTI DhxA== X-Forwarded-Encrypted: i=1; AJvYcCX/HkmIIx9WLe6enklpp0AGOqFdBoTY4UwPySRu1rrW1C7U/+9rcT+oGjLSKm8v3jejzeZq5QSsO6UGTtA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9xN6QIdj87DsMxFkUnYdHQ/pUIz0/o3faigiP8qECGL6BK1dN vgNUv5dlyNuWb+AjtVtb1pNxq3bWxXeqS2th6CFijqUtLGgZ5A9vX/UDZrw+l2hJQ0yby+6GlgW SeM8vsiZtOBtrO7QRVLjPAnsyW8gEeysU6gyeYBc2JbV6Xy+zfWmN6GOY0nbXwoIJTgg= X-Gm-Gg: AY/fxX5ea5/AQmjmAgfQoKUnwPrUpCohfvFEyWHPdkFEBoHfcjIFHgqxv72eykQVPvu HcuQ0D7e/7kOW7vcwIMO5EUQ96GPyfTetuuykhZUiX8WVsZp0MZRCmZOX6nZBC5A0o1ay9b7uEb NIZxUTOTVdRt/e/4K5a6YoQnXTdojfx5Hs+ar4sPg6k22kHbBxC6aKwnMRASI5QL0hXMEEIgJI2 9bvcJICJceyqT4SPgpqB/a4AkQ6x1ioxxeqPDjXn4d9gYKdyAedkp3dUIqIZFWgK4OQxXpdnnV4 k3L5QKHFJ9Lnv9eHl2xMjxC4nQIgY3Xeu9Pc0RMJemkQT3JDN8hx8cBmZHKIvCU4qEQVa2A0uO3 9iko0wV/EFOsT/x1y3hsR08FWqtqT6PJvcr7h87En3XjqNmq8fHr3egGWdO7y1+XbYOuQR8Jthz 4= X-Received: by 2002:a17:903:38c3:b0:2a1:3cd9:a73c with SMTP id d9443c01a7336-2a3e2e07568mr11427275ad.7.1767668002877; Mon, 05 Jan 2026 18:53:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2kfXlCUI0BD9z3n18+iUsP0BgUQhNCyDRb3Uyc9G601hcb9aSHxBve2YTgccA0eybGGCr5g== X-Received: by 2002:a17:903:38c3:b0:2a1:3cd9:a73c with SMTP id d9443c01a7336-2a3e2e07568mr11426965ad.7.1767668002308; Mon, 05 Jan 2026 18:53:22 -0800 (PST) Received: from [10.133.33.40] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cca06b16fsm725333a12.31.2026.01.05.18.53.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 18:53:21 -0800 (PST) Message-ID: <81cae5ea-8791-4170-a93e-08c016d74e10@oss.qualcomm.com> Date: Tue, 6 Jan 2026 10:53:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: Add TSENS and QUPv3 serial engines To: Bjorn Andersson Cc: Konrad Dybcio , Jingyi Wang , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manaf Meethalavalappu Pallikunhi , Jyothi Kumar Seerapu References: <20251225-knp-dts-misc-v2-0-a8a8a31fd528@oss.qualcomm.com> <20251225-knp-dts-misc-v2-2-a8a8a31fd528@oss.qualcomm.com> <175e9c72-bde2-4351-a429-7d88d255100c@oss.qualcomm.com> From: "Aiqun(Maria) Yu" Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: fb-d9p9jcIJecdND3ThtkNn1vBBVcvVD X-Authority-Analysis: v=2.4 cv=fOw0HJae c=1 sm=1 tr=0 ts=695c7923 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ECFfsz5tPb39LHsnSlcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: fb-d9p9jcIJecdND3ThtkNn1vBBVcvVD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDAyMyBTYWx0ZWRfX1BQmr1JeS6+L Girjsjjn9lK4jIi9jI1hfj3/2saEBQmz+ouqmtUCGvnY60TgDycmbPkJWlXHrEWxNsjvgURU5z7 Ic/HeD1os7/cv392OLN5FHLzq35LTMCnBd4uIHmvlgSi6/ieZrS/CSAznPogxKRpSrZwlvHOfEf jbMxhcrgFAIqZ/JD4PDeVPJu0iGUFAsFpEDpjZrf6Ni78Pv1lDMz4xn8XHEpia7fAlN2QMo2k+p 65SFCohK2BpySIcim31xpBUlMKK2TCpD+Ijbb+6EAG1RoWAjeJ5pd0zorvvj5DrIxIb6xdRVkTh hmdts3aZnVGw8Ax1yLY8dU7sQ4WP2dg5c3BgdpT4kIHFAuHjaTYZj9rl4fIddIRGplkt8Al+Bii i1xqKoH2KmbfVWLN68NkenykqZPq44h1uUxVnDOfZ18g6WlxJoSNvdxSksfRGzCr3cF6wFfEFAG PfH99EJJsVBICzu5ZbA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_02,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060023 On 1/5/2026 11:22 PM, Bjorn Andersson wrote: > On Mon, Jan 05, 2026 at 04:24:19PM +0800, Aiqun(Maria) Yu wrote: >> On 12/29/2025 9:12 PM, Konrad Dybcio wrote: >>> On 12/26/25 4:06 AM, Jingyi Wang wrote: >>>> Add new features on the Kaanapali Platform including: >>>> >>>> - Temperature Sensor (TSENS) and thermal zones >>>> - QUPv3 serial engine protocols with 5 I2C hubs and 24 QUP serial engines >>>> across 4 QUP wrappers, each with support of GPI DMA engines. >>>> >>>> Co-developed-by: Manaf Meethalavalappu Pallikunhi >>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>>> Co-developed-by: Jyothi Kumar Seerapu >>>> Signed-off-by: Jyothi Kumar Seerapu >>>> Signed-off-by: Jingyi Wang >>>> --- >>> >>> Since the base DT is now merged, all subsequent patches are >>> supposed to be patch-sized, i.e. usually scoped for one feature that >>> makes sense. This one happens to be an arbitrary concatenation of two >>> separate ones. Were they separate, the original authors would benefit >>> from the full attribution and they would be easier for us to review >> >> Hi Konrad, >> >> Are you suggesting to split this patch into 3 function independent >> patches here? >> > > As far as I can see, you already have 3 independent patches here > (stuffed in 2 patches) - they don't overlap, they don't depend on each > other. So, yes this would be easier to handle as separate patches. Those patches is still modify the same file here. And we intend to work as a team instead of individual developer to ease the maintainers' job. Here is the 2 options, which one will you prefer?: 1. Have the Tsense and QUP patches split into 2 patches, while still in this same series. 2. Have the Tsense a separate patch, based on latest merged kaanapali.dtsi. And have QUP patch as a separate patch, also based on latest merged kaanapali.dtsi. The options will be guide on later new functionality added for this device tree as well. Only single device tree series is suggested, or tech team suggested to upload their own device tree patches. By the way, coresight patch is already reviewed-by. We referenced here only add tags. And clearly inform you that the dependency is all cleared. So you can apply it. Also, the other patch can be based on this latest change, that you can apply without any conflict at all. > > I would still like to see dependent patches be gathered and sent > together in a patch series. > > For example smp2p + remoteproc + glink are owned by different teams, but > there's no benefit to merging only smp2p, or only smp2p + remoteproc. So > seeing all three (or more) parts in one series would be preferred (one > patch would also be accepted). > > > > Regardless of who sends these patches or how this is done going forward, > this patch 2/2 is two separate, independent patches. Or you need to > describe why they belong together - what is the connection between tsens > and QUP? (I presume none) > > Thanks, > Bjorn > >> The current dt series is to ease the maintainers' effort to have an >> organized patch in one series in below manner: >> 1. And the series of the dt change will only have all dependency cleared >> functionality in this series. >> 2. dt maintainer won't have any conflict when apply. >> 3. we will suggest developers can do it's own upload when basic >> dependencies like mm-clock and pmic dependencies are all applied. >> >> Are you suggesting splitting this patch into three independent >> functional patches here? >> The current DT series is designed to simplify maintainers’ efforts by >> keeping the patches organized within a single series, structured as follows: >> >> 1. This DT series will include only functionality where all dependencies >> have been reviewed-by at least. >> 2. DT maintainers will not encounter conflicts when applying these patches. >> 3. We will recommend that developers upload their own patches once the >> basic dependencies—such as MM-clock and PMIC—have been applied. >> >> This reflects our discussion with Bjorn and serves as a lesson learned: >> even with a Reviewed-by tag, patch application can be significantly >> delayed when the DT series involves a highly complex dependency chain. >> >>> >>> Konrad >> >> -- >> Thx and BRs, >> Aiqun(Maria) Yu -- Thx and BRs, Aiqun(Maria) Yu