From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9561C84BB for ; Wed, 3 Dec 2025 13:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764767991; cv=none; b=hIIAQ3NufF+H82nvLcSBy/4jMd71KXyuE3jzijq0Oqk8RFLDSrw+q9wvaMI7QWPiJs27nJEAGGls/xtkRGSA62+JPxn1z2M4NsFDwD+rEiDhGJkw6QWSOKUA5p9n6xZGczaM6U+/fgcunB4v/t8z9XJTsRs2i+n9DTMjCYReFy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764767991; c=relaxed/simple; bh=naHq+RAayyZiiiUSiCvkZ14vejsvoMg1vTS1rWitwCY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=snUocFX86XjnkzI+EUvlekLMaFfs+6Re2yoS80VRvv2i+usgvk32ALMOAFUyRB9m07rBAOgbMuFm3M1szsL6masP7TZBpwEeodI1BdSupXomRju+BCufgTO55dp+Nn2qpiju9zLb011qHXO/zRSBHjDTBUUHjO8c3+hLQejO6hI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=N0eIPvlU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N0eIPvlU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764767989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZjp3KH4oYjoP09YFcoEfJL55iESyRosmuIgMEErB2I=; b=N0eIPvlUq17Wpm+RkN/ScWJEGofKyBRaJBkZllokGJWQDmgwAouqdSbxyNc2J5GQ8jE5mK o/rWuYksCxdfb1fL+wc9Dz48+GG4Q9VcS16+C709tCggjcL7+LBuTxzcOlrw3fj/PBwj/i FHvECZ8W8oaKCkQUX5c3xWkewFMnYgM= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-URQPGLIvPQ-on_ndz-uteQ-1; Wed, 03 Dec 2025 08:19:47 -0500 X-MC-Unique: URQPGLIvPQ-on_ndz-uteQ-1 X-Mimecast-MFC-AGG-ID: URQPGLIvPQ-on_ndz-uteQ_1764767987 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88234e4a694so225633766d6.3 for ; Wed, 03 Dec 2025 05:19:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764767987; x=1765372787; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KZjp3KH4oYjoP09YFcoEfJL55iESyRosmuIgMEErB2I=; b=GRNayJbtnaMwAeFZiOY4E3uyH4acSnyIjoGWpO8+xh3i07m2qf6L6L2Tb0uFimWizy 3ocElnD4BAlq3TZP3YO6r1eNoO0mWQYu5lFKc1sh7dPGjhrP1y4HgnLaf+NveNGH8pnp P17T15pUir3WHVWd3FwLDPUV/jtRATEzy6x++1Uvd8L5We2lsT3IvSZdvykvmXoYSUBS H0HeOG6t8Z3R1vGdY7Xh+sLZBBq8nrdu+wrvxh9yNY1M9lKtETg2o+2IdFBONweT3zBy 9p4kEDp2pEKDSxRrCEHDMjignKHxzwXosTv2HvPHcT/JLK+Evf0b0RUFgdLf2kLc4Czn Lv+g== X-Forwarded-Encrypted: i=1; AJvYcCWXFfEN67IN91z/+0kMJ3rF7G/XlGpiWczuhp2XSil/e4XswQ66oZTEdcpmKkAfwncfQFphWCZgrzbWHc0=@vger.kernel.org X-Gm-Message-State: AOJu0YyMjtBDmp3UAyt+8wLq+KEUthy8NKrQ5aAUiyoxcPVxTpc3DNRM gVe4u5KkqfwV46Wy0HwV8FvVxq/vvo7K86KqfnjWSbM/Ca1ZU+U9171oKM85zkmTAVaSQxZA6pc bXceGPUMC/bRmLnMLOz+o3pBa26UqzS8fTcMioHOrP0ZAtD3/upkdIS57IgSk8xSEhw== X-Gm-Gg: ASbGnct/zIFuuzmNG+SvDMgu3VXgw58PM6cWUQrfuzDPFA9tSY8LJ/SMqLRaQYgQhqn qaFKzqo2NX3SliUIRllzOBk/2wBN1TrXqu46dD0D676yXEwa3A6doF21SVcjWP6PimYpl8OgSE8 DgYbpoPsBY/liikdgwTIxmfZAhfdpvBnHbZ+H+DN34zGyBhnIRhnQjgDrsteorIbUP3Df99MM9v GzMO3R0waqpAL/E5MS6XNf4oOQITqwSfWpEt6pWhUnWYfv3W9lAD0OjJKBOJpACaUQN+b1TMLnZ Hl/Wz39aQ6soTy2olwbBu9PevUrgK3o5BQfg9rXzqAtXlAjIlkZ4j6MlW9ivhTFKCMsuXpBOZEr QbAQkZSgo91o= X-Received: by 2002:a05:6214:1cc7:b0:880:55e4:dde with SMTP id 6a1803df08f44-888195a2da7mr31326816d6.63.1764767987379; Wed, 03 Dec 2025 05:19:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKpNns4VOQafFjiG5hX4ruS+Ccvq4UMLfIJlDnhWMvAf/b8wqmyNsYkTvCIREynB7oBmmreA== X-Received: by 2002:a05:6214:1cc7:b0:880:55e4:dde with SMTP id 6a1803df08f44-888195a2da7mr31326296d6.63.1764767986938; Wed, 03 Dec 2025 05:19:46 -0800 (PST) Received: from [192.168.2.110] ([76.65.77.217]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88652b91ba3sm128339296d6.53.2025.12.03.05.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 05:19:46 -0800 (PST) Message-ID: <81d3d168-fc0a-4519-ad7f-c6ab71294792@redhat.com> Date: Wed, 3 Dec 2025 08:19:35 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 04/10] drivers: i915 selftest: use pgtable_has_pmd_leaves() To: "David Hildenbrand (Red Hat)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <297c6fa3dfc50c28c05c0974c86a205984d752ed.1762464515.git.luizcap@redhat.com> <8c745e54-1cb1-44d4-abc3-00e6511cf67c@kernel.org> <21386400-9a67-4fcf-b686-1e7c9678d123@redhat.com> <2149802c-b7cd-430c-8af0-99d26b0b7330@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <2149802c-b7cd-430c-8af0-99d26b0b7330@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-12-02 05:51, David Hildenbrand (Red Hat) wrote: > On 11/17/25 19:55, Luiz Capitulino wrote: >> On 2025-11-17 12:30, David Hildenbrand (Red Hat) wrote: >>> On 06.11.25 22:28, Luiz Capitulino wrote: >>>> igt_can_allocate_thp() uses has_transparente_hugepage() to check if >>>> PMD-sized pages are supported, use pgtable_has_pmd_leaves() instead. >>>> >>>> Signed-off-by: Luiz Capitulino >>>> --- >>>>    drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- >>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c >>>> index bd08605a1611..c76aafa36d2b 100644 >>>> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c >>>> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c >>>> @@ -1316,7 +1316,7 @@ typedef struct drm_i915_gem_object * >>>>    static inline bool igt_can_allocate_thp(struct drm_i915_private *i915) >>>>    { >>>> -    return i915->mm.gemfs && has_transparent_hugepage(); >>>> +    return i915->mm.gemfs && pgtable_has_pmd_leaves(); >>> >>> On second thought, is it problematic that we might be losing the CONFIG_TRANSPARENT_HUGEPAGE check? Should we check for that separately? >> >> That's a good point. >> >> In this RFC, pgtable_has_pmd_leaves() should be functionally equivalent >> to has_transparent_hugepage() so I think we're good. That beind said, I >> also think that we should disentangle pgtable_has_pmd_leaves() from THP >> now or in the future. When we do this the breakage you're spotting will >> happen. >> >> What about adding thp_has_pmd_support() which does: >> >>     return IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && pgtable_has_pmd_leaves(); >> >> Then I can convert all the cases you spotted to thp_has_pmd_support(). > > I hope we can avoid such a wrapper for the time being. Maybe we can just keep pgtable_has_pmd_leaves() glued to CONFIG_TRANSPARENT_HUGEPAGE for now, and leave untangling that for the next cleanup? OK, I can do that in the v1 posting.