From: Lukasz Luba <lukasz.luba@arm.com>
To: vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
peterz@infradead.org, rjw@rjwysocki.net, viresh.kumar@linaro.org,
qperret@google.com, dietmar.eggemann@arm.com,
vincent.donnefort@arm.com, Beata.Michalska@arm.com,
mingo@redhat.com, juri.lelli@redhat.com, rostedt@goodmis.org,
segall@google.com, mgorman@suse.de, bristot@redhat.com,
thara.gopinath@linaro.org, amit.kachhap@gmail.com,
amitk@kernel.org, rui.zhang@intel.com, daniel.lezcano@linaro.org
Subject: Re: [PATCH v3 2/3] sched/fair: Take thermal pressure into account while estimating energy
Date: Mon, 14 Jun 2021 16:29:20 +0100 [thread overview]
Message-ID: <81d7bd73-a61a-5501-f8ec-77e195355013@arm.com> (raw)
In-Reply-To: <20210610150324.22919-3-lukasz.luba@arm.com>
Hi Vincent,
Gentle ping. Could you have a look at this implementation, please?
On 6/10/21 4:03 PM, Lukasz Luba wrote:
[snip]
> @@ -6527,8 +6527,12 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> struct cpumask *pd_mask = perf_domain_span(pd);
> unsigned long cpu_cap = arch_scale_cpu_capacity(cpumask_first(pd_mask));
> unsigned long max_util = 0, sum_util = 0;
> + unsigned long _cpu_cap, thermal_pressure;
> int cpu;
>
> + thermal_pressure = arch_scale_thermal_pressure(cpumask_first(pd_mask));
> + _cpu_cap = cpu_cap - thermal_pressure;
I've done the implementation according to your suggestion. That should
provide the consistent usage.
Regards,
Lukasz
next prev parent reply other threads:[~2021-06-14 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 15:03 [PATCH v3 0/3] Add allowed CPU capacity knowledge to EAS Lukasz Luba
2021-06-10 15:03 ` [PATCH v3 1/3] thermal: cpufreq_cooling: Update also offline CPUs per-cpu thermal_pressure Lukasz Luba
2021-06-14 10:12 ` Viresh Kumar
2021-06-14 10:21 ` Lukasz Luba
2021-06-10 15:03 ` [PATCH v3 2/3] sched/fair: Take thermal pressure into account while estimating energy Lukasz Luba
2021-06-14 15:29 ` Lukasz Luba [this message]
2021-06-14 15:48 ` Vincent Guittot
2021-06-14 16:03 ` Vincent Guittot
2021-06-14 18:22 ` Lukasz Luba
2021-06-10 15:03 ` [PATCH v3 3/3] sched/cpufreq: Consider reduced CPU capacity in energy calculation Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d7bd73-a61a-5501-f8ec-77e195355013@arm.com \
--to=lukasz.luba@arm.com \
--cc=Beata.Michalska@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=bristot@redhat.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=segall@google.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®