From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753349AbdKHVTM (ORCPT ); Wed, 8 Nov 2017 16:19:12 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:30994 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153AbdKHVTJ (ORCPT ); Wed, 8 Nov 2017 16:19:09 -0500 Subject: Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check To: Juergen Gross , Colin King , xen-devel@lists.xenproject.org References: <20171103084202.27790-1-colin.king@canonical.com> <2116793f-cd52-a99f-772e-5dcb768ad411@suse.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <81dba278-f38e-3043-c1f7-2a0f00ae07d7@oracle.com> Date: Wed, 8 Nov 2017 16:20:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2116793f-cd52-a99f-772e-5dcb768ad411@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2017 05:01 AM, Juergen Gross wrote: > On 03/11/17 09:42, Colin King wrote: >> From: Colin Ian King >> >> The check on bedata->ref is never true because ref is an unsigned >> integer. Fix this by assigning signed int ret to the return of the >> call to gnttab_claim_grant_reference so the -ve return can be checked. >> >> Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0") >> >> Fixes: 219681909913 ("xen/pvcalls: connect to the backend") >> Signed-off-by: Colin Ian King > Reviewed-by: Juergen Gross Applied to for-linus-4.15. -boris