From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E46D3546DF for ; Mon, 22 Jun 2026 11:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782126210; cv=none; b=COH61xYVXzYFeEcTcqIVbu1hIhVshLmOYGR93BQHC0Go1pAh7efOTW89RHWhezyfW9x15hM0fzL3eS1rpMgOwYXzcUrd1ThU1KkBxHl3daRQdvEnC9cUE3Nu8ktn8XOl5m9GuCo5cIft+CIOvlkcrtw2e7oaWoioeXMyLlWrcaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782126210; c=relaxed/simple; bh=XfMmrMcD83/JMI3GAjwP1FaaGuSlSMHUrvYZiOg7SXs=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=oCrGrmo79fHc+cHqo4nWHuRo/K0j25aNuXDWhIhsZ4gTdEDz8c15DxiGKg5eoxNig4/ykRKEUBv1dU4BU3VXpnR3KRCRnz7V7ZATudS8X1W1hpxKnw9mfCWxJ5sta0ugPvUWLR11SJEKOdxec1u7CkhKD9dO0qJSGSvGLgw+qtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=fUTlqmtl; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=KMeX9f/1; arc=none smtp.client-ip=202.12.124.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="fUTlqmtl"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KMeX9f/1" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 817811D00125; Mon, 22 Jun 2026 07:03:27 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-04.internal (MEProxy); Mon, 22 Jun 2026 07:03:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1782126207; x=1782212607; bh=XfMmrMcD83/JMI3GAjwP1FaaGuSlSMHUrvYZiOg7SXs=; b= fUTlqmtlGNVp5EG9FU7oZlc8FBy3mKUI638q+DQf8Z/GmK1TR9KpN6ry3Z+o6GlT 9d1WqOMjlVR8pNgvAYNO7cOEWvmyQTMJaHg8KeVM8uW1D/1kkmbKqhf512ymWwuU 2N2I2MSM98eXi1A0TbxSndoqVg9dHJKmMKbsSuDfWuFTfg9k43Bv8TrZFuG6s1i0 8wb3FionHrWBXdxWhg8TdlhcUZ2p8FyLmYS0TpFvcibBzAI9Hgmuz9BaOuzwGsXO /wXQuB+cAMmfPCr+6fBHdMe7DYjAuWYvTg7zHCeI8r6lCzjsdr7p9Z5PnoL91S7p fRuox35S7i9uhCE3ahPCYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1782126207; x= 1782212607; bh=XfMmrMcD83/JMI3GAjwP1FaaGuSlSMHUrvYZiOg7SXs=; b=K MeX9f/1Xc57oWfj8X+jFD3JQt8FbI0gW8F8FBn3ON/3jBnSwWR+KldQeq1Ntmxgp dMHTaJf04yy46V+rI8QAmpLaWV1U69yBFig8fnGcgpIZ4AcroPX+B1ztDbKjP177 FlGqgvE1V3NL0Oo86GhD3j5+DStXMX0GQcFt/vnxsA7Flcs+IORs9JSY+mD/sOjL NV/LQvwcCsVw144HBrRDBsb9hiKptWtImLblnh2hqvCZHIF6vpSdWGHUldGdZCzV +ee2TNMp6D85kdd1R7hsoFazzqaa/4hWVkSWzjCTRC81119SVeJ6hx3PaDpJhksb eX0PHjP15zreaDV0pPEgA== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTEv/WKRN3lX6+xfYQQPlSR9Wr1uM0aUgbhtr6O9EiywkuBR6HQG68SJBmfO6ZqSqs /D0wfpsonmRagzA6zmYs/k7E8JlwIkBqXOi6CDvogSMMlhFoYnvFP1323Jqdr6dtFNmZUC waXsuXbUzLvPJeGmRev0g8eCK+5UFEjOx3Ms4H2FXR5M3HO1ejHE8YDYSq2p0Xbh5EbnLB s6+njsJvzrbnfxYB9psBzrJbH/W3PgHOhsKUxSn6fhQvIANEwLRhcyf7j8fwZbBBqKqtZ4 Q6k0cmNWQo6G3OkvzQ2PT4yjkw/yTs+kDZ/WkmIdF/noQ950iiWR7FQZZNxGa+eM1TWCfM v8Qj+kpB0LtH4VmWpNc3ZqjYh1QK3i2k3CcaEP6c4XE3T6GoC0aULqNIQ2oHbUzDPmf36y IhUmbGkVNZPljohaAVSago4PDLuDIZtY/HJfLBeYrUJs3r9BtNpbOu0bMoc4TIX1yBxDbq QVXM/PTxAphDJvc20kayW1bPZWIJliKWFY79zStwqXJTNqdhFsSWhJukORatVNzDUWPv8c qQ8kReiy+HZMp/ug7lzb0T1HCXY7qPITqmevWFZIJXe49PvUjdqsOCTNWhkT54WoJNAGXf XmQ2JiheqG1Q5iQlULr8JqEZX3dX/+TtA/rETzFxP0GgXHy2Dg6Arxoi+oYg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id C610E1820082; Mon, 22 Jun 2026 07:03:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AV2CUs_7_ODB Date: Mon, 22 Jun 2026 13:01:03 +0200 From: "Arnd Bergmann" To: "Wang Yan" , "John Stultz" , "Thomas Gleixner" Cc: "Stephen Boyd" , linux-kernel@vger.kernel.org Message-Id: <81e1fa9a-af45-4e4a-8f94-51eb33aaf4ac@app.fastmail.com> In-Reply-To: <20260622103348.120255-1-wangyan01@kylinos.cn> References: <20260622103348.120255-1-wangyan01@kylinos.cn> Subject: Re: [PATCH] time: Fix off-by-one in compat settimeofday() usec validation Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Jun 22, 2026, at 12:33, Wang Yan wrote: > The compat version of settimeofday() uses '>' instead of '>=' when > validating tv_usec against USEC_PER_SEC, allowing the value 1000000 > to pass the check. After the subsequent conversion to nanoseconds > (tv_nsec *= NSEC_PER_USEC), this results in tv_nsec == NSEC_PER_SEC, > which violates the timespec invariant that tv_nsec must be strictly > less than NSEC_PER_SEC. > > The native settimeofday() was already fixed in commit ce4abda5e126 > ("time: Fix off-by-one in settimeofday() usec validation"), but the > compat counterpart was missed. > > Fix it by using '>=' to reject tv_usec values outside the valid > range [0, USEC_PER_SEC - 1]. > > Fixes: 5e0fb1b57bea ("y2038: time: avoid timespec usage in settimeofday()") > Signed-off-by: Wang Yan Acked-by: Arnd Bergmann probably also Cc: stable@vger.kernel.org