From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1B9C4338F for ; Thu, 29 Jul 2021 18:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3E7C61008 for ; Thu, 29 Jul 2021 18:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbhG2Smv (ORCPT ); Thu, 29 Jul 2021 14:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230527AbhG2Smu (ORCPT ); Thu, 29 Jul 2021 14:42:50 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8C33C061765 for ; Thu, 29 Jul 2021 11:42:46 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id y9so8424432iox.2 for ; Thu, 29 Jul 2021 11:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a2jcrKjKBS+gdl5PCdRBVKhfmtzJBVA/IHxSfmpMEXY=; b=fyxwFxZ5LuI1DPZNzJ8ri2+PsiwAu9rjoLFHe8n51OFhFA9qa/cP+WRLe4VevBtOQh 3NvAsp65Q4og8vEaASAkhTnjrK2NSAkKw6IBZ5eMUMjGZ6gfwGUK/QoLZxAxehKK5ygJ WXnJK2UT2jvW0VIeXtdTfnFn3Rz7euZba+KSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a2jcrKjKBS+gdl5PCdRBVKhfmtzJBVA/IHxSfmpMEXY=; b=diUeomHzJfkCdm1502ypvGWOM43Qkr3XFAbkeq57FrKleELyJ5CDjFYZwg+qS/VfzH AiKO8o28g6nU3nEhZN3M0azym6imWC64fQibkAXDG4hudwEWHssWaJbjtiyvwEVzOvUw 7oeOFLG7JmAF4YkkeaOTr9VRzz0CFbRisCq8yWl+OpE9dMTpz+DtS9pNUFOx3ONT+hju xvmiuGVJ6xdg/GbT8YY77iKhlLH+SSfQ8qOFRHqOASMjbmMcqtTPoIg/MRWAstxLJcjA fKxW8UtjnjiOFC9E33qXyzl9Gr2x8TxPpj7KQmCSDUslduoImjH25AXEdoEHSch4T/T5 GBNA== X-Gm-Message-State: AOAM532gUEU+jGRYY3QX47Wo/JWRSA88CLM6IlazaD66bdHhcW0BISta 8nxbXB9nuUr6yqZqnLaJPHz1xwRyeUsl/A== X-Google-Smtp-Source: ABdhPJyt2mWOI75qeIcEBffn7Ap+3xLN2wsGakY2Lg/XfAtkeHTkM0kbkP3BrxiIdH5/JcC9nNGzLg== X-Received: by 2002:a05:6638:204c:: with SMTP id t12mr5558854jaj.129.1627584165955; Thu, 29 Jul 2021 11:42:45 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id z6sm2303243ilz.54.2021.07.29.11.42.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 11:42:45 -0700 (PDT) Subject: Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup To: Bart Van Assche , Greg KH Cc: Christoph Hellwig , Joel Becker , linux-kernel@vger.kernel.org, Brendan Higgins , David Gow , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Bodo Stroesser , "Martin K . Petersen" , Yanko Kaneti , Shuah Khan References: <20210729044125.7435-1-bvanassche@acm.org> <20210729044125.7435-3-bvanassche@acm.org> <8ab0ea44-760a-61df-0b9a-8b314ca9a0fe@acm.org> <733cb812-8696-45f4-356d-cfe5bd85eb9b@linuxfoundation.org> From: Shuah Khan Message-ID: <81edb935-aabd-bd05-c3d1-260903b3c726@linuxfoundation.org> Date: Thu, 29 Jul 2021 12:42:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/21 11:16 AM, Bart Van Assche wrote: > On 7/29/21 9:55 AM, Shuah Khan wrote: >> On 7/29/21 10:52 AM, Bart Van Assche wrote: >>> On 7/28/21 10:55 PM, Greg KH wrote: >>>> On Wed, Jul 28, 2021 at 09:41:24PM -0700, Bart Van Assche wrote: >>>>> Reviewed-by: Brendan Higgins >>>>> Cc: David Gow >>>>> Cc: Shuah Khan >>>>> Cc: kunit-dev@googlegroups.com >>>>> Cc: linux-kselftest@vger.kernel.org >>>>> Cc: Bodo Stroesser >>>>> Cc: Martin K. Petersen >>>>> Cc: Yanko Kaneti >>>>> Signed-off-by: Bart Van Assche >>>>> --- >>>> >>>> I know I do not take patches without any changelog text.  Maybe other >>>> maintainers are more lax :( >>> >>> Almost every patch from me has an elaborate changelog. For this patch I chose not to add a changelog since I think that the subject is self-explanatory? >> >> I don't take patches without change logs either. I can't say the subject >> tells me what you are doing. >> >> Please add a change log. > > I will add a changelog. But please note that this patch has been sent to Christoph as configfs maintainer. > Sure. This is a kunit patch - hence Kunit maintainers can comment on it. Besides the comment is about missing change log which is rather basic kernel dev 101. Please take a look at Documentation/process/submitting-patches.rst for information on commit logs. thanks, -- Shuah