From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF7D379990 for ; Thu, 29 Jan 2026 10:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769682826; cv=none; b=Zq8AoS1WMtyPCSGBtIpt5vg8PLJlyIlcF01UYQgIUxC3LAoI8u1tWQYU0azYsPwvKtPxrUYrKxwYpX5l5kT7yYwpXNnstHhsT6ZBO307qS6hSrFPOkoDl+4WkGNDpGR3xymAwfBtm3r5yZBoZcdtDGhfvNq4AN2qFiLiq6c3LyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769682826; c=relaxed/simple; bh=RKjzM+AzWEd2xLqDveQmeQFdcy+M78s4wSRN+pTC75o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LVoHDTEEL8HRPnjsWT4h8+y3qenEeBvrbTfVHpUyk86ucBISw2KrB4ByNyr1Dms9mvqC+xbV0f+izl8HvVxsmzid0v3+T1DgeGv6SXisykf8NswEWcB1ge2LOJqkuh5LAvHWc13j2iPZDXeXiPcl/BkLfLbQGbxRdIs1J/DHcNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KiS+XQfl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Js35qjLH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KiS+XQfl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Js35qjLH" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TA5Etw2060027 for ; Thu, 29 Jan 2026 10:33:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XniacV/s3o9H91GWrpTbMKzmS7SyJtuAfhbd5BWpqpY=; b=KiS+XQflezgVQ6GB ta7uC/l56nU9wSgZ1xd0mERxwlyJi3hbc7+QJGgfSietA3fh8Y+YZzUQaQAvQI+h JWQsjGCxuN1dp3RaZx/NQy/7jUpW+55v7p0SKWQ2SO2WIP4PuAGgyI3jZNFHwf7a RzdgmbXEvbkTjK5XBj15EkV+YMSlBt2nZO7NT3zlSrVAsn7yWHmtBz6JJ4mVBe8y X7bsAhFx9x4Tq/aAoB2NV119k98/uoU22Ld2s+Lsa7ASlOigFVH5+EJIw4KvCtT+ meLWbMJc3c6iKyg8CFyFMu0IkLLIIho+5tHjg+2n/BrsAysVuJJrSY+yS5gaKDEU IhtsLQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bypgrk240-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 10:33:43 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f2381ea85so19171375ad.0 for ; Thu, 29 Jan 2026 02:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769682823; x=1770287623; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XniacV/s3o9H91GWrpTbMKzmS7SyJtuAfhbd5BWpqpY=; b=Js35qjLHvt8aLS3/CjYi8nhKmZDbpX/deeWlocTp8ASIv3tPs6AHlDODept9BQlqD6 nBpAwZWqLGPtDwSvxdg29jh/ktUmPFGUtrfHJZbgHMygsI/dyPCofg13RnXqlplvs1bG fKAec4eiI+AxAhtYuTLB/ccF7Z3O9xtykMGRSfRjvh23oeQJJbEJ+l0IfDQtpIU4syFE I5JrrHcL7IbjUR9RX+mDCRAmNqsDAKD5RVGZ3oafXAoP6NPkdaLBQ1SiCEQ6NpSDbI7s CtyiPbV5/0ugD+Bn1u5z1zdTjrd2A9SSnj9Ak20B8dJfwFz2eNJZosA8aqnAOwfcTKdr HAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769682823; x=1770287623; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XniacV/s3o9H91GWrpTbMKzmS7SyJtuAfhbd5BWpqpY=; b=L9lExjXSwY64GPEoDSYnqlgwlqkYbcJaYwiwjL1uB89BIHcvitEroaqUp4RneDoiC1 eu6cPO1g4HNk/FVPcgnD8hBAGHnRcmt7qQ8XYtrj8yQFa345sWq2dy5XWuCSDjo5s3P8 90SWgQ5sJy4oWRaziMGDIOUkNDcmLVnH8BqL7k/wYJ+6hBIAsoA7yxdESkxRcRFsite7 uVWzk1iyRWHIaOV0IisZadv0nBen1TTFIlalZnTbXB4kscADK8mvJOHv0AF52fVmgAnI 1Y/avgbkKSw806Ar7W4AE1EIh1Bs97H5rMO4/QoG5qJUdFjdggHiJIz7YgMag724iPX3 fyfw== X-Forwarded-Encrypted: i=1; AJvYcCUoR7HAgId18eZrHDNnVtlCEOUplK6r5NY5wgnh3pGKT09LKUtN7B6XBmQMiJjfbxgZ9MejDr86pQhsv84=@vger.kernel.org X-Gm-Message-State: AOJu0YysqA3667JqiRj8yQphc48VMEOyNi9HB9IgSGZLbBdnuvaAZHqd kkyxEQXbzRXcWXNCob2CWY/1l/gwartZzLp22D+7OzzbXopZz6ZmPQwpSc6ESWGRiHOZfzsjawO vniPtvFe38zed+Oqd+LcnFSZdrj6KHLF81q/tlN6Sh4iETxVHfOh+xRPEg3b4JkQryp0= X-Gm-Gg: AZuq6aKc0CI4A8Sq2rA0xQhBd68q9dqiLyfzIiD44g4ZNrx2y9pl72oQEZoPHX4EFDG /wNH9n+9bEFnJ+gro3tQ8kbH67q5sBtwDdyDIKxkjKIP198FZcrzHrerLmHW3tJdxPEoATGP4EP txqv0/vWsB3YbUDa+i9WaTbUcdhbHd/NDwZQMWUISDDfpGTmPjyGFECWawnkRUplWIhqaSFJojU 1xC4pWHr7+KkrTLLMQt2UlkhnMhlnHIpjbj80hkKHIIrDNHrEsiDzYRSp+n5rvd7w3ulf+N25sd hUwgvLAM3jx/GgfPPsQLzIRRyDTXqBkV3BD65B9WwYURdL38Fmqp4/8ZkeJR/02ClK1ZV9uWxdH ErEw1K5OJLyGNSWJ0DRjAsrSMmwMdwHA3ME7CFg7bUEXfnVg7 X-Received: by 2002:a17:902:cccb:b0:2a0:9ca7:7405 with SMTP id d9443c01a7336-2a870dc9634mr87914155ad.36.1769682823234; Thu, 29 Jan 2026 02:33:43 -0800 (PST) X-Received: by 2002:a17:902:cccb:b0:2a0:9ca7:7405 with SMTP id d9443c01a7336-2a870dc9634mr87913935ad.36.1769682822728; Thu, 29 Jan 2026 02:33:42 -0800 (PST) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b4c3d2bsm48006435ad.53.2026.01.29.02.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 02:33:42 -0800 (PST) Message-ID: <81f0ee3c-a7e3-4730-a396-9599ddd45f53@oss.qualcomm.com> Date: Thu, 29 Jan 2026 16:03:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl To: Rob Herring Cc: Bjorn Andersson , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127105511.3917491-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260127141740.GA1574044-robh@kernel.org> <9f5436df-fef7-4921-85b3-b6fe4e942779@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=d7T4CBjE c=1 sm=1 tr=0 ts=697b3788 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=iS5eDfI7LrtSjKTbtTEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: ZXCjRf-hjfo3yAkTL1P1HonosjNO8c05 X-Proofpoint-ORIG-GUID: ZXCjRf-hjfo3yAkTL1P1HonosjNO8c05 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA2OSBTYWx0ZWRfX8op+HwcUWr1d ZK+lDbpVRK8CjvdnHydA41MNh+17yHELJofbvdIHEuVahvVENY8yndSLl20+EHouGUL3OzHy6en z7k9LT2bR5+KBKgmThu3eHBchGLcim8RRd/wWCggGMFyI/A30reMe5dqAZJVdQ3bYA3sHb2bIRU UL+pZuHMy5S43XcDOLlGpDlP6gL3xWvsOM8QxtS7AbsIdVDgTKQG8Ce4sw+gbFfHsVYM4tfeq/F aolw9OoF16rQUWaqlSo49Yq06M2bJ9uJpNulfCPiELQV1CxAgmHO2aCqQv8EJUnZfcy5IhQxr0l I2lz4MrhvWQHLgnWqaZn3PPlXCj8i4wkBXrGS9aayxFRdO5HBACVWk6XHkZyTd4VYjJpgETaP8u LNY1CwFSvC8JE0ybBAewd7h7vEDDph+xs/svfVyQrfmGexGzyar64nZQqTP9kZ2dKtwrbAxmaKZ EDVRNnSdIUlNR6v1znQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 spamscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290069 On 1/27/2026 11:57 PM, Rob Herring wrote: > On Tue, Jan 27, 2026 at 12:13 PM Mohammad Rafi Shaik > wrote: >> >> >> >> On 1/27/2026 7:47 PM, Rob Herring wrote: >>> On Tue, Jan 27, 2026 at 04:25:11PM +0530, Mohammad Rafi Shaik wrote: >>>> Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM >>>> pin controller, fully compatible with previous SM8450 generation >>>> (same amount of pins and functions). >>>> >>>> Signed-off-by: Mohammad Rafi Shaik >>>> --- >>>> changes in [v3]: >>>> - Removed the duplicate driver code patch as suggested by Krzysztof. >>>> - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. >>>> - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ >>>> >>>> changes in [v2]: >>>> - Fixed dt-binding errors reported by Krzysztof and Rob. >>>> - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. >>>> - Documented Monaco compatible as suggested by Konrad. >>>> - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ >>>> --- >>>> .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- >>>> 1 file changed, 9 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >>>> index e7565592d..354629c38 100644 >>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >>>> @@ -15,7 +15,15 @@ description: >>>> >>>> properties: >>>> compatible: >>>> - const: qcom,sm8450-lpass-lpi-pinctrl >>>> + oneOf: >>>> + - const: qcom,sm8450-lpass-lpi-pinctrl >>>> + - items: >>>> + - enum: >>>> + - qcom,qcs8300-lpass-lpi-pinctrl >>>> + - qcom,sa8775p-lpass-lpi-pinctrl >>>> + - const: qcom,sm8450-lpass-lpi-pinctrl >>>> + minItems: 1 >>>> + maxItems: 2 >>> >>> No. You are either backwards compatible with sm8450 or you aren't. The >>> h/w is fixed. >>> >> >> ACK, >> >> Agree, >> >> Need backward compatibility with sm8450 for both sa8775p and qcs8300 as >> they must fall back to the sm8450, so initially used enum to pick >> between the sa8775p and qcs8300 compatibles. I see enum isn’t >> appropriate here since fixed h/w. >> >> will use the const instead of enum like below. >> >> properties: >> compatible: >> - const: qcom,sm8450-lpass-lpi-pinctrl >> + oneOf: >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + - items: >> + - const: qcom,sa8775p-lpass-lpi-pinctrl >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + >> + - items: >> + - const: qcom,qcs8300-lpass-lpi-pinctrl >> + - const: qcom,sm8450-lpass-lpi-pinctrl > > Sigh, no. The 2 entries can be combined like you had. Just drop > minItems and maxItems from what you had. > > And test your binding before sending it. > Sure, I’ll take care of it going forward Thanks & Regarding, Rafi. > Rob