From: Rik van Riel <riel@surriel.com>
To: Petr Mladek <pmladek@suse.com>, John Ogness <john.ogness@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Omar Sandoval <osandov@meta.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
kernel-team <kernel-team@meta.com>
Subject: Re: [RFC PATCH] nmi,printk: fix ABBA deadlock between nmi_backtrace and dump_stack_lvl
Date: Wed, 24 Jul 2024 12:55:19 -0400 [thread overview]
Message-ID: <81f7efa849630aed6a4a995825ea911f6d58cbd7.camel@surriel.com> (raw)
In-Reply-To: <ZqD54dcZUAirxTYg@pathway.suse.cz>
On Wed, 2024-07-24 at 14:56 +0200, Petr Mladek wrote:
> On Thu 2024-07-18 16:15:43, John Ogness wrote:
>
> >
> > However, my first suggestion to defer whenever the cpu_sync is held
> > really is the only option because console_unlock() will spin on the
> > uart
> > port lock, and that is also not allowed when holding the cpu_sync.
>
> It would have helped if Rick added backtraces from the crash dumps.
> He just wrote:
>
I would have preferred that, as well.
However, this deadlock prevent us from capturing a good backtrace
of the CPU that was stuck on the lock while in the NMI handler!
We ended up having to dig through the NMI stack of the stuck CPU
by hand, looking for anything that might be a function address,
and guess at what the CPU was doing.
This deadlock not only prevented the CPU printing, but also from
dumping its register state at panic time before the kdump kernel
was kexeced.
--
All Rights Reversed.
next prev parent reply other threads:[~2024-07-24 16:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 3:20 Rik van Riel
2024-07-17 7:16 ` John Ogness
2024-07-17 13:47 ` Rik van Riel
2024-07-18 7:25 ` John Ogness
2024-07-18 13:38 ` Rik van Riel
2024-07-18 14:09 ` John Ogness
2024-07-18 15:23 ` Rik van Riel
2024-07-24 12:56 ` Petr Mladek
2024-07-24 14:45 ` John Ogness
2024-07-24 15:08 ` Petr Mladek
2024-09-13 17:25 ` Rik van Riel
2024-09-16 14:33 ` Petr Mladek
2024-07-24 16:55 ` Rik van Riel [this message]
2024-07-24 12:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81f7efa849630aed6a4a995825ea911f6d58cbd7.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@meta.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®