mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Vaishnav Achath <vaishnav.a@ti.com>, <nm@ti.com>,
	<ssantosh@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <vigneshr@ti.com>, <u-kumar1@ti.com>, <j-choudhary@ti.com>
Subject: Re: [PATCH] soc: ti: k3-socinfo: Add JTAG ID for J722S
Date: Tue, 12 Dec 2023 09:19:07 -0600	[thread overview]
Message-ID: <81f90d13-da10-4a68-a0e7-95212f40b3e8@ti.com> (raw)
In-Reply-To: <20231211132600.25289-1-vaishnav.a@ti.com>

On 12/11/23 7:26 AM, Vaishnav Achath wrote:
> Add JTAG ID info for the J722S SoC family to enable SoC detection.
> 
> More details about this SoC can be found in the TRM:
> 	https://www.ti.com/lit/zip/sprujb3
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---

Simple enough,

Reviewed-by: Andrew Davis <afd@ti.com>

Although I do question our use of the J7x names. All of our parts here
also have a "Sitara AMxx" branding. For instance here we could call
this new device by its "AM67" name, then J784S4 renamed as AM69, etc.
Then we would have a consistent naming (internally we will have to deal
with the part name madness, but why expose that externally if we don't
have to).

Andrew

> 
> Bootlog with changes:
> https://gist.github.com/vaishnavachath/23d859925277df9ccd628190e7c23371
> 
>   drivers/soc/ti/k3-socinfo.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
> index 7517a9c8c8fa..59101bf7cf23 100644
> --- a/drivers/soc/ti/k3-socinfo.c
> +++ b/drivers/soc/ti/k3-socinfo.c
> @@ -42,6 +42,7 @@
>   #define JTAG_ID_PARTNO_J784S4		0xBB80
>   #define JTAG_ID_PARTNO_AM62AX		0xBB8D
>   #define JTAG_ID_PARTNO_AM62PX		0xBB9D
> +#define JTAG_ID_PARTNO_J722S		0xBBA0
>   
>   static const struct k3_soc_id {
>   	unsigned int id;
> @@ -56,6 +57,7 @@ static const struct k3_soc_id {
>   	{ JTAG_ID_PARTNO_J784S4, "J784S4" },
>   	{ JTAG_ID_PARTNO_AM62AX, "AM62AX" },
>   	{ JTAG_ID_PARTNO_AM62PX, "AM62PX" },
> +	{ JTAG_ID_PARTNO_J722S, "J722S" },
>   };
>   
>   static const char * const j721e_rev_string_map[] = {

  reply	other threads:[~2023-12-12 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 13:26 Vaishnav Achath
2023-12-12 15:19 ` Andrew Davis [this message]
2023-12-12 15:42   ` Nishanth Menon
2023-12-12 16:16     ` Andrew Davis
2023-12-13 13:58 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81f90d13-da10-4a68-a0e7-95212f40b3e8@ti.com \
    --to=afd@ti.com \
    --cc=j-choudhary@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®