mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: GOTO Masanori <gotom@sanori.org>
To: linux-kernel@vger.kernel.org, akpm@osdl.org
Cc: gotom@sanori.org
Subject: [PATCH] x86: Fix i386 nmi_watchdog that does not trigger die_nmi
Date: Tue, 07 Mar 2006 11:13:22 +0900	[thread overview]
Message-ID: <81irqrknnh.wl%gotom@sanori.org> (raw)

It fixes i386 nmi_watchdog that does not meet watchdog timeout
condition.  It does not hit die_nmi when it should be triggered,
because the current nmi_watchdog_tick in arch/i386/kernel/nmi.c never
count up alert_counter like this:

	void nmi_watchdog_tick (struct pt_regs * regs) {
	if (last_irq_sums[cpu] == sum) {
		alert_counter[cpu]++;		<- count up alert_counter, but
		if (alert_counter[cpu] == 5*nmi_hz)
			die_nmi(regs, "NMI Watchdog detected LOCKUP");
		alert_counter[cpu] = 0;		<- reset alert_counter

This patch changes it back to the previous and working version.
Tested with 2.6.15.  It's also OK for 2.6.16-rc5.

This was found and originally written by Kohta NAKASHIMA.

-- gotom

Signed-Off-By: GOTO Masanori <gotom@sanori.org>
---

--- linux-2.6.15/arch/i386/kernel/nmi.c.gotom	2006-03-02 17:52:49.021365056 +0900
+++ linux-2.6.15/arch/i386/kernel/nmi.c	2006-03-02 17:53:19.939664760 +0900
@@ -544,7 +544,7 @@ void nmi_watchdog_tick (struct pt_regs *
 			 * die_nmi will return ONLY if NOTIFY_STOP happens..
 			 */
 			die_nmi(regs, "NMI Watchdog detected LOCKUP");
-
+	} else {
 		last_irq_sums[cpu] = sum;
 		alert_counter[cpu] = 0;
 	}

             reply	other threads:[~2006-03-07  2:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-07  2:13 GOTO Masanori [this message]
2006-03-07  3:46 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81irqrknnh.wl%gotom@sanori.org \
    --to=gotom@sanori.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®