From: "Arnd Bergmann" <arnd@arndb.de>
To: "Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Linux-OMAP <linux-omap@vger.kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH 1/2] drm/omap: dsi: Fix excessive stack usage
Date: Fri, 16 Sep 2022 10:23:28 +0200 [thread overview]
Message-ID: <8202c089-e6dd-4027-a838-f08971b155ce@www.fastmail.com> (raw)
In-Reply-To: <20220916082206.167427-1-tomi.valkeinen@ideasonboard.com>
On Fri, Sep 16, 2022, at 10:22 AM, Tomi Valkeinen wrote:
> dsi_dump_dsi_irqs(), a function used for debugfs prints, has a large
> struct in its frame, which can result in:
>
> drivers/gpu/drm/omapdrm/dss/dsi.c:1126:1: warning: the frame size of
> 1060 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> As the performance of the function is of no concern, let's allocate the
> struct with kmalloc instead.
>
> Compile-tested only.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Reported-by: kernel test robot <lkp@intel.com>
Looks good to me,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2022-09-16 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 8:22 Tomi Valkeinen
2022-09-16 8:22 ` [PATCH 2/2] drm/omap: Fix kernel docs Tomi Valkeinen
2022-12-16 18:16 ` Laurent Pinchart
2022-09-16 8:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8202c089-e6dd-4027-a838-f08971b155ce@www.fastmail.com \
--to=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®