mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rao, Nikhil" <nikhirao@amd.com>
To: netdev-bot+sashiko@kernel.org, nikhil.rao@amd.com
Cc: brett.creeley@amd.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, abhijit.gangurde@amd.com, allen.hubbe@amd.com,
	jgg@ziepe.ca, leon@kernel.org, jiri@resnulli.us,
	horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org,
	rdunlap@infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-doc@vger.kernel.org, eric.joyner@amd.com,
	ArunKumar.Prakash@amd.com
Subject: Re: [PATCH net-next v2 2/3] RDMA/ionic: Use the ionic command timeout for the admin queue
Date: Wed, 18 Nov 2026 15:37:57 -0800	[thread overview]
Message-ID: <8208890f-2453-4431-9fce-d326ecbbcbf3@amd.com> (raw)
In-Reply-To: <179431289755.994134.3080122667953359752@kernel.org>

On 11/10/2026 4:14 AM, netdev-bot+sashiko@kernel.org wrote:
> 
> [Severity: Low]
> This fixes a user-visible problem, but the patch has no Fixes: tag.
> The 2 second IONIC_ADMIN_TIMEOUT removed above was added by f3bdbd42702c
> ("RDMA/ionic: Create device queues to support admin operations"), which
> is in released kernels.
> 
> Should this carry a Fixes: tag for that commit?
Agreed. The 2 to 5 second change is sent separately to rdma for-rc:
https://patch.msgid.link/20261118-b4-ionic-rdma-admin-timeout-v1-1-39536999a3e4@amd.com

> [Severity: High]
> Only the watchdog in ionic_admin_dwork() moves to ionic_cmd_timeout()
> here. Can the RDMA LIF still be reset after 2 seconds through the AH
> busy-wait path?
> 

> Should the busy-wait also be bounded by ionic_cmd_timeout(), or should
> its expiry not trigger the LIF reset?

The busy-wait keeps its 2 second bound: it serves non-sleepable
callers such as cm_alloc_msg(), which runs with a spinlock held, so it
cannot spin for the command timeout, which can now be up to 255
seconds. Its expiry still resets the RDMA LIF, as the admin queue
watchdog's does, so non-sleepable AH commands keep the 2 second limit.
Admin commands that sleep until completion, including every verb from
user space, follow the configured timeout.

Nikhil

  reply	other threads:[~2026-11-18 23:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 22:43 [PATCH net-next v2 0/3] ionic: make the device command timeout configurable Nikhil P. Rao
2026-11-05 22:43 ` [PATCH net-next v2 1/3] ionic: make the command timeout per device Nikhil P. Rao
2026-11-05 22:43 ` [PATCH net-next v2 2/3] RDMA/ionic: Use the ionic command timeout for the admin queue Nikhil P. Rao
2026-11-10 12:14   ` netdev-bot+sashiko
2026-11-18 23:37     ` Rao, Nikhil [this message]
2026-11-05 22:43 ` [PATCH net-next v2 3/3] ionic: add devlink param for command timeout Nikhil P. Rao
2026-11-10 12:14   ` netdev-bot+sashiko
2026-11-18 23:56     ` Rao, Nikhil
2026-11-14  0:55 ` [PATCH net-next v2 0/3] ionic: make the device command timeout configurable Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8208890f-2453-4431-9fce-d326ecbbcbf3@amd.com \
    --to=nikhirao@amd.com \
    --cc=ArunKumar.Prakash@amd.com \
    --cc=abhijit.gangurde@amd.com \
    --cc=allen.hubbe@amd.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=brett.creeley@amd.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=eric.joyner@amd.com \
    --cc=horms@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikhil.rao@amd.com \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®