mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Thierry Escande <thierry.escande@linaro.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Replace open-coded msleep()
Date: Fri, 28 Sep 2018 19:20:03 +0200	[thread overview]
Message-ID: <820F0357-DBD1-4278-8488-8C97A4107C19@holtmann.org> (raw)
In-Reply-To: <153815104962.119890.13155451003978822980@swboyd.mtv.corp.google.com>

Hi Stephen,

>> These three lines make up what msleep() already does, i.e. setting the
>> task to uninterruptible, sleeping for so many jiffies, and then
>> schedule() already puts the task state back to TASK_RUNNING when it
>> returns. Make things clearer by just calling msleep() instead.
>> 
>> Cc: Thierry Escande <thierry.escande@linaro.org>
>> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
>> ---
> 
> Marcel, can you pick this patch up?

I would do that, but unfortunately it does apply against bluetooth-next tree.

Regards

Marcel


      reply	other threads:[~2018-09-28 17:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 17:06 Stephen Boyd
2018-06-26 20:49 ` Matthias Kaehlcke
2018-09-28 16:10 ` Stephen Boyd
2018-09-28 17:20   ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=820F0357-DBD1-4278-8488-8C97A4107C19@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swboyd@chromium.org \
    --cc=thierry.escande@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®