mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Joaquin Aramendia <samsagax@gmail.com>
Cc: derekjohn.clark@gmail.com, jdelvare@suse.com,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add tt_toggle attribute on supported boards
Date: Wed, 31 May 2023 09:46:21 -0700	[thread overview]
Message-ID: <820cef00-4768-46ae-c5a5-ea7c0dff71c5@roeck-us.net> (raw)
In-Reply-To: <CABgtM3h8DXs0swGQth=dcE3J_W8k8iejvfFgjVSm9nKbRmxHDQ@mail.gmail.com>

On 5/31/23 05:04, Joaquin Aramendia wrote:
>> This attribute is a no-go. It is not even remotely related to hardware
>> monitoring, and thus must not be attached to the hwmon device.
>>
>> I don't know exactly where it belongs, but it appears to be related
>> to the keyboard. Its natural place therefore seems to be a keyboard driver.
>> We could possibly also attach it to the platform device, but there would
>> have to be some precedence of other drivers doing the same. Question
>> in that case though would be if this is just the first of many attributes
>> to come. If so, we would need to find a different solution.
>>
>> Guenter
> 
> Sure! Should this driver with those changes go into a platform driver?

You are attaching the attribute to the hwmon device. Moving the driver
to another directory would just be an attempt to avoid review by a
hwmon maintainer. Just for that reason I would NACK such an attempt.

Guenter

> Seems a better fit to me. The case against keyboard driver is the
> switch changes behaviour of the key but both the behaviour with the
> switch on and off is device defined. Some use the key as part of an AT
> Translated Keyboard and others just operate on the EC itself to grab
> the fan and set a special TDP for "Silent mode".
> For now this is the first such attribute found by the community and
> some talks with the manufacturer but it doesn't mean there wouldn't be
> others. Specially with such new form factors adding some "control
> panels" on Windows to set some hardware behaviour via EC writes. My
> goal is to allow those same functions to be available to linux users
> in a way some other userspace tools can serve as front ends.
> 
> Would taking this same driver to the platform side be a solution to
> that going forward? It would be a combination of hwmon monitoring
> attributes and some other special functions with custom attributes.
> Seems a better fit to me.


  reply	other threads:[~2023-05-31 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27  1:22 Joaquín Ignacio Aramendía
2023-05-28 23:52 ` Guenter Roeck
2023-05-31 12:04   ` Joaquin Aramendia
2023-05-31 16:46     ` Guenter Roeck [this message]
2023-06-07 12:40       ` Joaquin Aramendia
2023-06-07 17:33         ` Guenter Roeck
2023-06-09 12:50           ` Joaquin Aramendia
2023-06-09 14:37             ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=820cef00-4768-46ae-c5a5-ea7c0dff71c5@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=derekjohn.clark@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samsagax@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®