From: Jacob Keller <jacob.e.keller@intel.com>
To: Daniel Vacek <neelx@redhat.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
"Kolacinski, Karol" <karol.kolacinski@intel.com>,
Siddaraju <siddaraju.dh@intel.com>,
"Michalik, Michal" <michal.michalik@intel.com>,
<netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] ice/ptp: fix the PTP worker retrying indefinitely if the link went down
Date: Wed, 18 Jan 2023 14:22:43 -0800 [thread overview]
Message-ID: <820cf397-a99e-44d4-cf9e-3ad6876e4d06@intel.com> (raw)
In-Reply-To: <CACjP9X8SHZAd_+HSLJCxYxSRQuRmq3r48id13r17n2ehrec2YQ@mail.gmail.com>
On 1/18/2023 2:11 PM, Daniel Vacek wrote:
> On Wed, Jan 18, 2023 at 9:59 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>> On 1/18/2023 7:14 AM, Daniel Vacek wrote:
>> 1) request tx timestamp
>> 2) timestamp occurs
>> 3) link goes down while processing
>
> I was thinking this is the case we got reported. But then again, I'm
> not really experienced in this field.
>
I think it might be, or at least something similar to this.
I think that can be fixed with the link check you added. I think we
actually have a copy of the current link status in the ice_ptp or
ice_ptp_tx structure which could be used instead of having to check back
to the other structure.
I'm just hoping not to re-introduce bugs related to the hardware
interrupt counter that we had which results in preventing all future
timestamp interrupts.
> --nX
>
>> 1) link down
>> 2) request tx timestamp rejected
>>
>> Thanks!
>>
>> -Jake
>
next prev parent reply other threads:[~2023-01-18 22:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 18:15 Daniel Vacek
2023-01-17 18:46 ` [Intel-wired-lan] " Jacob Keller
2023-01-18 15:14 ` Daniel Vacek
2023-01-18 20:59 ` Jacob Keller
2023-01-18 22:11 ` Daniel Vacek
2023-01-18 22:22 ` Jacob Keller [this message]
2023-01-19 9:38 ` Daniel Vacek
2023-01-19 19:24 ` Jacob Keller
2023-01-19 20:08 ` Daniel Vacek
2023-01-22 17:44 ` D H, Siddaraju
2023-01-19 20:23 ` [PATCH v3] " Daniel Vacek
2023-01-23 19:15 ` Jacob Keller
2023-01-31 4:20 ` [Intel-wired-lan] " G, GurucharanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=820cf397-a99e-44d4-cf9e-3ad6876e4d06@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.michalik@intel.com \
--cc=neelx@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=siddaraju.dh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®