From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755736AbdC2Kau (ORCPT ); Wed, 29 Mar 2017 06:30:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:59089 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755474AbdC2Kas (ORCPT ); Wed, 29 Mar 2017 06:30:48 -0400 Subject: Re: [PATCH 6/6] scsi: pm8001: remove the SAS host after the SCSI host To: Jinpu Wang , Johannes Thumshirn References: <20170329094122.9997-4-jthumshirn@suse.de> Cc: "Martin K . Petersen" , Tejun Heo , James Bottomley , Dan Williams , John Garry , Linux SCSI Mailinglist , Linux Kernel Mailinglist From: Hannes Reinecke Message-ID: <820dee0c-8231-ecc6-1999-d6f9e38991b4@suse.de> Date: Wed, 29 Mar 2017 12:30:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/29/2017 12:27 PM, Jinpu Wang wrote: > On Wed, Mar 29, 2017 at 11:41 AM, Johannes Thumshirn wrote: >> After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the >> removal path of kernfs to make it recursive we have to remove the SAS host >> before the SCSI host or we will see sysfs warnings on not found sysfs groups for >> kobjects. >> >> Signed-off-by: Johannes Thumshirn >> --- >> drivers/scsi/pm8001/pm8001_init.c | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c >> index 417368c..9116e9c 100644 >> --- a/drivers/scsi/pm8001/pm8001_init.c >> +++ b/drivers/scsi/pm8001/pm8001_init.c >> @@ -1086,11 +1086,21 @@ static void pm8001_pci_remove(struct pci_dev *pdev) >> { >> struct sas_ha_struct *sha = pci_get_drvdata(pdev); >> struct pm8001_hba_info *pm8001_ha; >> + unsigned long flags; >> + struct Scsi_Host *shost; >> int i, j; >> pm8001_ha = sha->lldd_ha; >> - scsi_remove_host(pm8001_ha->shost); >> + shost = pm8001_ha->shost; >> + >> + spin_lock_irqsave(shost->host_lock, flags); >> + if (scsi_host_set_state(shost, SHOST_CANCEL)) >> + WARN_ON(scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY)); >> + spin_unlock_irqrestore(shost->host_lock, flags); >> + >> sas_unregister_ha(sha); >> - sas_remove_host(pm8001_ha->shost); >> + sas_remove_host(shost); >> + scsi_remove_host(shost); >> + >> list_del(&pm8001_ha->list); >> PM8001_CHIP_DISP->interrupt_disable(pm8001_ha, 0xFF); >> PM8001_CHIP_DISP->chip_soft_rst(pm8001_ha); >> -- >> 1.8.5.6 >> > Thanks Johannes for taking care of this. Looks good to me, > > I have a question regarding the scsi_host_set_state change, why do we need that? > Can't we simply change the order of sas_remove_host and scsi_remove_host? > If we don't do that I/O might still be coming in for the attached ports while we're trying to remove the same. Which might cause all sorts of race conditions. So it's better to set the host state to CANCEL to stop I/O before removing the ports. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)