From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CC17F9 for ; Wed, 23 Jul 2025 21:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753307208; cv=none; b=r1ddfWkZtsIlNN1XUU3AvLU51cjqinV+fNNtkjWwGWCZb234BnsXQE9FQ2zUJVcRJXU/YcGsgSqev8ZJXKSt6cJakGQzDuUNNrkNUh6amQXtfef/oMtANIlZEi2tEtpTxBob1oFxaVhqG3ZulavgX4jsFT26zC+j5qd2inwZvfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753307208; c=relaxed/simple; bh=i5RS2oswlin9WqfB1WhvdIdXj3qEanY6nAP/Uhj0hAY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=boR1IXWSscmZ26xR/aNRxn/KAkVD+pFIK/Vh8iZVRl7182fa9vVmXpb30jUUzNUJ4K30JgdK27Ad4Ax/Ge/i86bMQI+HRXz81bh9bvH26OTTpzB06Z0WRSrSUW0kpKFUgxWe7xILFQlapJ3GhjI3WlfS1l9HxN+5I2jnk/sovR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IoZGisDV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IoZGisDV" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56NHQKlW024756 for ; Wed, 23 Jul 2025 21:46:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tvauJF9+c6IKxzBGTcvA8iSaaoeAgCJyCD9Tgwx44f0=; b=IoZGisDVCuegZMFt /m/Q4EEsuKHnnCOd7eju/TXpfgxGb5IOhqc27QPCdVKs94ZKD8bIem3LfsZI+E52 JotkVof08ygoTKIbTWh+vcogoJww7Gkk4LXwJaU6YwIzUYrwQ/aop30OxPWmoAx9 aza2USyuTvfNUJtwEtTnL+Ofjbq9B5AVVQ3KZi0jMyA+YA0VQW6dbvAUnpggMjmt CWFlf+Rimaj5KkGhSKvr3qfGA7JTVW5IpAJmBJt09cos2ADWMDObwoDc3YSRpD2j 86tkgt3JYPesJ9JrXH4T2Tnmw/xwKVbcOmJoU0BKcRyUcHPVV36lSSSFz/eRuF1E F3cqfw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48044dpe1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 23 Jul 2025 21:46:45 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-23507382e64so2331525ad.2 for ; Wed, 23 Jul 2025 14:46:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753307204; x=1753912004; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tvauJF9+c6IKxzBGTcvA8iSaaoeAgCJyCD9Tgwx44f0=; b=qsOI7Gy6jdmMtqhPxtoQvHEZdaPpnFa3aSLqXYxArH2CpB1a3veIwls4JCThEFdbIt PAthRWGTOZHXETKLB/cGQkYBWaB8febNRPiHvI4/YNXrwdSUTKA/262ZcbLSgJfENnCH QO+93ibzWeBuGJD80p2r7sm36gxNl+Oq/nY0jC/8whbBNmiZ8d1GJeVxwLbFSjrLWPp4 TWnJh780jv51tQwxDKvIahWslgoxpbilu4kg6Acd84MTW49TZ+vVIxw0UlAtGD4iTwdJ S5/U6CWkRaN7wyw2NcU+W1Exti7mbt4SggFNNBcdqXcBLnaamj8+iaOp+V+F4jRsT233 3G+A== X-Forwarded-Encrypted: i=1; AJvYcCXZaDwMIqzxBPc/8D6XMSeu8RSj8dcZnZcTOTcKNrtwNtYvvuVhEdoh2MsVkpK2KktytCDn8Y6hwNjhKIM=@vger.kernel.org X-Gm-Message-State: AOJu0YxrrZxK/RNQVuVmrZS3c9aLVbnR2Xj60FHh3JNknWKsAAQJTHFC l3vxwqLoDtt+X4wopADTg+R/cHGmFrtmddI4tI80oTEwtj6iETO1HKUgTz0R7YGd8KErrOuYb/V 8dC+skNEGCP68CidDVMJHJ/OdxFkbqsX0wtJIgDrHiQ1JgO7Z90DwgaYNW0a0fRyH/e0= X-Gm-Gg: ASbGncvijKvrZRsqonIEC9INNw1bjxR8Hv7uES9VRoScRmR1rDaXxUWXJU9+8Qbwh3G 4bFD0FdbCDLisMsQI4HDAhplXelbRYH2DTdfNAQ6dh6XOahBwGeZnn7uiunXqCpV9Uey3r4Jii6 b23CyeedvTubvI3VKawg17TPpOBSwFM+nCrThZkTRtYb2lpYJhi45w1iYd2OaYC/eRf9lgsrbjg a1MqAnyyFl7ercrSUIkGCjM2bmlzNM+Lv7wXvC7cfdYCjPKtDEWKsGCNAxSxv/b3SwUGjx3ARVi jDSRAw0Qob3i132EyphzC+LQv4LnuFVU2o10N8mwxHvXLellip0ohwibsRquxw== X-Received: by 2002:a17:903:1b48:b0:234:a734:4ab1 with SMTP id d9443c01a7336-23f981404c6mr59177255ad.3.1753307203826; Wed, 23 Jul 2025 14:46:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEifem4DTzHzvzmHJWifbcs4RdVeOJnOTJq0luVnu1W3g+TYFyHU5if7/jQbz053j1WkSaKAw== X-Received: by 2002:a17:903:1b48:b0:234:a734:4ab1 with SMTP id d9443c01a7336-23f981404c6mr59176895ad.3.1753307203346; Wed, 23 Jul 2025 14:46:43 -0700 (PDT) Received: from [192.168.1.5] ([106.222.235.3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23fa48dc18fsm198195ad.133.2025.07.23.14.46.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jul 2025 14:46:43 -0700 (PDT) Message-ID: <820f45f1-9494-48eb-b536-7a8124de06f0@oss.qualcomm.com> Date: Thu, 24 Jul 2025 03:16:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/17] drm/msm: Skip devfreq IDLE when possible To: rob.clark@oss.qualcomm.com Cc: Dmitry Baryshkov , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250720-ifpc-support-v1-0-9347aa5bcbd6@oss.qualcomm.com> <20250720-ifpc-support-v1-12-9347aa5bcbd6@oss.qualcomm.com> <800f8c9d-5586-46a7-aa83-dfb3b97633e0@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=BJ6zrEQG c=1 sm=1 tr=0 ts=68815845 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=pSIa2sKh8ADkebnh61Ypzg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=XTD9XnCZvQp0TTkZ5uwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: rOacLY4q394Ykv94U_dydcZVAO0VcZP- X-Proofpoint-ORIG-GUID: rOacLY4q394Ykv94U_dydcZVAO0VcZP- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIzMDE4NSBTYWx0ZWRfX+10PzwoDLvUd IIuWRZq51xCf0x+oO1pwKAqmu8O9awPCZvzWTa7lBpDaJQgJNbXYvDSvU/texxyvMkQrQV6ruSc k04gCzD0aKuYiks/F3LT74o62duSoLV9+ocUs1lsWXsU0wkxV+FXPzirBmF6LuT05LVXyrfwuQ3 CqsRFKdmm30htMfC4INsiWYo1E6fBIjs36S0kvX0i26KAf+fqgw/rhpGkqvz5UL2GjgxZmnuyFO 9R5VZXCuj9yOBS50RCWFfUkPaiOypMHL6beWoQRcQegX7lvMOujGvqDEb9TpRqhDbPMpnx6Wy8Z CONpLCV/f14ceeQrAqUgaRqsU/r+rxbnylJJDGPSNefn2pt44ACXSywb7zDSq1f/Bfrna8Ai7Pe NXU8/E+I+CqgWCoyr4xjBkeNlP/ai4rOpH+a+/sMcl+1odVVK79ixRsUXQGt88xJ0IR1/EYD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-23_03,2025-07-23_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507230185 On 7/23/2025 1:43 AM, Rob Clark wrote: > On Tue, Jul 22, 2025 at 12:23 PM Akhil P Oommen > wrote: >> >> On 7/22/2025 9:08 PM, Rob Clark wrote: >>> On Tue, Jul 22, 2025 at 6:50 AM Dmitry Baryshkov >>> wrote: >>>> >>>> On Sun, Jul 20, 2025 at 05:46:13PM +0530, Akhil P Oommen wrote: >>>>> When IFPC is supported, devfreq idling is redundant and adds >>>>> unnecessary pm suspend/wake latency. So skip it when IFPC is >>>>> supported. >>>> >>>> With this in place we have a dummy devfreq instance which does nothing. >>>> Wouldn't it be better to skip registering devfreq if IFPC is supported >>>> on the platform? >>> >>> devfreq is still scaling the freq. What is being bypassed is >>> essentially a CPU based version of IFPC (because on sc7180 we didn't >>> have IFPC >>> >>> Currently only a618 and 7c3 enable gpu_clamp_to_idle.. if at some >>> point those grew IFPC support we could remove the trickery to drop GPU >>> to min freq when it is idle altogether. >> >> There are 2 functionalities here: >> 1. Clamp-to-idle: enabled only on a618/7c3 >> 2. boost-after-idle: Enabled for all GPUs. >> >> With this patch, we are skipping both when IFPC is supported. In the >> absence of latency due to clamp-to-idle, do you think a618 (relatively >> weaker GPU) would require boost-after-idle to keep with the >> UI/composition workload for its typical configuration (1080p@60hz)? If >> yes, I should probably create a quirk to disable boost-after-idle for >> premium tier GPUs, instead of tying it to IFPC feature. > > Hmm, yeah.. I suppose _this_ patch should only skip clamp-to-idle. It > is a different topic, boost-after-idle. I think we can just drop this patch. Also, Boost-after-idle is not super bad as it is only doubling the gpu freq. We can try to optimize it separately. -Akhil. > > BR, > -R > >> -Akhil. >> >>> >>> BR, >>> -R >>> >>>>> >>>>> Signed-off-by: Akhil P Oommen >>>>> --- >>>>> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c >>>>> index 2e1d5c3432728cde15d91f69da22bb915588fe86..53ef2add5047e7d6b6371af949cab36ce8409372 100644 >>>>> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c >>>>> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c >>>>> @@ -4,6 +4,7 @@ >>>>> * Author: Rob Clark >>>>> */ >>>>> >>>>> +#include "adreno/adreno_gpu.h" >>>>> #include "msm_gpu.h" >>>>> #include "msm_gpu_trace.h" >>>>> >>>>> @@ -300,6 +301,8 @@ void msm_devfreq_active(struct msm_gpu *gpu) >>>>> if (!has_devfreq(gpu)) >>>>> return; >>>>> >>>>> + if (to_adreno_gpu(gpu)->info->quirks & ADRENO_QUIRK_IFPC) >>>>> + return; >>>>> /* >>>>> * Cancel any pending transition to idle frequency: >>>>> */ >>>>> @@ -370,6 +373,9 @@ void msm_devfreq_idle(struct msm_gpu *gpu) >>>>> if (!has_devfreq(gpu)) >>>>> return; >>>>> >>>>> + if (to_adreno_gpu(gpu)->info->quirks & ADRENO_QUIRK_IFPC) >>>>> + return; >>>>> + >>>>> msm_hrtimer_queue_work(&df->idle_work, ms_to_ktime(1), >>>>> HRTIMER_MODE_REL); >>>>> } >>>>> >>>>> -- >>>>> 2.50.1 >>>>> >>>> >>>> -- >>>> With best wishes >>>> Dmitry >>