From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbcI1HOP (ORCPT ); Wed, 28 Sep 2016 03:14:15 -0400 Received: from mailapp02.imgtec.com ([217.156.133.132]:3077 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750997AbcI1HOH (ORCPT ); Wed, 28 Sep 2016 03:14:07 -0400 X-Greylist: delayed 962 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Sep 2016 03:14:06 EDT Subject: Re: [PATCH 2/2] MIPS: set NR_syscall_tables appropriately To: Ralf Baechle References: <1472463007-6469-1-git-send-email-marcin.nowakowski@imgtec.com> <1472463007-6469-2-git-send-email-marcin.nowakowski@imgtec.com> <20160927120442.GF12981@linux-mips.org> CC: "open list:MIPS" , open list From: Marcin Nowakowski Message-ID: <82120249-b6c9-2772-427a-d7318c019a8c@imgtec.com> Date: Wed, 28 Sep 2016 08:58:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160927120442.GF12981@linux-mips.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.2.5] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.09.2016 14:04, Ralf Baechle wrote: > On Mon, Aug 29, 2016 at 11:30:07AM +0200, Marcin Nowakowski wrote: > >> Depending on the kernel configuration, up to 3 syscall tables can be >> used in parallel - so set the number properly to ensure syscall tracing >> is set up properly. >> >> Signed-off-by: Marcin Nowakowski >> --- >> arch/mips/include/asm/unistd.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/mips/include/asm/unistd.h b/arch/mips/include/asm/unistd.h >> index e558130..71162f3d 100644 >> --- a/arch/mips/include/asm/unistd.h >> +++ b/arch/mips/include/asm/unistd.h >> @@ -22,6 +22,10 @@ >> #define NR_syscalls (__NR_O32_Linux + __NR_O32_Linux_syscalls) >> #endif >> >> +#define NR_syscall_tables (1 + \ >> + IS_ENABLED(CONFIG_MIPS32_O32) + \ >> + IS_ENABLED(CONFIG_MIPS32_N32)) >> + >> #ifndef __ASSEMBLY__ > > NR_syscall_tables is a new symbol but I don't see any users of this > symbol? > Hi Ralf, Patch 1/2 from this series did make use of that symbol. However, this patch has now been superseded by a slightly different approach following a discussion on the original proposal ... https://lkml.org/lkml/2016/9/16/57 Marcin