mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
	Vincent Donnefort <vincent.donnefort@arm.com>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] cpufreq: Auto-register with energy model if asked
Date: Tue, 10 Aug 2021 16:33:33 +0100	[thread overview]
Message-ID: <821da524-0ca5-6923-2f57-2d6ed4723c7d@arm.com> (raw)
In-Reply-To: <20210810093828.drel3kuurmhd4ki7@vireshk-i7>



On 8/10/21 10:38 AM, Viresh Kumar wrote:
> On 10-08-21, 10:36, Lukasz Luba wrote:
>> The of_cpufreq_cooling_register() should be called after the EM
>> is present for the CPU device. When you check that function,
>> you will see that we call
>> em_cpu_get(policy->cpu)
>> to get the EM pointer. Otherwise IPA might fail.
> 
> Good point.
> 

In other patch set I had a discussion with Quentin and I've checked
the Performance Domains setup code. There is a code triggering the
rebuilding perf domains with EM from governor. We cannot call
EM registration so late in this cpufreq_online(), not after
cpufreq_init_policy() call.

So this dev_pm_opp_of_unregister_em() must be called before
the policy is initialized. I'm not sure if you still would like
to push forward this patch set in this case.

  reply	other threads:[~2021-08-10 15:34 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  7:36 [PATCH 0/8] cpufreq: Auto-register with energy model Viresh Kumar
2021-08-10  7:36 ` [PATCH 1/8] cpufreq: Auto-register with energy model if asked Viresh Kumar
2021-08-10  9:36   ` Lukasz Luba
2021-08-10  9:38     ` Viresh Kumar
2021-08-10 15:33       ` Lukasz Luba [this message]
2021-08-10  7:36 ` [PATCH 2/8] cpufreq: dt: Use auto-registration for energy model Viresh Kumar
2021-08-10 10:19   ` Lukasz Luba
2021-08-10  7:36 ` [PATCH 3/8] cpufreq: imx6q: " Viresh Kumar
2021-08-10 10:20   ` Lukasz Luba
2021-08-10  7:36 ` [PATCH 4/8] cpufreq: mediatek: " Viresh Kumar
2021-08-10 10:20   ` Lukasz Luba
2021-08-10  7:36 ` [PATCH 5/8] cpufreq: omap: " Viresh Kumar
2021-08-10 10:24   ` Lukasz Luba
2021-08-10  7:36 ` [PATCH 6/8] cpufreq: qcom-cpufreq-hw: " Viresh Kumar
2021-08-10 10:26   ` Lukasz Luba
2021-08-10  7:36 ` [PATCH 7/8] cpufreq: scpi: " Viresh Kumar
2021-08-10 10:27   ` Lukasz Luba
2021-08-11  2:40   ` Sudeep Holla
2021-08-10  7:36 ` [PATCH 8/8] cpufreq: vexpress: " Viresh Kumar
2021-08-10 10:05   ` Lukasz Luba
2021-08-10 10:06     ` Viresh Kumar
2021-08-10 10:11       ` Lukasz Luba
2021-08-10 10:12         ` Viresh Kumar
2021-08-10 10:30   ` Lukasz Luba
2021-08-11  2:40   ` Sudeep Holla
2021-08-10  9:17 ` [PATCH 0/8] cpufreq: Auto-register with " Lukasz Luba
2021-08-10  9:27   ` Viresh Kumar
2021-08-10  9:35     ` Lukasz Luba
2021-08-10 12:35 ` Quentin Perret
2021-08-10 13:25   ` Lukasz Luba
2021-08-10 13:53     ` Quentin Perret
2021-08-11  5:18   ` Viresh Kumar
2021-08-11  5:34     ` Viresh Kumar
2021-08-11  9:48       ` Quentin Perret
2021-08-11  9:53         ` Viresh Kumar
2021-08-11 10:12           ` Quentin Perret
2021-08-11 10:14             ` Viresh Kumar
2021-08-11  8:37     ` Quentin Perret
2021-08-11  9:13       ` Viresh Kumar
2021-08-11  9:34         ` Quentin Perret
2021-08-11  9:36           ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=821da524-0ca5-6923-2f57-2d6ed4723c7d@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=vincent.donnefort@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®