From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8E1C433EF for ; Wed, 29 Jun 2022 11:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbiF2LSv (ORCPT ); Wed, 29 Jun 2022 07:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbiF2LSr (ORCPT ); Wed, 29 Jun 2022 07:18:47 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28B721244 for ; Wed, 29 Jun 2022 04:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1656501525; x=1688037525; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8DEsZcP8wnNuDkDTsKoZkNehiHn9QvzTdKDqdcGcm/U=; b=UFC4BFlUXAeChi4Q6b1fovr9DRzbk65XrP5NTFUYMypwA7wG2PPBCPCd vgs2Zg9UNyWwCosW2U+asV3VJXLqIYC+a7QPlvGM2OLDAWYL+ijKNJWyT AX9RLKIJ3DeOO+h8p33a/amPUEp0noEBduk80JIBu55OGspB9HXiRH2fQ 5exo7FzvzjzH0qQH6UG6NMoL4JvEZYaMk9z4ebXJufKbpn932EK0lb4Rd avRkz3mRSZuKChnxE/KLIdpSrP3etpoM5soizegTw9pybGXHtH/mc5f1e q6L2LiDpFkkwQCWBlVBqsJMSOIswGq75OtkDsm+nk6HQy9nxDRn6c9VNB Q==; X-IronPort-AV: E=Sophos;i="5.92,231,1650902400"; d="scan'208";a="203051772" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 29 Jun 2022 19:18:43 +0800 IronPort-SDR: rgj8N5KJHh5t2dLf18UqO56/fiHCLj6R+A1ePOPSYVJWnJacsDrBZGwwrQfy38Ar+hgd9iKEVb umBjJ2psRaco9eA+maqaGxft+pjhnUyHhwweJymgeS43n8uu0vnvARfHEkBk2TJ9iSjVZEaSlj RBijUXGSpBX/ynH77JRZEZ+I7TLfAfO3CDLwmsygcPIUgAM+vBDz4EkkvnnRsePcu3vKbSW4Ir 4bi8ECzJWj8/E/trxkJPC2QMwVSv4B6Q9+AaoaGdWCDva8/TGEWShJysi2Wd2/d0RmEFCXXJiH k4NcCZek2kpWBYFBYniur5Jn Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Jun 2022 03:36:22 -0700 IronPort-SDR: ZulOvm7cYqhqkdCfznEaEXHg1YCidxdP1CGmQLVgp/sfB4AwD4a4unfTZGz/sv3OZFlWFqw5K/ Fu1xQWA5e36bHM/4QfKyG+XJjuY6s+40aZWPkVYHMW1HQvvpopvkdl5iVRY9Jg5SQP5GUfmm9n G3N1c23hFaJ+2xyuVGT+Mr0XCEbZP5Y8Iq/YFa7lbp4TSPwNk/IfDDTovjBaaU/pfNX7XyBYxO /bHd9dw2tmISXcMrf7Nf5tFJ19+FeIpppUI1LyTlKKEvSP2oM79PLv5uQq3YSDafD0f9TATTxK kqQ= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Jun 2022 04:18:42 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LXzVV5BqYz1Rwnm for ; Wed, 29 Jun 2022 04:18:42 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1656501522; x=1659093523; bh=8DEsZcP8wnNuDkDTsKoZkNehiHn9QvzTdKD qdcGcm/U=; b=JWDF71mJGb2IWvw1oNKGVMrot3qC8Q0V70BLGPr+42MHvIeqKez utVbe6sM3GczzDvhOj/XV1Lvdd9A5voKMbCAr/+qWRUNHLTH9tujow6Wv/+SIhf+ +JnrHBwZykNYo9Sz4/oIsBWrSZJ9joy5gzXkfSn1h3Emr8gacYoPteLuZISjfsVa bwySsHOjqPLn2afj+z8KqXCR61BLd2r3Ryk/RPhvCGRVVhuOrlCxV8XjMeplMpr2 QLA+Iz3J0gx0Mhsp7R9WaCbuSrVo/GkuEmBkhrBc7+5ahtUmAPfe8uOEkEec5X3P CuR2KSvz5oMjpS9Jrawl4lXr5F9hAiJrD7w== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7rFINyPJl0Ds for ; Wed, 29 Jun 2022 04:18:42 -0700 (PDT) Received: from [10.225.163.99] (unknown [10.225.163.99]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LXzVT42sjz1RtVk; Wed, 29 Jun 2022 04:18:41 -0700 (PDT) Message-ID: <8227ef6a-665f-d16c-e5e4-6e04e2e6ee45@opensource.wdc.com> Date: Wed, 29 Jun 2022 20:18:40 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] ata: pata_cs5535: Fix W=1 warnings Content-Language: en-US To: John Garry , s.shtylyov@omp.ru Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <1656494324-101603-1-git-send-email-john.garry@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <1656494324-101603-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/22 18:18, John Garry wrote: > x86_64 allmodconfig build with W=3D1 gives these warnings: >=20 > drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_piomode=E2=80= =99: > drivers/ata/pata_cs5535.c:93:11: error: variable =E2=80=98dummy=E2=80=99= set but not used [-Werror=3Dunused-but-set-variable] > u32 reg, dummy; > ^~~~~ > drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_dmamode=E2=80= =99: > drivers/ata/pata_cs5535.c:132:11: error: variable =E2=80=98dummy=E2=80=99= set but not used [-Werror=3Dunused-but-set-variable] > u32 reg, dummy; > ^~~~~ > cc1: all warnings being treated as errors >=20 > Mark variables 'dummy' as "maybe unused" as they are only ever written = in > rdmsr() calls. >=20 > Signed-off-by: John Garry > Reviewed-by: Sergey Shtylyov Updated for-5.20. Thanks ! > --- > Differences to v1: > - Add RB tag (thanks!) > - Fix commit message >=20 > diff --git a/drivers/ata/pata_cs5535.c b/drivers/ata/pata_cs5535.c > index 6725931f3c35..c2c3238ff84b 100644 > --- a/drivers/ata/pata_cs5535.c > +++ b/drivers/ata/pata_cs5535.c > @@ -90,7 +90,7 @@ static void cs5535_set_piomode(struct ata_port *ap, s= truct ata_device *adev) > static const u16 pio_cmd_timings[5] =3D { > 0xF7F4, 0x53F3, 0x13F1, 0x5131, 0x1131 > }; > - u32 reg, dummy; > + u32 reg, __maybe_unused dummy; > struct ata_device *pair =3D ata_dev_pair(adev); > =20 > int mode =3D adev->pio_mode - XFER_PIO_0; > @@ -129,7 +129,7 @@ static void cs5535_set_dmamode(struct ata_port *ap,= struct ata_device *adev) > static const u32 mwdma_timings[3] =3D { > 0x7F0FFFF3, 0x7F035352, 0x7F024241 > }; > - u32 reg, dummy; > + u32 reg, __maybe_unused dummy; > int mode =3D adev->dma_mode; > =20 > rdmsr(ATAC_CH0D0_DMA + 2 * adev->devno, reg, dummy); --=20 Damien Le Moal Western Digital Research