From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC05AC4321E for ; Thu, 1 Dec 2022 17:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbiLARbX (ORCPT ); Thu, 1 Dec 2022 12:31:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiLARbV (ORCPT ); Thu, 1 Dec 2022 12:31:21 -0500 X-Greylist: delayed 1648 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 01 Dec 2022 09:31:20 PST Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.52.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3716A5571 for ; Thu, 1 Dec 2022 09:31:20 -0800 (PST) Received: from atl1wswcm02.websitewelcome.com (unknown [50.6.129.163]) by atl1wswob01.websitewelcome.com (Postfix) with ESMTP id 1D70540130D8D for ; Thu, 1 Dec 2022 16:39:06 +0000 (UTC) Received: from md-in-79.webhostbox.net ([43.225.55.182]) by cmsmtp with ESMTP id 0maVpuGZ04ZGb0maXpXXyj; Thu, 01 Dec 2022 16:39:06 +0000 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linumiz.com ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Cc:To:Subject:From:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GgTnhe0B3cXs/oLOsaLvp0MgyDCHto0gydBPYUNi4j8=; b=O8MZrlCIlNpe/UdkM6ccTdg+j5 ZAx2s5ewseqOrE7vzzY3mhlmDrOjoAAchyJd7QpumSQ/65NciS+H1/vyCq1pWXu+odlqLqqhq7tGT RrTsk86uS3l8lwMnOKDJtzb5GIwo5eDl5vmFPvVYLq+QbRHPhqrUsZDJspLaE/C4dM6fO8Fdc4n2+ 9hM0134bLFgisyaXCT9/5zjRKOBxcTfJwsC/ArupZ1JupXQqgOX2mBFdafcxentyAIIVXbMLucv6t lI2NU1cmJkdk5r96OwM0PyTtKYy/VcCxx6ydKOX7xJHAsjcx81hnTGG96dulol036wpedaEavnx1e I/QY6TLA==; Received: from [106.197.183.239] (port=59743 helo=[192.168.221.42]) by md-in-79.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0maS-003nb2-KA; Thu, 01 Dec 2022 16:39:02 +0000 Message-ID: <8228db8d-2a32-1d23-74f3-05b9fe529a82@linumiz.com> Date: Thu, 1 Dec 2022 17:38:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Saravanan Sekar Subject: Re: [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC To: Krzysztof Kozlowski , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marten.lindahl@axis.com, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20221201044643.1150870-1-saravanan@linumiz.com> <20221201044643.1150870-3-saravanan@linumiz.com> <29de4d2b-3e32-809e-6ccd-5e7a4fe548fc@linaro.org> <785e942a-0691-f87e-b6e9-058749a79ec1@linaro.org> Content-Language: en-US In-Reply-To: <785e942a-0691-f87e-b6e9-058749a79ec1@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - md-in-79.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - linumiz.com X-BWhitelist: no X-Source-IP: 106.197.183.239 X-Source-L: No X-Exim-ID: 1p0maS-003nb2-KA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.221.42]) [106.197.183.239]:59743 X-Source-Auth: saravanan@linumiz.com X-Email-Count: 5 X-Source-Cap: bGludW1jbWM7aG9zdGdhdG9yO21kLWluLTc5LndlYmhvc3Rib3gubmV0 X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ1lWiXoEbNwwD0IKHhfSpuTEkdZz+2rp2wkd4VA3l1FncW1mswEAoT4k0WR0JnCzzNUybq1YlhN/B4X5jyib0i5jQ1DBJ7aIfqQVXxr7nlvE43RQhxg gn2I7j7vbhdPyYjVjAwnAnPKWPJ5+2wcMaC3jMj+bFUKY8WGA04HD1rEJ0Iu5SwB9QaWyNSCXxJtCa66oHR+Y6Ktl6V7bOz6trM= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/22 17:15, Krzysztof Kozlowski wrote: > On 01/12/2022 16:37, Guenter Roeck wrote: >> On 12/1/22 03:38, Krzysztof Kozlowski wrote: >>> On 01/12/2022 12:29, Saravanan Sekar wrote: >>>> On 01/12/22 11:26, Krzysztof Kozlowski wrote: >>>>> On 01/12/2022 05:46, Saravanan Sekar wrote: >>>>>> Document mpq7932 power-management IC >>>>>> >>>>>> Signed-off-by: Saravanan Sekar >>>>>> --- >>>>> >>>>> This is a friendly reminder during the review process. >>>>> >>>>> It seems my previous comments were not fully addressed. Maybe my >>>>> feedback got lost between the quotes, maybe you just forgot to apply it. >>>>> Please go back to the previous discussion and either implement all >>>>> requested changes or keep discussing them. >>>>> >>>> Hi Krzysztof, >>>> >>>> Thanks for your time to review and feedback. >>>> >>>> Here are the summary of comments on V1, I have fixed all according to my >>>> understanding. >>>> >>>> >>>> 1. Use subject prefixes matching the subsystem (git log --oneline -- ...). >>>> >>>> git log --oneline -- Documentation/devicetree/bindings/hwmon/pmbus/ >>>> 1ccca53618c4 dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC >>>> 373c0a77934c dt-bindings: hwmon/pmbus: Add ti,lm25066 power-management IC >>>> 7f464532b05d dt-bindings: Add missing 'additionalProperties: false' >>>> 8a36e38d8b0f dt-bindings: hwmon/pmbus: Add ti,ucd90320 power sequencer >>>> >>>> I have used the same format of 373c0a77934c. >>>> >>>> 2. Does not look like you tested the bindings. Please run `make >>>> dt_binding_check` (see >>>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >>>> >>>> I did run dt_binding_check on V1 but failed to notice warnings. Fixed >>>> warning on V2 and didn't observed any warnings. >>>> >>>> 3. Why requiring nodename? Device schemas usually don't do that. >>>> dropped "pattern: "pmic@[0-9a-f]{1,2}"" >>>> >>>> 4. regulators node is a regulator with one more regulator? Drop. >>>> dropped "$ref: regulator.yaml# " >>> >>> The comment was - drop entire regulators node. >>> >>> Plus additional comment for the driver (and related to bindings) was >>> that this is not hwmon but a regulator driver. Why putting regulator >>> driver in hwmon? >>> >> >> Turns out this is primarily a hardware monitoring driver, like the drivers >> for all other PMBus chips. Regulator support is actually optional; the driver >> works perfectly well with CONFIG_REGULATOR=n (except that it needs some >> #ifdefs to address that situation). > > OK, this would explain location of the driver. However the bindings are > saying: > "Monolithic Power System MPQ7932 PMIC" > and PMIC is not mainly a hwmon device, even if it has such capabilities. > It might be missing description and proper title... or might be misplaced. > Indeed it is PMIC chip. I think this is not the first and not sure title has to be changed for hwmon subsystem. bindings/hwmon/pmbus/ti,lm25066.yaml title: National Semiconductor/Texas Instruments LM250x6/LM506x power-management ICs Thanks, Saravanan