From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 04/15] perf evlist: introduce control file descriptors
Date: Mon, 13 Jul 2020 11:16:06 +0300 [thread overview]
Message-ID: <823145dc-f293-166e-290b-076c1254fe17@linux.intel.com> (raw)
In-Reply-To: <CAM9d7cj86U7xcmAdiKjEKNp+qS_YAP72xKusAjLWGo2frxpL_A@mail.gmail.com>
On 13.07.2020 6:13, Namhyung Kim wrote:
> Hello,
>
> On Wed, Jul 8, 2020 at 4:47 PM Alexey Budankov
> <alexey.budankov@linux.intel.com> wrote:
>>
>>
>> Define and initialize control file descriptors.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>> tools/perf/util/evlist.c | 3 +++
>> tools/perf/util/evlist.h | 5 +++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
>> index bcbe0cb8482e..36eb50aba1f5 100644
>> --- a/tools/perf/util/evlist.c
>> +++ b/tools/perf/util/evlist.c
>> @@ -63,6 +63,9 @@ void evlist__init(struct evlist *evlist, struct perf_cpu_map *cpus,
>> perf_evlist__set_maps(&evlist->core, cpus, threads);
>> evlist->workload.pid = -1;
>> evlist->bkw_mmap_state = BKW_MMAP_NOTREADY;
>> + evlist->ctl_fd.fd = -1;
>> + evlist->ctl_fd.ack = -1;
>> + evlist->ctl_fd.pos = -1;
>> }
>>
>> struct evlist *evlist__new(void)
>> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
>> index 38901c0d1599..2caf19fb87a8 100644
>> --- a/tools/perf/util/evlist.h
>> +++ b/tools/perf/util/evlist.h
>> @@ -74,6 +74,11 @@ struct evlist {
>> pthread_t th;
>> volatile int done;
>> } thread;
>> + struct {
>> + int fd;
>> + int ack;
>> + int pos;
>> + } ctl_fd;
>
> Could you please add brief descriptions for each field
> in the comment? It's not obvious to me other than fd.
Ok. In v11.
Alexei
next prev parent reply other threads:[~2020-07-13 8:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 7:36 [PATCH v10 00/15] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-07-08 7:45 ` [PATCH v10 01/15] tools/libperf: avoid internal moving of fdarray fds Alexey Budankov
2020-07-08 7:46 ` [PATCH v10 02/15] tools/libperf: add flags to fdarray fds objects Alexey Budankov
2020-07-08 7:47 ` [PATCH v10 03/15] tools/libperf: avoid counting of nonfilterable fdarray fds Alexey Budankov
2020-07-08 7:47 ` [PATCH v10 04/15] perf evlist: introduce control file descriptors Alexey Budankov
2020-07-13 3:13 ` Namhyung Kim
2020-07-13 8:16 ` Alexey Budankov [this message]
2020-07-08 7:50 ` [PATCH v10 05/15] perf evlist: implement control command handling functions Alexey Budankov
2020-07-13 3:20 ` Namhyung Kim
2020-07-13 8:24 ` Alexey Budankov
2020-07-08 7:50 ` [PATCH v10 06/15] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-07-08 7:51 ` [PATCH v10 07/15] perf stat: move target check to loop control statement Alexey Budankov
2020-07-08 7:51 ` [PATCH v10 08/15] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-07-08 7:52 ` [PATCH v10 09/15] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-07-08 7:53 ` [PATCH v10 10/15] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-07-08 7:53 ` [PATCH v10 11/15] perf stat: implement control commands handling Alexey Budankov
2020-07-08 7:54 ` [PATCH v10 12/15] perf stat: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-08 7:54 ` [PATCH v10 13/15] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-07-08 7:55 ` [PATCH v10 14/15] perf record: implement control commands handling Alexey Budankov
2020-07-08 7:55 ` [PATCH v10 15/15] perf record: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-12 21:12 ` [PATCH v10 00/15] perf: support enable and disable commands in stat and record modes Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=823145dc-f293-166e-290b-076c1254fe17@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®