From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>
Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver
Date: Thu, 16 Nov 2017 21:14:13 +0100 [thread overview]
Message-ID: <82336eb7-2b89-d37b-d688-4e4302766346@gmail.com> (raw)
In-Reply-To: <20171115222323.GA18290@amd>
Hi Dan and Pavel,
On 11/15/2017 11:23 PM, Pavel Machek wrote:
> Hi!
>
>>> Shouldn't the driver be targeted for backlight subsystem then?
>>>
>>> Adding backlight maintainers.
>>>
>>
>> Great point! I was not aware of the backlight subsystem.
>>
>> Looks like I need to create a back light version as well.
>>
>> Like the lp8788 did since this can be used as a LED driver beyond
>> display back lighting.
>
> No, definitely not two drivers for lp8788 hardware.
I agree.
> If that does not yet exist... you want to create glue layer to be able
> to use LED as a display backlight. (It may already exist, no idea).
>
> ...
>
> Actually or maybe a LED trigger. Just set LED's trigger to "this is
> display backlight".
There is one already:
drivers/leds/trigger/ledtrig-backlight.c
It adds a LED class device to the fb_notifier_list
(drivers/video/fbdev/core/fb_notify.c)
using fb_register_client(). The same is used in
backlight_device_register (drivers/video/backlight/backlight.c).
Actually why do you want to have this driver in the LED subsystem,
if it is advertised as "designed for LCD display backlighting"?
As a side note I can say that I've been always wondering why the two
subsystems for similar type of hardware.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2017-11-16 20:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 19:42 Dan Murphy
2017-11-15 19:42 ` [PATCH v3 2/2] leds: lm3692x: Introduce LM3692x dual string driver Dan Murphy
2017-11-15 21:12 ` Pavel Machek
2017-11-15 21:25 ` Dan Murphy
2017-11-18 14:19 ` Jacek Anaszewski
2017-11-28 12:53 ` Dan Murphy
2017-11-15 20:15 ` [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Jacek Anaszewski
2017-11-15 20:31 ` Dan Murphy
2017-11-15 22:23 ` Pavel Machek
2017-11-16 20:14 ` Jacek Anaszewski [this message]
2017-11-16 21:42 ` Dan Murphy
2017-11-17 2:19 ` Jingoo Han
2017-11-17 11:20 ` Pavel Machek
2017-11-17 16:30 ` Jingoo Han
2017-11-17 18:02 ` Dan Murphy
2017-11-17 23:58 ` Pavel Machek
2017-11-28 17:27 ` Dan Murphy
2017-11-16 15:41 ` Rob Herring
2017-11-16 15:45 ` Dan Murphy
2017-11-16 15:58 ` Rob Herring
2017-11-16 20:11 ` dts: fun with chip names " Pavel Machek
2017-11-16 20:36 ` Rob Herring
2017-11-16 21:40 ` Dan Murphy
2017-11-18 14:19 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82336eb7-2b89-d37b-d688-4e4302766346@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome