From: Arnd Bergmann <arnd@arndb.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org, Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH] reset: allow to pass NULL pointer to reset_control_put()
Date: Wed, 04 May 2016 13:24:03 +0200 [thread overview]
Message-ID: <8236507.We1UVOf0nF@wuerfel> (raw)
In-Reply-To: <1462360671-13668-1-git-send-email-yamada.masahiro@socionext.com>
On Wednesday 04 May 2016 20:17:51 Masahiro Yamada wrote:
> Currently, reset_control_put() just returns for error pointer,
> but not for NULL pointer. This is not reasonable.
>
> Passing NULL pointer should be allowed as well to make failure path
> handling easier.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/reset/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 181b05d..7bb16d1 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -288,7 +288,7 @@ EXPORT_SYMBOL_GPL(reset_control_get);
>
> void reset_control_put(struct reset_control *rstc)
> {
> - if (IS_ERR(rstc))
> + if (IS_ERR_OR_NULL(rstc))
> return;
>
> module_put(rstc->rcdev->owner);
Using IS_ERR_OR_NULL() normally indicates that there is something
wrong with the API, or with the caller.
What exactly is the idea behind treating an error pointer as a valid
input to reset_control_put() here? Maybe it should just test for
NULL?
Arnd
next prev parent reply other threads:[~2016-05-04 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 11:17 Masahiro Yamada
2016-05-04 11:24 ` Arnd Bergmann [this message]
2016-05-04 11:34 ` Masahiro Yamada
2016-05-04 12:34 ` Philipp Zabel
2016-05-04 12:47 ` Arnd Bergmann
2016-05-04 12:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8236507.We1UVOf0nF@wuerfel \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®