mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Katakam, Harini" <harini.katakam@amd.com>,
	Harini Katakam <harini.katakam@xilinx.com>,
	"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"claudiu.beznea@microchip.com" <claudiu.beznea@microchip.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
	"harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"radhey.shyam.pandey@xilinx.com" <radhey.shyam.pandey@xilinx.com>
Subject: Re: [PATCH 1/2] dt-bindings: net: cdns,macb: Add versal compatible string
Date: Wed, 20 Jul 2022 13:45:27 +0200	[thread overview]
Message-ID: <823ae0f4-b7c5-a301-0f2d-66f0e0a36aba@linaro.org> (raw)
In-Reply-To: <BYAPR12MB477363E846E5EB15D7AA2ABF9E8E9@BYAPR12MB4773.namprd12.prod.outlook.com>

On 20/07/2022 13:36, Katakam, Harini wrote:
>>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> index 9c92156869b2..1e9f49bb8249 100644
>>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> @@ -22,6 +22,7 @@ properties:
>>>            - enum:
>>>                - cdns,zynq-gem         # Xilinx Zynq-7xxx SoC
>>>                - cdns,zynqmp-gem       # Xilinx Zynq Ultrascale+ MPSoC
>>> +              - cdns,versal-gem       # Xilinx Versal
>>
>> Not really ordered by name. Why adding to the end?
> 
> Thanks for the review. It is just based on the order in which device
> families from Xilinx were released. I can alphabetize if that's preferred.

Yes, it's the easiest way to avoid conflicts.

Best regards,
Krzysztof

  reply	other threads:[~2022-07-20 11:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 11:29 [PATCH 0/2] Add Versal compatible string to Macb driver Harini Katakam
2022-07-20 11:29 ` [PATCH 1/2] dt-bindings: net: cdns,macb: Add versal compatible string Harini Katakam
2022-07-20 11:32   ` Krzysztof Kozlowski
2022-07-20 11:36     ` Katakam, Harini
2022-07-20 11:45       ` Krzysztof Kozlowski [this message]
2022-07-20 11:29 ` [PATCH 2/2] net: macb: Update tsu clk usage in runtime suspend/resume for Versal Harini Katakam
2022-07-22  8:25   ` Claudiu.Beznea
2022-07-22 10:34     ` Harini Katakam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=823ae0f4-b7c5-a301-0f2d-66f0e0a36aba@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=harini.katakam@amd.com \
    --cc=harini.katakam@xilinx.com \
    --cc=harinikatakamlinux@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=pabeni@redhat.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®