mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bot+bpf-ci@kernel.org
To: irogers@google.com,qmo@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,martin.lau@linux.dev,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,jpoimboe@kernel.org,peterz@infradead.org,mingo@redhat.com,acme@kernel.org,namhyung@kernel.org,irogers@google.com,adrian.hunter@intel.com,james.clark@linaro.org,terrelln@fb.com,dsterba@suse.com,tglozar@redhat.com,costa.shul@redhat.com,mjeanson@efficios.com,9erthalion6@gmail.com,leo.yan@arm.com,linux-kernel@vger.kernel.org,linux-perf-users@vger.kernel.org
Cc: bpf@vger.kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH v2 4/4] objtool: Add explicitly sequenced -lzstd to libopcodes fallback
Date: Wed,  9 Sep 2026 21:30:40 +0000 (UTC)	[thread overview]
Message-ID: <823e2efca0056494a3baf703f2d29991a1c7d1500f931684a8086c87394f18ae@mail.kernel.org> (raw)
In-Reply-To: <20260909204122.1993010-5-irogers@google.com>

[-- Attachment #1: Type: text/plain, Size: 2238 bytes --]

> commit 1f030996083bc0f6f03bca8dc04fe12feb66957d
> Author: Ian Rogers <irogers@google.com>
> Date:   Wed Sep 9 13:41:22 2026 -0700
>
>     objtool: Add explicitly sequenced -lzstd to libopcodes fallback
>
>     Distributions like Fedora currently ship a statically compiled binutils
>     libbfd (an intrinsic dependency of libopcodes) that internally utilizes
>     zstd to decompress sections.
>
>     Because objtool resolves host dependencies sequentially via a manual HOSTCC
>     shell loop, build failures will occur (e.g. undefined reference to
>     'ZSTD_decompress') unless the loop probes for it.
>
>     Add the '-lopcodes -lbfd -liberty -lz -lzstd' combination to the fallback
>     chain, assuring successful compilation on hosts packaging static binutils.

This isn't a bug, but could the changelog say the new candidate mirrors the
existing -lz fallback (and note it is untested, as the cover letter does)
rather than stating it assures a successful build?

>     Signed-off-by: Ian Rogers <irogers@google.com>
>     Assisted-by: Antigravity:gemini-3.1-pro
>
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index a4484fd22a96..141b957c566b 100644
> --- a/tools/objtool/Makefile
> +++ b/tools/objtool/Makefile
> @@ -88,7 +88,8 @@ LIBOPCODES_LIBS := $(shell \
>  	for libs in "-lopcodes" \
>  		    "-lopcodes -lbfd" \
>  		    "-lopcodes -lbfd -liberty" \
> -		    "-lopcodes -lbfd -liberty -lz"; do \
> +		    "-lopcodes -lbfd -liberty -lz" \
> +		    "-lopcodes -lbfd -liberty -lz -lzstd"; do \
>  		echo 'extern void disassemble_init_for_target(void *);' \
>  		     'int main(void) { disassemble_init_for_target(0); return 0; }' | \
>  			$(HOSTCC) -xc - -o /dev/null $$libs 2>/dev/null && \

This isn't a bug, but should the comment above the loop also mention libzstd,
so the documented dependency list still matches the candidates below it? The
comment currently says "libbfd, libiberty, and sometimes libz" but the new
candidate includes libzstd as well.


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/34404437407

  reply	other threads:[~2026-09-09 21:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 20:41 [PATCH v2 0/4] tools build: Fixes for libbfd -lzstd dependency Ian Rogers
2026-09-09 20:41 ` [PATCH v2 1/4] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback Ian Rogers
2026-09-09 20:41 ` [PATCH v2 2/4] perf " Ian Rogers
2026-09-09 20:41 ` [PATCH v2 3/4] bpftool: " Ian Rogers
2026-09-09 21:30   ` bot+bpf-ci
2026-09-10  9:20   ` Quentin Monnet
2026-09-10 15:37     ` Ian Rogers
2026-09-10 19:53       ` Quentin Monnet
2026-09-09 20:41 ` [PATCH v2 4/4] objtool: Add explicitly sequenced -lzstd to libopcodes fallback Ian Rogers
2026-09-09 21:30   ` bot+bpf-ci [this message]
2026-09-09 22:06   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=823e2efca0056494a3baf703f2d29991a1c7d1500f931684a8086c87394f18ae@mail.kernel.org \
    --to=bot+bpf-ci@kernel.org \
    --cc=9erthalion6@gmail.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=costa.shul@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=dsterba@suse.com \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mason@kernel.org \
    --cc=memxor@gmail.com \
    --cc=mingo@redhat.com \
    --cc=mjeanson@efficios.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qmo@kernel.org \
    --cc=song@kernel.org \
    --cc=terrelln@fb.com \
    --cc=tglozar@redhat.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®