From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755418AbdEDOQX (ORCPT ); Thu, 4 May 2017 10:16:23 -0400 Received: from server.coly.li ([162.144.45.48]:40876 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755117AbdEDOP4 (ORCPT ); Thu, 4 May 2017 10:15:56 -0400 X-Greylist: delayed 939 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 May 2017 10:15:56 EDT Subject: Re: [PATCH] bcache: explicitly destory mutex while exiting To: Liang Chen , linux-bcache@vger.kernel.org References: <1493712595-21528-1-git-send-email-liangchen.linux@gmail.com> Cc: linux-kernel@vger.kernel.org, colyli@suse.de, bcache@linux.ewheeler.net From: Coly Li Message-ID: <823fcdcf-893e-edc7-62c2-585db7f868ed@coly.li> Date: Thu, 4 May 2017 21:59:41 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493712595-21528-1-git-send-email-liangchen.linux@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/5/2 下午4:09, Liang Chen wrote: > mutex_destroy does nothing most of time, but it's better to call > it to make the code future proof and it also has some meaning > for like mutex debug. > Hi Liang, Could you please explain a little bit more about how mutex_destroy() helps to future proof of the code, and how it helps to mutex debug ? Forgive me for not catching your point. Thanks. > Signed-off-by: Liang Chen > --- > drivers/md/bcache/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 85e3f21..406fe03 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -2083,6 +2083,7 @@ static void bcache_exit(void) > if (bcache_major) > unregister_blkdev(bcache_major, "bcache"); > unregister_reboot_notifier(&reboot); > + mutex_destroy(&bch_register_lock); > } > > static int __init bcache_init(void) > @@ -2100,6 +2101,7 @@ static int __init bcache_init(void) > > bcache_major = register_blkdev(0, "bcache"); > if (bcache_major < 0) { > + mutex_destroy(&bch_register_lock); > unregister_reboot_notifier(&reboot); > return bcache_major; > } > -- Coly Li