From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753868AbcHZPi2 (ORCPT ); Fri, 26 Aug 2016 11:38:28 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:37973 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcHZPiZ (ORCPT ); Fri, 26 Aug 2016 11:38:25 -0400 Subject: Re: [PATCH] fix:mtip32xx: mark symbols static where possible To: Baoyou Xie , , , , , References: <1472191733-1259-1-git-send-email-baoyou.xie@linaro.org> CC: , , From: Jens Axboe Message-ID: <8241e338-692b-3119-6f2b-ff6ebf64767c@fb.com> Date: Fri, 26 Aug 2016 09:37:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472191733-1259-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM5PR20CA0018.namprd20.prod.outlook.com (10.173.136.156) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: fcb1afe2-2e5b-472b-ba62-08d3cdc6d8d7 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:R7q2jsnzNVDSjjfU6sR4BX/z3FQ4t6oF0W1kxlS3VzmBFyaXh3Py1S8bQVR5q7OaGFFIx+gXI6VfW8aDed2i5cRAUmm9LFswhdW79hbHztPtqIHrgjfYdUsKrUcIdDhJ9n/nSf3G0bCz+rDDxlSW2tacSShFPOEJpXAykTjhhV7+yYRtk8rEdAiRBNGxSBes;3:2yesW2CYWOpRqoMreFBrxwcBl+czHoXkVtuSkpIa50rVvhrTtbMcTIZ8rVOIQ8+4UJl8rjnGj4ftv4NFyq63DhQI9E5Dyr4H/4Vlr4ViQxhG7xoF9igowRa1rGOvGkEq X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;25:Ubz7RAksMz8iX54LT9ljINPRCz+HuQHiqKssr/m/EelixT8PDVSky1gV9CxuKg4EcOwQ0Mq7E1bHfX34nNn6QfRDnTDxiYlOBiOkPxckM4wmBDlaQwjqSg1uNVq4UtYVwW3MNwmFM+KDbY9AOYEf2aveEFjHBzishALC0mNoeVI48j9cjYi3Tx6nEWHp1XYuqRp1M6lE/I0M/gTfxFbWAbyOXSw7deDyDXQeThtgaOjxdinNin8/rtJqiSRU/fX/zK/HzzNuZwKH4G0l1npKzaCLjSpHzkQ0c/xd7t0Q3BB0pXyE7oUrFqEH66qA6Jr4tZip0A7/UIMF0ihEwOsO95RziIW+wt8Da7wSBABzolq7xUq/BPu/7D47fi8f1+fResUBCcZPJp6v0a0R0wTKCXgfC9O0jZ7tfj+TFaavX0KxDkA6Sf9LjiutMGIl/eX592dmJ6nxWQXvvanTjcT8eBV7kDNdG8ZcDyNAFkdwqiflElJoFtmNsvU0n7JaQpUxNvDGRPD/erVh0gfXDc2Ecck0IjUhnrfPD0LZu6UQR2ViQIXEsSiFUmtVlmv8mczNseAihXtvit0YKHICdISZb5TqiXsFkcu0W9nEP4jOCBga+uMm0t0VAvYnn4xGn3Cou+IHySKzQpPrtlKhjcPZ0OmiaLp58KcJcB0GZQZp1iIdyzzgXBsNwpPOu5HjBJARVPm3ab5Isx3B+Mzc8MMp6w==;31:lh9aXKmaPy7RuYuDHxhC2jlmG/XLqxBcuPUCmvq1YBulXetbEtoZRfEq+DorqmXEXVDRpA2E6leVV8rzaK1DaZTI1Ytby9ohcvxwMef0eAOpnZAaQJdCxFqBnECJ3hVNL1Nm5tSlkBqwTwiKwGdR/u/z5nEZK31PnFln6ytaWOG5FOIzMBqEy8SlbSaxaOqJbSr8ZR0Dp8V+qqVYU8pFSCIHBwtEIGVo10jqps8SESY= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:uEBdTmrFSoArycoffCB8lnESpJcqZHq5WZAkFDliM5Ksg4IvAI1uZ1gtFK3hXihsgtr8qbzHk3/alErcWRhhtZVYBrvgn3mFIUmZoO6rGGxQVGKTH/7H7any92EOAWwQAfJzVsbd5MYm5Kx8VoFbsHIiEUxOwk/f6zRomQNGrmM=;4:RYrC3BQXROs5F/A7ifly1bHCd04HoVmnG8JKxaAhohQYA/JKeGORx45TUt6RxT1foK4IlsYoJhcITHFQBGOL9h0eEKVmC5H+h25lIV6rBvvUgQqamdzJbcG3xmPImp6SKypyfco2buhxAGNWaUrm2N6LSnHXlIHxqZ+bXGcguxZqGeNVhFDXfaOu30m3GEYq/TsK+RbmtHFFskDsgYfpUJu4BU2LjZ8Ka0G2cyGKggYwu16bICz2pVCyFJYupc7i94QoOfDJJt9Ayk/demzMizzYsLvAre7JYeajR42MwVvQFNdmw16ANXytyLY6+6u41Z1UXYnHpCr98OfgR91dDV6VUl85UaeUTM6pIWBmqAzkdVQZpZ93VGMpHqWQkX9D X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 00462943DE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(24454002)(199003)(92566002)(101416001)(86362001)(4326007)(83506001)(50986999)(2906002)(54356999)(5660300001)(76176999)(47776003)(31696002)(77096005)(65956001)(65806001)(66066001)(3846002)(2950100001)(6116002)(230700001)(117156001)(586003)(8676002)(42186005)(31686004)(305945005)(106356001)(4001350100001)(2201001)(33646002)(50466002)(68736007)(97736004)(7846002)(5001770100001)(81156014)(105586002)(189998001)(36756003)(81166006)(7736002)(64126003)(23746002)(65826006)(2101003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:PxE8NL54uOQE7g/wiuhFhNFZh+RAOIa5FiTMh?= =?Windows-1252?Q?69gi7Z/YQR8e2Y5rczrFWf7QrRmtP1wLkUPKxQ0R0cHe5gPdrdmLIodF?= =?Windows-1252?Q?A1j6YtQJyoDhhwQgntqwbEXOGokDqmocUBrAwyzbPC0hBN0e/ts+CATT?= =?Windows-1252?Q?0Z9NQjH8xuhcCJ7q2IWg05bFTXtd76vKt9OoMk/qSa+NevRhJ2LHKtEz?= =?Windows-1252?Q?7d84Lgb7aK8yfS5YAlyS+OXzg8S9lUSULoIsrKkjPCJStZCFrIac0UTe?= =?Windows-1252?Q?rfOgxeV/INtrDPEnbw/t6ld66WpaF9nZrZB7nQwY/y1Y8PW5S0Yivffm?= =?Windows-1252?Q?oDEre5UN4WakhGQkqKEUpKk9K2UPnwPZZojAaaaxDy65gUCNj2hDXerz?= =?Windows-1252?Q?i8d+brfyUewegjUNxdKgfEOpABLwnNo3z1MYMazr23VE2Dc88/8ANJJs?= =?Windows-1252?Q?a/M7T6RJpakvZo9AstapplpcBqAHFJduycY4kGdrgK6wqVCJAtO7k0Qg?= =?Windows-1252?Q?LTFiby7nh7HExTtVuIVEzb8HWS8a/o0HdOaIU/wRxQExh/supNJHOW9E?= =?Windows-1252?Q?n9yeZGeZSBGLxXuSItUVtT0k57froVdLtPGcwlRAIaPxBOudoky0IuuB?= =?Windows-1252?Q?wxh3jXe/HVwF5EDGj2FEPbwydmwJqxVniCq0RGswFPFN1/rZ4ucjQN/l?= =?Windows-1252?Q?//QWKgr8qZRariPZcd6jfcUSg4Ohrb3F3clctPM46peTySDd+OeOMQWs?= =?Windows-1252?Q?sgw3ICkiLTyHlVQzitTwOalKc4iaR2E3R8Rv2Xrq0vVnLZp6Cu2CCtDg?= =?Windows-1252?Q?6nQ+0e4Ya50LbdXaV8wHZXYw4Eis3CfaRkyNTrfCeG0JzsQMoMKbD5hk?= =?Windows-1252?Q?wqcHC6Nza3k3ZGlSWRdKRspzMww8aQFrVy3C72UOBxmhvYk16ArvtaV6?= =?Windows-1252?Q?3HB1zPV2ztHF40TK1dAViasFEnkx1ssPm0b4j3dvdpaYCbkoJV7VMZNL?= =?Windows-1252?Q?pkR+tQAjyxyjF5zu4U1pS9oj3cXQiHt+iyq65b1RNQPOWODhnkehuZrh?= =?Windows-1252?Q?B9/7UmpcgyY4f8l4QzMsh/4qcVIAcglh9ZyaeAXrmOHv0NfmnR1BGqpM?= =?Windows-1252?Q?iCGGeXMCZX2kMHRdUnTWQz5jjLwhsfo7wmK587kQGrAL8r3ytB4SvhcP?= =?Windows-1252?Q?eSdxGr6AlEzuKNXyrV+QN+PHJNM7D3kRcLAapV1vj5D5Hmf4PI61UQ/8?= =?Windows-1252?Q?fJLJUNaiqh+P7cFGVNZVsWyQCJLL/9L4NN3I7ZYl9usycNVfm/WbI4OR?= =?Windows-1252?Q?AG9tUkXDrJsxLgSRJoG9trbZX1U/baAyGnnYlEgJmsPgi+u6gLM5e8qh?= =?Windows-1252?Q?GMbBsirrKCJIHrkaLAMmqcdwsX7eOx8MOW36WaH8211loiT/8Fi7ts?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:i6G60n+Up6pf4fIJv79o2m3CINRGcF6JmFmk90isEh1bd0Dt1OQ/nlkKT5aHB8LNiQv+JHb4y5w5rRP+hTdArSOvCTDON4/5F+CGvmbeR5Htsndo8AofBgGnTgOHEjmde40bFyuJoVSZ8YJCKkJmm5ZNuEPrfDiOf2V9f7I0GyBplnyYdRLS6RN6jX2ZMJG8hEEFYhGTfh3Sv1T0Szxikq83HXkFTVEx3AYQF21PwlwsqcsEJSXuqZQbe6bortkuZvjDyEKNdtrVYBNlgi9XYcYujsAG/xHVv3yMsgwr22Y=;5:iURwqqOREewAOeiV2luzU1BqHH8F6rqIgxc9ZnppNa+P1uOs6uw8JTjq0HLowMS35E3abbBmMEqnXQkeOf2a3AyNg4LQvVsrFdRSgKKdUbn+ZWUnc8rDGUor8zNxl6igkzycp1HZiKHFMbzFoVlnwA==;24:b0BV8Kf/4TkIXf0Hswxm0NYTfXjJj5AnGDVRdwjQED1qZQeHYceyNJSYODNsoQnrqNZbDPIqYfIw2qetrqNi/IBAG75AAlnt5J8NsZ3HAfw=;7:VzokBRzcXVdZX3VlfdjVNQgC+5sVLQ0wwylz1dmvvMylxnCO8KIpBVGFouLB4+aixfeK7UnrFbsZyBrKDMzUSRMp4p9EmH31i8phH0ljrdX5pcYH4KYK925S0xGumKRTJ2dBhSs++I64xT+34qoX2Ako0i5d+IqggygbU2jjxPh+R2anNWqRnAHwX7J6ok0OtlPsQuYVnEAZY3Dk27Q5b5aPyaOVaFIXGnWradpjrBLAE0tTzQcHFX/5WZ7a86jb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:T24HdNookSqqTo5B1OchXIy2zv/gvvN7ysT8eyxFtW65+RExFXCvkElB/ucv0B5SdGlUsxvnyDsONsCdUXzyRKiNtx1paqYmxtaZYnHUBr1EzE1JqHD6fGcmh2W+7wYANHuhqw0OpYTxmoX9mjfWULXRsGv5GTmw+UiIp81ecms= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 15:37:10.8101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-26_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2016 12:08 AM, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: > drivers/block/mtip32xx/mtip32xx.c:3689:6: warning: no previous prototype for > 'mtip_block_release' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. Applied for 4.9, thanks. -- Jens Axboe