From: Kyle Moffett <mrmacman_g4@mac.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: LKML Kernel <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [RFC] [PATCH] make add_taint() inline
Date: Sun, 11 Sep 2005 14:22:08 -0400 [thread overview]
Message-ID: <8244F3CF-9EF7-44BB-B3DA-B46A1FF39E1C@mac.com> (raw)
In-Reply-To: <20050911104437.6445ff20.donate@madrone.org>
On Sep 11, 2005, at 13:44:37, donate wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> add_taint() is a trivial function.
> No need to call it out-of-line, just make it inline and
> remove its export.
Actually, in this case it might be better to leave add_taint
exported, add and export a new function get_taint(), and then
remove all export of the variable "tainted". I've actually
seen one case where some module removed taint bits. I don't
remember where or why, but it seemed really bad at the time,
and still does. Also, does the tainted variable need any
kind of locking? What happens if two CPUs try to taint the
kernel simultaneously?
Cheers,
Kyle Moffett
--
Premature optimization is the root of all evil in programming
-- C.A.R. Hoare
next prev parent reply other threads:[~2005-09-11 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050911103757.7cc1f50f.rdunlap@xenotime.net>
2005-09-11 17:44 ` donate
2005-09-11 18:22 ` Kyle Moffett [this message]
2005-09-11 22:56 ` Randy.Dunlap
2005-09-11 23:10 ` Kyle Moffett
2005-09-11 19:44 ` Andrew Morton
2005-09-11 22:52 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8244F3CF-9EF7-44BB-B3DA-B46A1FF39E1C@mac.com \
--to=mrmacman_g4@mac.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®