From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20A0C77B73 for ; Tue, 30 May 2023 12:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232429AbjE3Mxo (ORCPT ); Tue, 30 May 2023 08:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232364AbjE3Mxc (ORCPT ); Tue, 30 May 2023 08:53:32 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 413D8E67; Tue, 30 May 2023 05:53:13 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7CAEB6606E99; Tue, 30 May 2023 13:52:55 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685451176; bh=YtD3nSjY4iTnCSBgu8N7wfNObpaGkqwVKKaA+WzbZOI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fNBVPndH+6jIxa4ONTK3bRFZC0x+eSJl6YGMX6RRmhrjBLxmkSvP0Rki6hN2YpyTM o/SHDuRMA/+Znnj++LYdUOBwqdI4KWacsrkxaWaNGJ1pDToSU1I7uWOJtpWZtALg8l StoIKZjSWgHr7aN4orkwe1vHVk3uJScz31uMXPoCR//vBN873VniUvnx4KXLRUVRpO pqLO5E0NbZymwcmNVTPx1XJbgi0oPM/QdqIfBFYj1ZGzLrw8j83ezlj6IvK96LH6Tz 00O1ewEJfbINAuQgFE0YmFqmGFuLnoENxarkFCbZdw7mkYIOivtGIUKRVma/txelgX csPWSid6A0Whw== Message-ID: <8247660d-4b95-0ed7-9444-b23da23560ac@collabora.com> Date: Tue, 30 May 2023 15:52:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] ASoC: es8316: Increment max value for ALC Capture Target Volume control Content-Language: en-US To: Mark Brown Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Zhu Ning , Pierre-Louis Bossart , Charles Keepax , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , David Yang , Daniel Drake , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, kernel@collabora.com References: <20230524074156.147387-1-cristian.ciocaltea@collabora.com> <20230524074156.147387-2-cristian.ciocaltea@collabora.com> <5dbcbf84-602a-44de-ad99-268d4d5b4b2f@sirena.org.uk> <01fd1a9f-56c7-4864-bb2b-8b004284c8cc@sirena.org.uk> <3c6b67a4-4892-0057-3dfc-65ed6c7ebc37@collabora.com> <4a3f54a3-2cbd-4a22-9742-9ba60e78643b@sirena.org.uk> From: Cristian Ciocaltea In-Reply-To: <4a3f54a3-2cbd-4a22-9742-9ba60e78643b@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/23 14:36, Mark Brown wrote: > On Fri, May 26, 2023 at 09:11:49PM +0300, Cristian Ciocaltea wrote: > >> -1.5 dB | 50-51 % >> -0.0 dB | 50-51 % > >> So it seems the specs are correct, and the problem is the hardware default. > >> Is there a better approach to handle this than extending the volume range? > > The other option would be to change the value in the register during > probe to one that's in range, that wouldn't stop any existing saved > settings from generating errors but would mean there wouldn't be any new > ones. Either approach is probably fine. Thanks, I will prepare v2 and keep the current approach.