From: "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Vasily Averin <vvs@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: vlan: allow vlan device MTU change follow real device from smaller to bigger
Date: Tue, 22 Feb 2022 10:06:03 +0800 [thread overview]
Message-ID: <8248d662-8ea5-7937-6e34-5f1f8e19190f@huawei.com> (raw)
In-Reply-To: <YhQ1KrtpEr3TgCwA@gondor.apana.org.au>
> On Mon, Feb 21, 2022 at 07:43:18AM -0800, Eric Dumazet wrote:
>>
>> Herbert, do you recall why only a decrease was taken into consideration ?
>
> Because we shouldn't override administrative settings of the MTU
> on the vlan device, unless we have to because of an MTU reduction
> on the underlying device.
>
> Yes this is not perfect if the admin never set an MTU to start with
> but as we don't have a way of telling whether the admin has or has
> not changed the MTU setting, the safest course of action is to do
> nothing in that case.
If the admin has changed the vlan device MTU smaller than the underlying
device MTU firstly, then changed the underlying device MTU smaller than
the vlan device MTU secondly. The admin's configuration has been overridden.
Can we consider that the admin's configuration for the vlan device MTU has
been invalid and disappeared after the second change? I think so.
>
> Thanks,
>
next prev parent reply other threads:[~2022-02-22 2:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 12:46 Ziyang Xuan
2022-02-21 15:43 ` Eric Dumazet
2022-02-22 0:58 ` Herbert Xu
2022-02-22 2:06 ` Ziyang Xuan (William) [this message]
2022-02-22 2:27 ` Eric Dumazet
2022-02-22 7:31 ` Ziyang Xuan (William)
2022-02-23 1:55 ` Ziyang Xuan (William)
2022-02-22 10:37 ` Guillaume Nault
2022-02-22 23:28 ` Jakub Kicinski
2022-02-23 11:26 ` Guillaume Nault
2022-02-23 15:17 ` Stephen Hemminger
2022-02-23 16:34 ` Guillaume Nault
2022-02-23 16:03 ` Jakub Kicinski
2022-02-23 16:58 ` Guillaume Nault
2022-02-23 17:37 ` Jakub Kicinski
2022-02-23 19:46 ` Guillaume Nault
2022-02-23 17:05 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8248d662-8ea5-7937-6e34-5f1f8e19190f@huawei.com \
--to=william.xuanziyang@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®