From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4555B3F9F3B for ; Tue, 11 Aug 2026 12:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786452889; cv=none; b=q4Pr1paAWa/ekqodeeQVhpi7EFnd8s6o7Upt6SP28dHg7j9RzEsLy98WxOTmd/6d2n6cfzWojI8aSY1dYgXFdjjBfDU7JaVSEfSKE6pRagzabMOXyy+2YX4sfEAPvhic8XdTtbPZospJRDPZhNWMg1nQw0Uq02w3WyuQo2Ex3mA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786452889; c=relaxed/simple; bh=WrGtbioOi/SDFuRuNSxOxOV6312aFHRM48aXVi4YmF0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uihNkFVwqvG1Oi/XfiGeCmHpzL832GVVcdd1jrnIxzoK2so3+x0g1NJus7yUnAOphht9dRV2Va3dqPC+94qXoRm29kZyDz8hxGVr0BHGvlKhQwh6kqFid4nmpR7g+mGD0pqBa38/zWRli7JHqwUgClwzW1nfJYuVYlf89oCDfBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X4SXIOo6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dn1yd/27; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X4SXIOo6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dn1yd/27" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67BCR2rV663522 for ; Tue, 11 Aug 2026 12:54:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= q2flNnNINmCRt7k82OXXAcPlTbp6zvDLw77zk2/CNIA=; b=X4SXIOo62TvEmWjZ 4VtxsL6b5UZqW/pZxZP3sTkge7WMUMg82U4FUS+0WCkw0YMDrhbxDz2xaX6L8R2n JzFK2OQTMvw1rFnDLLvP7D31Xljc3AJFzTYs+vlFrJRXjBf6Y1SUeBQt5TlTXYsH 6O52WqoHOCJ4v9lgMj4zrKBfTBWdL7J9kzBf9G50P5uxlRojfHrLYBnHvsj0Abj7 S6uqNOR9Mvnk34dp73264nHW6Y6kKwtSe88BiOg7n9h9YjSHOUTWARq8NXD9UO7j Tkyyqcg+VAwXIKH/acpUAlSO7AnQMzXwIWyNReH2QWW55714ec92MtPfnmDYZ9CK ANHu6Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fyjk24769-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 11 Aug 2026 12:54:47 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38dd87656d3so3828648a91.2 for ; Tue, 11 Aug 2026 05:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786452887; x=1787057687; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q2flNnNINmCRt7k82OXXAcPlTbp6zvDLw77zk2/CNIA=; b=Dn1yd/27hdA9Sgd+qaNrQlXCSkGfhOG6aHxVyYRSHiK2ZfVLPSJ1WbZRvhVTWu61oh ZnqpeQVi40GkugFIWw6mFOKAxTdask+W7ReUJTrQ+T2eaBaQS2XDQgXJYbH0wapK03js SJXm9MibYOCtvO7m46QIBF3mHngBpavnoaKb+i4u8vloqgGWOObRdIdDZbNS1niOFyhZ 4m58ccK57zGZkWiBXpfP51Sg1KEEus6fOUUtbPk6RtnQXafjPGgjYtDgEMOp1xcB0u5f 1xcP598yEx9QAF9Zl6NRFQuaKTGskFS4nLTM0TF9B7xWlUKYjI3m0ee4P15Q4CY2sH4e +3bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786452887; x=1787057687; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q2flNnNINmCRt7k82OXXAcPlTbp6zvDLw77zk2/CNIA=; b=WBKbQyFtjCXVie2Dz4ngI4g45Fn5+LhNVo2dZUObGI8vWop9rX+qdJfZ5HQVNjOKiE nbIFfdYUQ7DSZPTxbTc6WTKRD8Odh8fPvDa6TkIVJVwJ9ah+6EC6dQHKEdK+F0s64GKS 2rPOoK/0TFReuE/LoAMQA/3Msho7P80AxYTFCmtlvz3kR4lTixta6eEESCcioz7pevKm LRE+aZT7rt5F7uC8Ikxyne2mok4SAZ0JUVMi2Bo3fKynVZsNJimtHVcJLHZI+ocQmWq4 XStRzqJ55giO7UtwYewXLp5uObRf/uVQ5KNHkoY7CfJBeukLfAMOh1bdQDDD29wOS4DP wN1g== X-Forwarded-Encrypted: i=1; AHgh+RrJkJCWY9JR7HdSFL1MckDLCtCDxcjsXPgAJYv/on/EMy493TyS9w8bnt7i46Dkl65KgRl+YxoLsQR77D0=@vger.kernel.org X-Gm-Message-State: AOJu0YwG5LSQDFgHp3Jt86CE3kQZZyE2OsbDs22RY2psRWWskLWciq3Q mCk8y6RTCmPTRoWkqQahbiplAbdojWtMcVG8hGxXOhXCCXWFMLrtHKE4MqXHCNKkw8aUnRy2/rm ovegUh4FtyRjp0yHccBzDvXzZUgLGZdKU5n83PoSNs2FIRa7jpuQJsoriWCZzk5COukY= X-Gm-Gg: AR+sD12PKdhXoMLU/19tNQbwgSTJxjmVTd4OKEkbYVli+d10mZFstQyNx0H/NIx82nB PKvbaaK5ZQr4JV25VJqzpfu2o/XMVRCBzhWXfhbKNE/v8LfcmpfN7Q5oZ/TKnLjLl4S7fbtGvPq AusGXD0ZpMkQsgWMUQU1ZUlAZ/dolpcvSzb1gOqAWWENELLPvnm5YFee/eUuTBdqkYn4ACBmDI0 Ng6Fz5qAQTtcswOTwnF08rkAvZrwSVGwTKMx7dHowTDPJ0lmOzF+l81lLkDlo0D5K1HPNWSSHNi wsYeJQ2zaQyRZ+LPi3hDonwg+n1k9V4H4+nCqr+ZKto6ZruhHMx/oWbI4IMP4WJwSjaxw6nvZ3T lOcX0RGhDBo0Kpq99Uz1uD69b34UXBSTaWJYo4Zg/iTLoLmvDhTThT54QOrs//fK+ X-Received: by 2002:a17:90b:2692:b0:38f:1dc:672f with SMTP id 98e67ed59e1d1-392ec6a78c8mr3427688a91.18.1786452886584; Tue, 11 Aug 2026 05:54:46 -0700 (PDT) X-Received: by 2002:a17:90b:2692:b0:38f:1dc:672f with SMTP id 98e67ed59e1d1-392ec6a78c8mr3427620a91.18.1786452886012; Tue, 11 Aug 2026 05:54:46 -0700 (PDT) Received: from [10.133.33.35] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d534abfasm3860675a91.11.2026.08.11.05.54.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 05:54:45 -0700 (PDT) Message-ID: <8248f034-d5a6-4f9c-b6e6-77eeb8ca3ad4@oss.qualcomm.com> Date: Tue, 11 Aug 2026 20:54:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: ipq-cmn-pll: keep the CMN block bus clocks enabled To: Stanislaw Pal , Mieczyslaw Nalewaj Cc: Bjorn Andersson , Stephen Boyd , Michael Turquette , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260809161012.378743-1-kuncy7@gmail.com> Content-Language: en-US From: Jie Luo In-Reply-To: <20260809161012.378743-1-kuncy7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDEwNyBTYWx0ZWRfX4g62Yazg5U19 4/DwlO3pTFEoneM0yDEchRPsLAFEnXxX2tO7nVk5GmYPnqXGX/SYxSbqGOxJM/Rop2DanJJXRJd 0KkRcvk+oSZS/KscZVIF8RPBTkwnJo8= X-Proofpoint-GUID: Gt20jXvr9ru5sOdFnXEl5V8ZCSJo2PEQ X-Proofpoint-ORIG-GUID: Gt20jXvr9ru5sOdFnXEl5V8ZCSJo2PEQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDEwNyBTYWx0ZWRfX93jGb88wrE4C ezYQup0lQ6jWQpV4QovmcEBKu+XW+K9DA6Fh7zhIM0yBReah53HDu7+FrIrvPJypdwp5RkLV2Mb U/WDREMYkNPFUhscoqS+irHvhGP8bDOmZeu7BKj+AslyPUHPGmCd2oAgTlxudXqH36ALqWb0Hi6 3ThI9eKI3IVOJp7wLWrLuwzHvvyVzulvc8dm5SR9edaIfh+XFXu+dN8fs790uNaHbV8rfTN1M1+ uA2LSC4wBCukMad820x3vw51Rc03C8L52v1gPs/M0wP83v88GD+jdimlFAQkuSVc7Gp3gvCS342 +N0hnWoIhSz+LtsDnaVJ8QBj1+FWLRClexD9oNsQa5uc8HNcimwgapew/w4wOa4iKb3AT6ewe5J H26eKFTp8PRuukrp2T11IV6AS3lP2EGNKTxHWK0hHovMWV30/wOJPqTPp6IF1H3rgaZlDaEjGDG bhBh10xybPvBdUg0WmQ== X-Authority-Analysis: v=2.4 cv=eJ4jSnp1 c=1 sm=1 tr=0 ts=6a7b1b97 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=Ki7mIbe9vPJvlQghS2sA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-11_02,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110107 On 8/10/2026 12:10 AM, Stanislaw Pal wrote: > On 8/8/2026 Mieczyslaw Nalewaj wrote: >> Given the hang is reportedly 100% reproducible pre-userspace, is there >> a concrete next step to root-cause it, or is v3 the right call for now >> with a follow-up tracked separately? > > There is a concrete step, and I ran it today on a third board - this > time with no code of mine involved at all. > > Hardware: GL.iNet GL-B3000 (IPQ5018), a supported in-tree OpenWrt > board, running the current bone-stock OpenWrt snapshot (kernel > 6.18.41, which does not carry this patch). Out of the box it boot > loops: the last line on earlycon is at ~0.39s (the final initcall > before the driver probes start), then silence and a watchdog reset, > 100% reproducible. > > Adding exactly one thing to the kernel command line - no rebuild, no > patch: > > initcall_blacklist=ipq_cmn_pll_clk_driver_init > > makes the same image boot: serial, SPI-NAND, SMEM partitions, > remoteproc all come up. > > Combined with what we already know from the other two boards, this > isolates the trigger fairly tightly: > > - cmn-pll probe runs, last PM reference dropped (vanilla): dies > - cmn-pll probe never runs (blacklist, clocks stay as the > bootloader left them, i.e. enabled): boots > - cmn-pll probe runs, reference held: boots - verified on this same > board today with an image carrying v3 of this patch and nothing > else changed; it comes up fully (shell over SSH, NAND, remoteproc), > and clk_summary shows the CMN block bus clocks held enabled by the > provider device. > > The only variable separating the dying case from both surviving ones > is the AHB/SYS gate after probe. What exactly performs the fatal > access afterwards is the remaining open question - and this board is > well suited to answer it, since it has full U-Boot control and can run > experiment kernels from RAM. I intend to bisect that next (my current > suspicion is that the CMN block AHB clock also feeds the register path > of neighbouring blocks in the same region - MDIO at 0x88000/0x90000, > uniphy at 0x98000, CMN at 0x9b000 - which would explain why the CCF's > own runtime PM handling around the clk ops cannot help here). I am > happy to run any experiment Jie would like to see on this hardware. > > So to answer the question directly: I believe v3 is the right call now > - three IPQ5018 boards, including a stock-image one, cannot boot > without it and the cost of keeping two bus clocks of a small block > enabled is negligible - with the exact-access root-causing tracked as > a follow-up. If the follow-up ends up pointing at a cleaner fix (e.g. > describing the real consumers of these bus clocks in DT), I will > gladly send it as a successor. > > Thanks, > Stanislaw I tested the latest linux-next code with the following changes: Enabled the MDIO interface and added the Ethernet PHY as DTS below. Enabled CONFIG_IPQ_CMN_PLL and CONFIG_MDIO_IPQ4019 as kernel modules. --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi @@ -219,12 +219,11 @@ mdio0: mdio@88000 { <0x019475c4 0x4>; #address-cells = <1>; #size-cells = <0>; + clock-frequency = <6250000>; clocks = <&gcc GCC_MDIO0_AHB_CLK>; clock-names = "gcc_mdio_ahb_clk"; - status = "disabled"; - ge_phy: ethernet-phy@7 { compatible = "ethernet-phy-id004d.d0c0"; reg = <7>; @@ -241,11 +240,16 @@ mdio1: mdio@90000 { reg = <0x00090000 0x64>; #address-cells = <1>; #size-cells = <0>; + pinctrl-0 = <&mdio_pins>; + pinctrl-names = "default"; + clock-frequency = <6250000>; clocks = <&gcc GCC_MDIO1_AHB_CLK>; clock-names = "gcc_mdio_ahb_clk"; - status = "disabled"; + ethernet-phy@1c { + reg = <0x1c>; + }; }; cmn_pll: clock-controller@9b000 { @@ -427,6 +431,23 @@ uart1_pins: uart1-state { drive-strength = <8>; bias-pull-down; }; + + mdio_pins: mdio-state { + mdc-pins { + pins = "gpio36"; + function = "mdc"; + drive-strength = <8>; + bias-pull-up; + }; + + mdio-pins { + pins = "gpio37"; + function = "mdio"; + drive-strength = <8>; + bias-pull-up; + }; + }; + }; The board booted successfully on the IPQ5018 RDP platform. # insmod ipq-cmn-pll.ko # # devmem 0x1856308 0x80000000 # devmem 0x185630c 0x80000000 # # insmod mdio-ipq4019.ko # # ls -l /sys/bus/mdio_bus/devices/ 88000.mdio-1:07/ 90000.mdio-1:1c/ # ls -l /sys/bus/mdio_bus/devices/ total 0 lrwxrwxrwx 1 root root 0 Jan 1 00:01 88000.mdio-1:07 -> ../../../devices/platform/soc@0/88000.mdio/mdio_bus/88000.mdio-1/88000.mdio-1:07 lrwxrwxrwx 1 root root 0 Jan 1 00:01 90000.mdio-1:1c -> ../../../devices/platform/soc@0/90000.mdio/mdio_bus/90000.mdio-1/90000.mdio-1:1c