From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Qingshuang Fu <fffsqian@163.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH] selftests: netfilter: Remove unused variables in conntrack_dump_flush
Date: Thu, 6 Aug 2026 10:45:10 +0200 [thread overview]
Message-ID: <824bc2e7-5ee7-441b-949d-817817f32fd0@suse.de> (raw)
In-Reply-To: <20260806075052.1934904-1-fffsqian@163.com>
On 8/6/26 9:50 AM, Qingshuang Fu wrote:
> From: Qingshuang Fu <fuqingshuang@kylinos.cn>
>
> The variables 'rplnlh' in conntrack_data_insert() and 'rplnlh' together
> with 'nest' in conntracK_count_zone() and conntrack_flush_zone() were
> declared but never used since they were introduced.
>
> Similarly, commit 76342e842587 ("selftests: netfilter: remove unused
> parameter") removed the unused 'err' variable from these functions but
> overlooked the remaining unused 'rplnlh' and 'nest' variables. Remove
> them to clean up the code.
>
> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")
> Signed-off-by: Qingshuang Fu <fuqingshuang@kylinos.cn>
> ---
Thanks for patch, it looks good to me but could we avoid the fixes tag here?
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
next prev parent reply other threads:[~2026-08-06 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 7:50 Qingshuang Fu
2026-08-06 8:45 ` Fernando Fernandez Mancera [this message]
2026-08-06 9:03 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824bc2e7-5ee7-441b-949d-817817f32fd0@suse.de \
--to=fmancera@suse.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fffsqian@163.com \
--cc=fuqingshuang@kylinos.cn \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®