From: David Ahern <dsahern@gmail.com>
To: Anish Udupa <udupa.anish@gmail.com>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv4: Fixed some styling issues.
Date: Wed, 17 Mar 2021 09:50:55 -0600 [thread overview]
Message-ID: <824c82b7-ea4d-9b64-9f5a-61577c1d7584@gmail.com> (raw)
In-Reply-To: <CAPDGunOVtW5mZWXwEjtT3qWXNG4WgkdEa3jV79QKVHOmjHU-9Q@mail.gmail.com>
On 3/17/21 9:07 AM, Anish Udupa wrote:
> Ran checkpatch and found these warnings. Fixed some of them in this patch.
> a) Added a space before '='.
> b) Removed the space before the tab.
>
> Signed-off-by: Anish Udupa H <udupa.anish@gmail.com>
> ---
> net/ipv4/route.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 02d81d79deeb..0b9024584fde 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -2236,7 +2236,7 @@ out: return err;
> if (!rth)
> goto e_nobufs;
>
> - rth->dst.output= ip_rt_bug;
> + rth->dst.output = ip_rt_bug;
> #ifdef CONFIG_IP_ROUTE_CLASSID
> rth->dst.tclassid = itag;
> #endif
> @@ -2244,9 +2244,9 @@ out: return err;
>
> RT_CACHE_STAT_INC(in_slow_tot);
> if (res->type == RTN_UNREACHABLE) {
> - rth->dst.input= ip_error;
> - rth->dst.error= -err;
> - rth->rt_flags &= ~RTCF_LOCAL;
> + rth->dst.input = ip_error;
> + rth->dst.error = -err;
> + rth->rt_flags &= ~RTCF_LOCAL;
> }
>
> if (do_cache) {
>
your patch seems to have lost one or more tabs at the beginning of each
line.
prev parent reply other threads:[~2021-03-17 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 15:07 Anish Udupa
2021-03-17 15:50 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824c82b7-ea4d-9b64-9f5a-61577c1d7584@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=udupa.anish@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®