On 19.11.26 05:35, Lin Liu wrote: > On 18/11/2026 12:24, Jürgen Groß wrote: >> On 18.11.26 12:25, Ross Lagerwall wrote: >>> Is the change actually needed for alloc_coherent / free_coherent? >>> The allocation from __get_free_pages() is naturally aligned and >>> range_requires_alignment() requires it has the same alignment so it is >>> naturally aligned in bus space. I don't think that it can cross a >>> segment boundary then. >> >> Hmm, agreed. > > Thanks both. Agreed, the check is unnecessary for the coherent paths. > I had noted this in the commit message ("coherent allocations are already > naturally aligned via range_requires_alignment()"), but the code still > changed them. > > For v2 I plan to leave range_straddles_page_boundary() and the coherent > paths untouched, and check only streaming mappings, with a small helper > next to range_straddles_page_boundary(): > > /* Bus-contiguous, but may still cross the device's segment boundary */ > static inline bool range_crosses_seg_boundary(struct device *dev, > dma_addr_t dma, size_t size) > { > unsigned long mask = dma_get_seg_boundary(dev); > > return size && ((dma ^ (dma + size - 1)) & ~mask); > } > > used in xen_swiotlb_map_phys(): > > if (dma_capable(dev, dev_addr, size, true, attrs) && > !dma_kmalloc_needs_bounce(dev, size, dir) && > !range_straddles_page_boundary(phys, size) && > !range_crosses_seg_boundary(dev, dev_addr, size) && > !xen_arch_need_swiotlb(dev, phys, dev_addr) && > !is_swiotlb_force_bounce(dev)) > goto done; > > A mapping larger than the boundary window also takes the bounce path: > swiotlb cannot find slots that do not span the boundary, so the mapping > fails instead of the device being handed a crossing range. > > This is the shape of the version Jürgen first looked at, before the check > was moved into the helper. > > I'll send v2 if you are both happy with that. Could you please add a comment to the alloc_coherent path that the check isn't needed there due to the alignment guaranteed by __get_free_pages()? Juergen