mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC: dts: Remove leading 0x from node unit addresses
Date: Mon, 18 Jun 2018 13:07:32 -0700	[thread overview]
Message-ID: <8268db75d4698a4fba9aa11de7e8f6d6f20a0515.camel@perches.com> (raw)
In-Reply-To: <20180618191645.15247-1-krzk@kernel.org>

On Mon, 2018-06-18 at 21:16 +0200, Krzysztof Kozlowski wrote:
> Remove leading 0x from all node unit addresses with a sed command:
> 
>     sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" arch/arc/boot/dts/*.dts*
> 
> This fixes DTC warnings like:
> 
>     Warning (unit_address_format): /cpu_card/dw-apb-gpio@0x2000: unit name should not have leading "0x"

Do all of these need fixing?

Aren't there dozens of these in arch/arm and elsewhere too?

$ git grep -i -P "@0x([0-9a-f]+)\s*\{" -- "*.dt*"|cat
arch/arc/boot/dts/abilis_tb10x.dtsi:		spi0: spi@0xFE010000 {
arch/arc/boot/dts/abilis_tb10x.dtsi:		spi1: spi@0xFE011000 {
arch/arc/boot/dts/axc001.dtsi:		dw-apb-gpio@0x2000 {
arch/arc/boot/dts/axc001.dtsi:		debug_uart: dw-apb-uart@0x5000 {
arch/arc/boot/dts/axc001.dtsi:	mb_intc: dw-apb-ictl@0xe0012000 {
arch/arc/boot/dts/axc003.dtsi:		dw-apb-gpio@0x2000 {
arch/arc/boot/dts/axc003.dtsi:		debug_uart: dw-apb-uart@0x5000 {
arch/arc/boot/dts/axc003.dtsi:	mb_intc: dw-apb-ictl@0xe0012000 {
arch/arc/boot/dts/axc003_idu.dtsi:		dw-apb-gpio@0x2000 {
arch/arc/boot/dts/axc003_idu.dtsi:		debug_uart: dw-apb-uart@0x5000 {
arch/arc/boot/dts/axc003_idu.dtsi:	mb_intc: dw-apb-ictl@0xe0012000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		ethernet@0x18000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		ehci@0x40000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		ohci@0x60000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		mmc@0x15000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		uart@0x20000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		uart@0x21000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		uart@0x22000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		i2c@0x1d000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		i2c@0x1f000 {
arch/arc/boot/dts/axs10x_mb.dtsi:			eeprom@0x54{
arch/arc/boot/dts/axs10x_mb.dtsi:			eeprom@0x57{
arch/arc/boot/dts/vdk_axc003.dtsi:		debug_uart: dw-apb-uart@0x5000 {
arch/arc/boot/dts/vdk_axc003.dtsi:	mb_intc: dw-apb-ictl@0xe0012000 {
arch/arc/boot/dts/vdk_axc003_idu.dtsi:		debug_uart: dw-apb-uart@0x5000 {
arch/arc/boot/dts/vdk_axc003_idu.dtsi:	mb_intc: dw-apb-ictl@0xe0012000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		ethernet@0x18000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		ehci@0x40000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		uart@0x20000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		uart@0x21000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		uart@0x22000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		mmc@0x15000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:	uio_ev: uio@0xD0000000 {
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts:						bootloaderenv@0x100000 {
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts:						bootloaderenvred@0x140000 {
arch/arm/boot/dts/atlas7.dtsi:			pmipc@0x13240000 {
arch/arm/boot/dts/atlas7.dtsi:			gnssmfw@0x18100000 {
arch/arm/boot/dts/atlas7.dtsi:			gpum@0x13000000 {
arch/arm/boot/dts/atlas7.dtsi:			sdr@0x13010000 {
arch/arm/boot/dts/atlas7.dtsi:			memory-controller@0x10800000 {
arch/arm/boot/dts/atlas7.dtsi:			retain@0x188D0000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@0x80000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@0x1c0000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@0x280000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@0x780000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@0x80000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@0x1c0000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@0x280000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@0x780000 {
arch/arm/boot/dts/keystone-k2e-netcp.dtsi:		pdsp0@0x2a10000 {
arch/arm/boot/dts/keystone-k2hk-netcp.dtsi:		pdsp0@0x2a10000 {
arch/arm/boot/dts/keystone-k2l-netcp.dtsi:		pdsp0@0x2a10000 {
arch/arm/boot/dts/socfpga.dtsi:		l3regs@0xff800000 {
arch/arm/boot/dts/spear300.dtsi:		shirq: interrupt-controller@0x50000000 {
arch/arm/boot/dts/spear310.dtsi:		shirq: interrupt-controller@0xb4000000 {
arch/arm/boot/dts/spear320.dtsi:		shirq: interrupt-controller@0xb3000000 {
arch/arm64/boot/dts/exynos/exynos5433.dtsi:		sysmmu_scaler_0: sysmmu@0x15040000 {
arch/arm64/boot/dts/exynos/exynos5433.dtsi:		sysmmu_scaler_1: sysmmu@0x15050000 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@0x0 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@0x6000000 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@0x6800000 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@0x7fe0000 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@0x0 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@0x400000 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@0xa00000 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@0xfe0000 {
arch/xtensa/boot/dts/xtfpga-flash-4m.dtsi:			partition@0x0 {
arch/xtensa/boot/dts/xtfpga-flash-4m.dtsi:			partition@0x3f0000 {


  reply	other threads:[~2018-06-18 20:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 19:16 Krzysztof Kozlowski
2018-06-18 20:07 ` Joe Perches [this message]
2018-06-19  6:09   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8268db75d4698a4fba9aa11de7e8f6d6f20a0515.camel@perches.com \
    --to=joe@perches.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=abrodkin@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®