From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABC9C43466 for ; Mon, 21 Sep 2020 16:36:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1E712396F for ; Mon, 21 Sep 2020 16:36:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fnaYptNQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729017AbgIUQgw (ORCPT ); Mon, 21 Sep 2020 12:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727248AbgIUQgt (ORCPT ); Mon, 21 Sep 2020 12:36:49 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F28C061755 for ; Mon, 21 Sep 2020 09:36:49 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j2so13493992wrx.7 for ; Mon, 21 Sep 2020 09:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i047OCSlx026/Yej+lLApd9wks4kMyKz8RfAY/wU+IY=; b=fnaYptNQLJYqN12KIQYAO8/g/W6HQUgEF41DUo46RaMSJaY36li9p7HpTRpmi9U7rb Sq/1WAR85VQcUe+WA4dnt3WA6SbIz+HKT6LVg+iUaFbuZqwFpSp9Ox7GYa9NLFjCYXDC 26u7SC9YVkT4804uJ2HL4vDZ3zZfM83cq/fpoVrTIOv3X4KtDf7MXt0a4W189zvn42dw Ekp6oNtMVf98ZVKQ6wbJowG9+XRxPu15rSDCwSGtK0pLh1cevPCWXbmOjzEzvj1AwXCO y4iEBigx+MybfZ8YKfnIUgpwlhsctTdYu1i2qO/m34CTtPRdM8xbsE3IMm8Hon/fZkOR ANjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i047OCSlx026/Yej+lLApd9wks4kMyKz8RfAY/wU+IY=; b=sEuWonQx0fi3KEMVX3uv9BXfdHxSmb6tOQYmMUcOUwz5mYlMuJjpgDn0xLk3XQd88b nfUsj2pUD3EMNUVkzNGc66Rv6KU0ltrPo6wYR4TlE58lPgpLwY1uc5T2o8Zh/W1Ge408 DiEbXQyHE2U2n7Csap3UnX3gae2prK9qZe35UaklKKUScLaKM1LotmK792vFoA/qA/ED pThYuSVSDz9gfzwWYiU5Cs/45QdX4jRmeppeN4mnnb393tbv4+/RuUSjn/Ey6wC+BDBR 5EKXdqmQdUG4RbKjWiIQs5Q/WR84xT9xpGxsmjm+raCZuBtxw4SWDwSuOmGTMh5MimWr mpyQ== X-Gm-Message-State: AOAM531wakbRX/lXXtwYIZDeNFwXoi33k9xps5LfT+hk7X6NccGP4kSg TxqgEuvdZjs4pgb8xePJ49I= X-Google-Smtp-Source: ABdhPJyE6UTU+NOoQbGA0PsvLxZuHcEl/orKyvrLnH2D9aPBBwzeT9orNU7S0BsGCCw3FJwRz3Lzlw== X-Received: by 2002:a5d:444e:: with SMTP id x14mr578878wrr.235.1600706207846; Mon, 21 Sep 2020 09:36:47 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id s12sm201994wmd.20.2020.09.21.09.36.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2020 09:36:47 -0700 (PDT) Subject: Re: [PATCH v3 9/9] drm/mediatek: reduce clear event To: Bibby Hsieh , Dennis YC Hsieh Cc: Philipp Zabel , David Airlie , Daniel Vetter , CK Hu , Houlong Wei , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com, HS Liao References: <1594136714-11650-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1594136714-11650-10-git-send-email-dennis-yc.hsieh@mediatek.com> <1594262378.21095.3.camel@mtksdaap41> From: Matthias Brugger Message-ID: <826a79e6-7d4d-90e5-d9a7-4724753dc2d7@gmail.com> Date: Mon, 21 Sep 2020 18:36:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1594262378.21095.3.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2020 04:39, Bibby Hsieh wrote: > Hi, Dennis, > > Thanks for this patch. > > It's better to send another tree for this patch. > Because this tree is only for soc/mediatek. > > Please do not forget to add the dependency information. Normally you are right. This time I took this patch as well into my tree. I verified with the merge tag from CKs DRM tree that we don't have any conflicts, so we should be Ok. Regards, Matthias > > Bibby > > On Tue, 2020-07-07 at 23:45 +0800, Dennis YC Hsieh wrote: >> No need to clear event again since event always clear before wait. >> This fix depend on patch: >> "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api" >> >> Fixes: 2f965be7f9008 ("drm/mediatek: apply CMDQ control flow") >> Signed-off-by: Dennis YC Hsieh > > Reviewed-by: Bibby Hsieh > >> --- >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c >> index c84e7a14d4a8..ba6cf956b239 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c >> @@ -490,7 +490,7 @@ static void mtk_drm_crtc_hw_config(struct mtk_drm_crtc *mtk_crtc) >> mbox_flush(mtk_crtc->cmdq_client->chan, 2000); >> cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE); >> cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event); >> - cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, true); >> + cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, false); >> mtk_crtc_ddp_config(crtc, cmdq_handle); >> cmdq_pkt_finalize(cmdq_handle); >> cmdq_pkt_flush_async(cmdq_handle, ddp_cmdq_cb, cmdq_handle); >