From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32643C433DF for ; Wed, 14 Oct 2020 01:08:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0EDF20EDD for ; Wed, 14 Oct 2020 01:08:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730813AbgJNBIb (ORCPT ); Tue, 13 Oct 2020 21:08:31 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15283 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727331AbgJNBIb (ORCPT ); Tue, 13 Oct 2020 21:08:31 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AC2001451D627FFCD02E; Wed, 14 Oct 2020 09:08:21 +0800 (CST) Received: from [127.0.0.1] (10.174.177.134) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Wed, 14 Oct 2020 09:08:18 +0800 Subject: Re: [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led To: Dan Murphy , Rob Herring , "Pavel Machek" , linux-leds , Lee Jones , Benson Leung , "Enric Balletbo i Serra" , Guenter Roeck , Mark Brown , linux-spi , Lubomir Rintel , devicetree , linux-arm-kernel , linux-kernel References: <20201013160845.1772-1-thunder.leizhen@huawei.com> <20201013160845.1772-2-thunder.leizhen@huawei.com> <1565f22c-7be9-e771-7def-afbb28ec07a7@ti.com> From: "Leizhen (ThunderTown)" Message-ID: <82761c4f-6533-9b63-daa4-146a58816f5b@huawei.com> Date: Wed, 14 Oct 2020 09:08:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1565f22c-7be9-e771-7def-afbb28ec07a7@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.134] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/14 0:17, Dan Murphy wrote: > Zhen > > On 10/13/20 11:08 AM, Zhen Lei wrote: >> The color value of multi-led is fixed to "const: 8 #LED_COLOR_ID_MULTI", >> which is required by leds-class-multicolor.yaml. >> >> Signed-off-by: Zhen Lei >> --- >>   Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml >> index 58e974793a7976b..cd877e817ad1a1c 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml >> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml >> @@ -197,7 +197,7 @@ examples: >>                  #address-cells = <1>; >>                  #size-cells = <0>; >>                  reg = <0x2>; >> -               color = ; >> +               color = ; >>                  function = LED_FUNCTION_STANDBY; >>                  linux,default-trigger = "heartbeat"; >>   > > This is not correct.  ID_RGB is the correct variable here. > > https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024 > > Correct fix is to update the leds-class-multicolor.yaml OK > > Dan > > > . >